Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040608Retail ModulesWeb POSpublic2019-04-12 10:092019-06-18 13:59
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040608: Product properties should not be included in the json sent to OrderLoader
Descriptionwith huge receipts, with more than 300 lines, the json sent to backoffice is very big, and it could raise the maximum length allowed in Data Import Entry record or Error While Importing
Steps To Reproducen/a
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040609 closed rqueralta jsoninfo column size in Error While Importing window should be increased to 10M 
related to defect 0050606RR22Q1.2 closed ranjith_qualiantech_com Jsoninfo column size in Error While Importing window should be increased to 40M 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-12 10:09malsasuaNew Issue
2019-04-12 10:09malsasuaAssigned To => Retail
2019-04-12 10:09malsasuaResolution time => 1557007200
2019-04-12 10:09malsasuaTriggers an Emergency Pack => No
2019-04-12 10:16malsasuaRelationship addedrelated to 0040609
2019-04-19 09:47ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-04-19 09:47ranjith_qualiantech_comStatusnew => scheduled
2019-04-24 09:02hgbotCheckin
2019-04-24 09:02hgbotNote Added: 0111253
2019-04-24 09:03hgbotCheckin
2019-04-24 09:03hgbotNote Added: 0111254
2019-04-25 08:56hgbotCheckin
2019-04-25 08:56hgbotNote Added: 0111298
2019-04-25 08:56hgbotCheckin
2019-04-25 08:56hgbotNote Added: 0111299
2019-04-25 08:56hgbotStatusscheduled => resolved
2019-04-25 08:56hgbotResolutionopen => fixed
2019-04-25 08:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2377dc555e8af1f2434dbf153aea8df1292f0e41 [^]
2019-04-25 17:04adrianromeroReview Assigned To => marvintm
2019-04-26 08:41marvintmStatusresolved => closed
2019-04-26 08:41marvintmFixed in Version => RR19Q3
2019-04-26 14:23hgbotCheckin
2019-04-26 14:23hgbotNote Added: 0111362
2019-05-09 17:03marvintmStatusclosed => new
2019-05-09 17:03marvintmResolutionfixed => open
2019-05-09 17:03marvintmFixed in VersionRR19Q3 =>
2019-05-09 17:04marvintmResolution time1557007200 => 1557871200
2019-05-09 17:04marvintmNote Added: 0111605
2019-05-10 05:15ranjith_qualiantech_comStatusnew => scheduled
2019-05-13 09:07hgbotCheckin
2019-05-13 09:07hgbotNote Added: 0111636
2019-05-14 04:29ranjith_qualiantech_comStatusscheduled => resolved
2019-05-14 04:29ranjith_qualiantech_comResolutionopen => fixed
2019-05-14 18:45marvintmStatusresolved => closed
2019-05-14 18:45marvintmFixed in Version => RR19Q3
2019-06-17 13:48aferrazStatusclosed => new
2019-06-17 13:48aferrazResolutionfixed => open
2019-06-17 13:48aferrazFixed in VersionRR19Q3 =>
2019-06-17 13:49aferrazNote Added: 0112824
2019-06-17 15:52ranjith_qualiantech_comStatusnew => scheduled
2019-06-17 15:59hgbotCheckin
2019-06-17 15:59hgbotNote Added: 0112833
2019-06-17 15:59hgbotStatusscheduled => resolved
2019-06-17 15:59hgbotResolutionopen => fixed
2019-06-17 15:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2377dc555e8af1f2434dbf153aea8df1292f0e41 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b396ceed9388a6c3a9a5df69aaacc68c93516ad [^]
2019-06-18 13:59guilleaerReview Assigned Tomarvintm => guilleaer
2019-06-18 13:59guilleaerStatusresolved => closed
2019-06-18 13:59guilleaerFixed in Version => RR19Q3
2022-10-21 18:27axelmercadoRelationship addedrelated to 0050606

Notes
(0111253)
hgbot   
2019-04-24 09:02   
Repository: erp/pmods/org.openbravo.retail.productonthefly
Changeset: 6e272139dd8036e5bec50d9346f1b03bc81f6de1
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Apr 24 12:32:41 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.productonthefly/rev/6e272139dd8036e5bec50d9346f1b03bc81f6de1 [^]

Related to issue 40608 : Product properties should be included in the json sent to OrderLoader

* Product properties with saveToReceipt as true will be saved in receipt json which sent to OrderLoader

---
M web/org.openbravo.retail.productonthefly/js/modalproduct.js
---
(0111254)
hgbot   
2019-04-24 09:03   
Repository: erp/pmods/org.openbravo.retail.servicesequence
Changeset: f5b89be7fdc81cbb9c1557309ee0c2ca4efb5c2c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Apr 24 12:32:51 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.servicesequence/rev/f5b89be7fdc81cbb9c1557309ee0c2ca4efb5c2c [^]

Related to issue 40608 : Product properties should be included in the json sent to OrderLoader

* Product properties with saveToReceipt as true will be saved in receipt json which sent to OrderLoader

---
M web/org.openbravo.retail.servicesequence/js/model/productProperties.js
---
(0111298)
hgbot   
2019-04-25 08:56   
Repository: tools/automation/pi-mobile
Changeset: d53feeb957961298ed6b073f6ff548e88865ef50
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Apr 25 12:25:17 2019 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d53feeb957961298ed6b073f6ff548e88865ef50 [^]

Verifies issue 40608 : Modified best deal automated tests

* Discount Name TestId is updated with ExtModule TestId

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bestdeal/I32379_BestDealRecalculateTicket.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bestdeal/I32467_BestDealNotDeletingLines.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bestdeal/I32492_AddProductAfterBestDealIsExecuted.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bestdeal/I32547_CalculateBestDealI.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bestdeal/I32547_CalculateBestDealII.java
---
(0111299)
hgbot   
2019-04-25 08:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2377dc555e8af1f2434dbf153aea8df1292f0e41
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Apr 25 12:26:10 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2377dc555e8af1f2434dbf153aea8df1292f0e41 [^]

Fixed issue 40608 : Product properties should be included in the json sent to OrderLoader

* Product properties with saveToReceipt as true will be saved in receipt json which sent to OrderLoader

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/model/product.js
---
(0111362)
hgbot   
2019-04-26 14:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: faec97e58a933e317a3966ff4f4b43e2e0f51df1
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Apr 26 17:52:12 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/faec97e58a933e317a3966ff4f4b43e2e0f51df1 [^]

Related to issue 40608 : Product properties should be included in the json sent to OrderLoader

* Add saveToReceipt to Product properties (isLinkedToProduct, quantityRule) for prepayment implementation

---
M web/org.openbravo.retail.posterminal/js/model/product.js
---
(0111605)
marvintm   
2019-05-09 17:04   
We have found a problem with the current implementation, we need to remove the properties just before we prepare the ticket to be synchronised.
(0111636)
hgbot   
2019-05-13 09:07   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6dac4b22dbeca994d12d1e9c9ab9863b165a1a55
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 13 12:36:56 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6dac4b22dbeca994d12d1e9c9ab9863b165a1a55 [^]

Related to issue 40608 : Product properties should be removed only before closing the receipt

* If product properties is removed while saving, ticket will not be rendered properly while refreshing due to loss of product properties.
  So product properties should be removed only before closing the receipt

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/model/product.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0112824)
aferraz   
2019-06-17 13:49   
Product properties should be also removed when saving a deleted ticket (using Web POS Save Removed Tickets preference).
(0112833)
hgbot   
2019-06-17 15:59   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6b396ceed9388a6c3a9a5df69aaacc68c93516ad
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 17 19:28:58 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b396ceed9388a6c3a9a5df69aaacc68c93516ad [^]

Fixed issue 40608 : Product properties should be removed only before closing the receipt

* When Save Remove Ticket Pref. is enabled, product properties should be removed from deletedLines

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---