Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040603Openbravo ERPA. Platformpublic2019-04-12 09:202019-05-21 15:16
Reporteralostale 
Assigned Tojarmendariz 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2018-07-11
Regression introduced in release3.0PR18Q4
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/cf4416b527d97adba57b97484b66a33284101738 [^]
Triggers an Emergency PackNo
Summary0040603: NPE sending email if timeout not set
DescriptionIf email configuration does not define a timeout, a NPE is thrown when trying to send email.
Steps To Reproduce1. Create an Email Configuration for current Client
   -> do not set Smtp Connection Timeout field
2. Open any Sales Invoice
3. Click on the email toolbar button and click on Send after populating mandatory fields
   -> ERROR:
      * In UI "Problems while sending the email" appears
      * In openbravo.log:
2019-04-12 09:10:26,328 [http-nio-8080-exec-9] ERROR org.openbravo.erpCommon.utility.reporting.printing.PrintInvoices - error sending mail
java.lang.NullPointerException: null
    at org.openbravo.erpCommon.utility.poc.EmailManager.sendEmail(EmailManager.java:67) ~[classes/:?]
    at org.openbravo.erpCommon.utility.reporting.printing.PrintController.sendDocumentEmail(PrintController.java:821) [classes/:?]
    at org.openbravo.erpCommon.utility.reporting.printing.PrintController.post(PrintController.java:416) [classes/:?]
    at org.openbravo.erpCommon.utility.reporting.printing.PrintInvoices.doPost(PrintInvoices.java:57) [classes/:?]
        ...
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00406043.0PR19Q2 closed jarmendariz NPE sending email if timeout not set 
depends on backport 00406053.0PR19Q1.1 closed jarmendariz NPE sending email if timeout not set 
depends on backport 00406063.0PR18Q4.3 closed jarmendariz NPE sending email if timeout not set 
caused by design defect 0038524 closed jarmendariz can't configure timeout for sending emails 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-12 09:20alostaleNew Issue
2019-04-12 09:20alostaleAssigned To => jarmendariz
2019-04-12 09:20alostaleOBNetwork customer => No
2019-04-12 09:20alostaleModules => Core
2019-04-12 09:20alostaleRegression level => Production - Confirmed Stable
2019-04-12 09:20alostaleRegression date => 2018-07-11
2019-04-12 09:20alostaleRegression introduced in release => 3.0PR18Q4
2019-04-12 09:20alostaleTriggers an Emergency Pack => No
2019-04-12 09:20alostaleRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/cf4416b527d97adba57b97484b66a33284101738 [^]
2019-04-12 09:20alostaleRelationship addedcaused by 0038524
2019-04-12 09:21alostaleStatusnew => scheduled
2019-04-15 09:58hgbotCheckin
2019-04-15 09:58hgbotNote Added: 0111121
2019-04-15 09:58hgbotStatusscheduled => resolved
2019-04-15 09:58hgbotResolutionopen => fixed
2019-04-15 09:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2ccef54104f1f263a8d5e4847935b6a3339d3cb1 [^]
2019-04-15 12:09jarmendarizReview Assigned To => alostale
2019-04-16 08:38alostaleNote Added: 0111160
2019-04-16 08:38alostaleStatusresolved => closed
2019-04-16 08:38alostaleFixed in Version => 3.0PR19Q3
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0111976

Notes
(0111121)
hgbot   
2019-04-15 09:58   
Repository: erp/devel/pi
Changeset: 2ccef54104f1f263a8d5e4847935b6a3339d3cb1
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Apr 12 14:54:40 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2ccef54104f1f263a8d5e4847935b6a3339d3cb1 [^]

Fixed issue 40603: NPE if email timeout is not set

Adding another null check to verify not only in the case that the email config
does not exist, but also that the timeout value is empty. In both cases the
default timeout should be used.

---
M src/org/openbravo/erpCommon/utility/poc/EmailManager.java
---
(0111160)
alostale   
2019-04-16 08:38   
reviewed + tested
(0111976)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test