Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040599Openbravo ERP09. Financial managementpublic2019-04-11 15:132019-05-21 15:16
Reportershuehner 
Assigned ToTriage Omni OMS 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040599: Stop using Vector<Object> where not useful as its bad coding style
DescriptionBoth:
- PaymentReportDao
- CashflowForecastReportActionHandler

use Vector<Object> with no good reason as they only put single type inside ever.

Apart of being bad-coding practice making code harder to read fixing it also works around bug in external code-checking tool.
https://github.com/typetools/checker-framework/issues/2422 [^]

Note for the fix: In PaymentReportDao the objectNames=="" was simplified instead of just fixing the type confusion.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 40599.diff (2,036) 2019-04-11 15:14
https://issues.openbravo.com/file_download.php?file_id=12856&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-04-11 15:13shuehnerNew Issue
2019-04-11 15:13shuehnerAssigned To => Triage Finance
2019-04-11 15:13shuehnerModules => Core
2019-04-11 15:13shuehnerTriggers an Emergency Pack => No
2019-04-11 15:14shuehnerFile Added: 40599.diff
2019-04-11 15:14shuehnerNote Added: 0111085
2019-04-16 15:28hgbotCheckin
2019-04-16 15:28hgbotNote Added: 0111167
2019-04-16 15:28hgbotStatusnew => resolved
2019-04-16 15:28hgbotResolutionopen => fixed
2019-04-16 15:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8babe1f19082d00c4ca22a97dc226271cf2b7286 [^]
2019-04-16 15:29SandrahuguetReview Assigned To => Sandrahuguet
2019-04-16 15:29SandrahuguetNote Added: 0111168
2019-04-16 15:29SandrahuguetStatusresolved => closed
2019-04-16 15:29SandrahuguetFixed in Version => 3.0PR19Q3
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0111977

Notes
(0111085)
shuehner   
2019-04-11 15:14   
Note: Patch is only compile tested so far
(0111167)
hgbot   
2019-04-16 15:28   
Repository: erp/devel/pi
Changeset: 8babe1f19082d00c4ca22a97dc226271cf2b7286
Author: Stefan Huehner <stefan.huehner <at> openbravo.com>
Date: Tue Apr 16 09:38:15 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8babe1f19082d00c4ca22a97dc226271cf2b7286 [^]

Fixed issue 40599 Stop using Vector<Object> where not useful as its bad coding style

---
M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java
M src/org/openbravo/common/actionhandler/CashflowForecastReportActionHandler.java
---
(0111168)
Sandrahuguet   
2019-04-16 15:29   
Code review + testing OK
(0111977)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test