Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040598Openbravo ERPA. Platformpublic2019-04-11 15:082019-05-21 15:16
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040598: Stop using Vector<Object> when only single type AttachContent is used
DescriptionPrintController has some bad coding style using Vector<Object> even when only single type AttachContent is ever put into.

Apart of making the code harder to understand it also requires adding extra casts on ever read.

Note:
That code has more style problems which are not addressed here to keep change simple.

Removal of Vector<Object> is done to work around bug in external code-analysis tool:
https://github.com/typetools/checker-framework/issues/2422 [^]
Steps To Reproduce-
Proposed SolutionChange all Vector<Object> -> Vector<AttachContent>
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 40598.diff (4,360) 2019-04-11 15:09
https://issues.openbravo.com/file_download.php?file_id=12855&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-04-11 15:08shuehnerNew Issue
2019-04-11 15:08shuehnerAssigned To => platform
2019-04-11 15:08shuehnerModules => Core
2019-04-11 15:08shuehnerTriggers an Emergency Pack => No
2019-04-11 15:09shuehnerFile Added: 40598.diff
2019-04-11 15:10shuehnerNote Added: 0111084
2019-04-12 08:45hgbotCheckin
2019-04-12 08:45hgbotNote Added: 0111098
2019-04-12 08:45hgbotStatusnew => resolved
2019-04-12 08:45hgbotResolutionopen => fixed
2019-04-12 08:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/435585a9485d060e7a95f6c4219d44a60077625c [^]
2019-04-12 08:45hgbotCheckin
2019-04-12 08:45hgbotNote Added: 0111099
2019-04-12 08:47alostaleAssigned Toplatform => shuehner
2019-04-12 08:47alostaleReview Assigned To => alostale
2019-04-12 08:47alostaleNote Added: 0111100
2019-04-12 08:47alostaleStatusresolved => closed
2019-04-12 08:47alostaleFixed in Version => 3.0PR19Q3
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0111972

Notes
(0111084)
shuehner   
2019-04-11 15:10   
Patch is only compile-tested so far.
(0111098)
hgbot   
2019-04-12 08:45   
Repository: erp/devel/pi
Changeset: 435585a9485d060e7a95f6c4219d44a60077625c
Author: Stefan Hühner <stefan.huehner <at> openbravo.com
Date: Fri Apr 12 08:02:03 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/435585a9485d060e7a95f6c4219d44a60077625c [^]

fixes 40598: do not use generics with Object, use instead knwon type

---
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
(0111099)
hgbot   
2019-04-12 08:45   
Repository: erp/devel/pi
Changeset: 44c6e6baec01a4c6cb262e8285a1345f90cb3354
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Apr 12 08:45:20 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/44c6e6baec01a4c6cb262e8285a1345f90cb3354 [^]

related to issue 40598: do not use Vector at all, use ArrayList instead

---
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
(0111100)
alostale   
2019-04-12 08:47   
reviewed + tested
(0111972)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test