Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040588Retail ModulesStoreServerpublic2019-04-10 17:362019-06-25 16:14
Reportershuehner 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q3Fixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040588: MobileServerRequestExecutor.executeRequest is not using bind-parameters
DescriptionThis code is not using bind-params:

      // Find a server which can execute the service
      OBQuery<MobileServerDefinition> servers = OBDal.getInstance()
          .createQuery(MobileServerDefinition.class,
              "(" + MobileServerDefinition.PROPERTY_ALLORGS + "=true or :org in elements("
                  + MobileServerDefinition.PROPERTY_OBMOBCSERVERORGSLIST
                  + ")) and client.id=:clientId and " + MobileServerDefinition.PROPERTY_ACTIVE
                  + "=true and " + MobileServerDefinition.PROPERTY_MOBILESERVERKEY + "!='"
                  + MobileServerController.getInstance().getMobileServerKey() + "' order by "
                  + MobileServerDefinition.PROPERTY_PRIORITY);
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041177 closed jarmendariz Retail Modules Api Change: Removed unused method MobileServerRequestExecutor.executeRequest 
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Filespatch issue 40588 source mobilecore.patch (2,875) 2019-05-16 09:05
https://issues.openbravo.com/file_download.php?file_id=12957&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-04-10 17:36shuehnerNew Issue
2019-04-10 17:36shuehnerAssigned To => StoreServer
2019-04-10 17:36shuehnerOBNetwork customer => No
2019-04-10 17:36shuehnerTriggers an Emergency Pack => No
2019-04-10 17:36shuehnerRelationship addedblocks 0038136
2019-05-13 12:45shuehnerTarget Version => RR19Q3
2019-05-15 07:42ranjith_qualiantech_comAssigned ToStoreServer => ranjith_qualiantech_com
2019-05-15 07:42ranjith_qualiantech_comStatusnew => scheduled
2019-05-15 13:29marvintmAssigned Toranjith_qualiantech_com => AugustoMauch
2019-05-16 09:05ranjith_qualiantech_comFile Added: issue 40588 source mobilecore.patch
2019-06-21 13:06jarmendarizAssigned ToAugustoMauch => jarmendariz
2019-06-21 13:22jarmendarizNote Added: 0112942
2019-06-21 13:22jarmendarizStatusscheduled => resolved
2019-06-21 13:22jarmendarizResolutionopen => fixed
2019-06-21 13:23jarmendarizReview Assigned To => AugustoMauch
2019-06-25 12:41hgbotCheckin
2019-06-25 12:41hgbotNote Added: 0113004
2019-06-25 16:14AugustoMauchNote Added: 0113011
2019-06-25 16:14AugustoMauchStatusresolved => closed
2019-06-26 14:00jarmendarizRelationship addedrelated to 0041177

Notes
(0112942)
jarmendariz   
2019-06-21 13:22   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 254b693f17e39f4c9be29a2af989bff0f7c5304f
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Jun 21 13:17:31 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/254b693f17e39f4c9be29a2af989bff0f7c5304f [^] [^]

Fixed issue 40581: Query in MobileServerRequestExecutor not using bind-params

Refactored MobileServerRequestExecutor query to use bind parameters instead
of appending them to the query string directly.

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java
---
(0113004)
hgbot   
2019-06-25 12:41   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 17803494b8cf1ff7a43d98648ca0ff58245d8896
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Tue Jun 25 11:26:42 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/17803494b8cf1ff7a43d98648ca0ff58245d8896 [^]

Related to issue 40588: Removing unused method

Removed executeRequest() as its not used anywhere.

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java
---
(0113011)
AugustoMauch   
2019-06-25 16:14   
Code reviewed and verified