Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040585Retail ModulesWeb POSpublic2019-04-10 12:562019-05-24 12:54
Reportershuehner 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q3Fixed in VersionRR19Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040585: SerializedByTermImportEntryProcessorRunnable.countEntries is not using bind-parameters
DescriptionThis code is not using bind-params:

    final String whereClause = ImportEntry.PROPERTY_IMPORTSTATUS + "='" + importStatus + "' and "
        + ImportEntry.PROPERTY_CREATIONDATE + "<=:creationDate and "
        + ImportEntry.PROPERTY_CREATEDTIMESTAMP + "<:createdtimestamp and "
        + ImportEntry.PROPERTY_OBPOSPOSTERMINAL + "=:terminal and id!=:id";
    final Query<Object> qry = OBDal.getInstance()
        .getSession()
        .createQuery("select 1 from " + ImportEntry.ENTITY_NAME + " where " + whereClause,
            Object.class);
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-10 12:56shuehnerNew Issue
2019-04-10 12:56shuehnerAssigned To => Retail
2019-04-10 12:56shuehnerOBNetwork customer => No
2019-04-10 12:56shuehnerTriggers an Emergency Pack => No
2019-04-10 12:56shuehnerRelationship addedblocks 0038136
2019-05-13 12:44shuehnerTarget Version => RR19Q3
2019-05-15 07:42ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-05-15 07:42ranjith_qualiantech_comStatusnew => scheduled
2019-05-16 10:04hgbotCheckin
2019-05-16 10:04hgbotNote Added: 0111710
2019-05-16 10:04hgbotStatusscheduled => resolved
2019-05-16 10:04hgbotResolutionopen => fixed
2019-05-16 10:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/883614a9abf7462e56bf9fbe3028898a118d6e83 [^]
2019-05-24 12:54marvintmReview Assigned To => marvintm
2019-05-24 12:54marvintmStatusresolved => closed
2019-05-24 12:54marvintmFixed in Version => RR19Q3

Notes
(0111710)
hgbot   
2019-05-16 10:04   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 883614a9abf7462e56bf9fbe3028898a118d6e83
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu May 16 13:33:10 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/883614a9abf7462e56bf9fbe3028898a118d6e83 [^]

Fixed issue 40585 : SerializedByTermImportEntryProcessorRunnable.countEntries is not using bind-parameters

---
M src/org/openbravo/retail/posterminal/process/SerializedByTermImportEntryProcessorRunnable.java
---