Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040584Retail ModulesWeb POSpublic2019-04-10 12:532019-04-30 11:55
Reportershuehner 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040584: CashUpReport.doPost is not using bind-parameters
DescriptionThis code is not using bind-params:

      final String hqlCashup = "SELECT netsales, grosssales, netreturns, grossreturns, totalretailtransactions " //
          + " FROM OBPOS_App_Cashup " //
          + " WHERE id = '" + cashupId + "' "; //
      final Query<Object[]> cashupQuery = OBDal.getReadOnlyInstance()
          .getSession()
          .createQuery(hqlCashup, Object[].class);

and

      final String hqlTaxes = String.format("SELECT name, STR(ABS(amount)) " //
          + " FROM OBPOS_Taxcashup " //
          + " WHERE obpos_app_cashup_id='%s' AND ordertype='0' " //
          + " ORDER BY name ", cashupId);
      final Query<Object[]> salesTaxesQuery = OBDal.getReadOnlyInstance()
          .getSession()
          .createQuery(hqlTaxes, Object[].class);

and

      final String hqlReturnTaxes = String.format("SELECT name, STR(ABS(amount)) " //
          + " FROM OBPOS_Taxcashup " //
          + " WHERE obpos_app_cashup_id='%s' AND ordertype='1' " //
          + " ORDER BY name ", cashupId);
      final Query<Object[]> returnsTaxesQuery = OBDal.getReadOnlyInstance()
          .getSession()
          .createQuery(hqlReturnTaxes, Object[].class);
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0040716RR19Q2 closed ranjith_qualiantech_com Retail Modules CashUpReport.doPost is not using bind-parameters 
depends on backport 0040717RR19Q1.1 closed ranjith_qualiantech_com Retail Modules CashUpReport.doPost is not using bind-parameters 
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-10 12:53shuehnerNew Issue
2019-04-10 12:53shuehnerAssigned To => Retail
2019-04-10 12:53shuehnerOBNetwork customer => No
2019-04-10 12:53shuehnerTriggers an Emergency Pack => No
2019-04-10 12:53shuehnerRelationship addedblocks 0038136
2019-04-11 11:53ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-04-12 07:24ranjith_qualiantech_comStatusnew => scheduled
2019-04-12 07:45ranjith_qualiantech_comNote Added: 0111090
2019-04-12 07:45ranjith_qualiantech_comStatusscheduled => resolved
2019-04-12 07:45ranjith_qualiantech_comResolutionopen => fixed
2019-04-24 12:46adrianromeroReview Assigned To => adrianromero
2019-04-24 12:46adrianromeroNote Added: 0111270
2019-04-24 12:46adrianromeroStatusresolved => closed
2019-04-24 12:46adrianromeroFixed in Version => RR19Q3
2019-04-30 11:55shuehnerNote Added: 0111385
2019-04-30 11:55shuehnerStatusclosed => new
2019-04-30 11:55shuehnerResolutionfixed => open
2019-04-30 11:55shuehnerFixed in VersionRR19Q3 =>
2019-04-30 11:55shuehnerStatusnew => scheduled
2019-04-30 11:55shuehnerStatusscheduled => resolved
2019-04-30 11:55shuehnerResolutionopen => fixed
2019-04-30 11:55shuehnerStatusresolved => closed

Notes
(0111090)
ranjith_qualiantech_com   
2019-04-12 07:45   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c82334b59fdf53cb9b49284e8ff3a939c5c46d03
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Apr 12 11:13:56 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c82334b59fdf53cb9b49284e8ff3a939c5c46d03 [^] [^]

Fixed issue 40584 : Update CashupReport query to use query parameter

---
M src/org/openbravo/retail/posterminal/ad_reports/CashUpReport.java
(0111270)
adrianromero   
2019-04-24 12:46   
Verified.
(0111385)
shuehner   
2019-04-30 11:55   
Reopening just to schedule backports