Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040583Retail ModulesWeb POSpublic2019-04-10 12:472019-04-30 11:54
Reportershuehner 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040583: POSUtils.getPriceListVersionForPriceList is not using bind-parameters
DescriptionThis code is not using bind-params:

      Query<PriceListVersion> priceListVersionQuery = OBDal.getInstance()
          .getSession()
          .createQuery("from PricingPriceListVersion AS plv " + "where plv.priceList.id ='"
              + priceListId
              + "' and plv.active=true and plv.validFromDate = (select max(pplv.validFromDate) "
              + "from PricingPriceListVersion as pplv where pplv.active=true and pplv.priceList.id = '"
              + priceListId + "' and to_char(pplv.validFromDate,'yyyy-mm-dd') <= '"
              + format.format(terminalDate) + "' )", PriceListVersion.class);
      for (PriceListVersion plv : priceListVersionQuery.list()) {
        return plv;
      }
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0040714RR19Q2 closed ranjith_qualiantech_com Retail Modules POSUtils.getPriceListVersionForPriceList is not using bind-parameters 
depends on backport 0040715RR19Q1.1 closed ranjith_qualiantech_com Retail Modules POSUtils.getPriceListVersionForPriceList is not using bind-parameters 
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-10 12:47shuehnerNew Issue
2019-04-10 12:47shuehnerAssigned To => Retail
2019-04-10 12:47shuehnerTriggers an Emergency Pack => No
2019-04-10 12:47shuehnerRelationship addedblocks 0038136
2019-04-11 11:53ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-04-12 07:24ranjith_qualiantech_comStatusnew => scheduled
2019-04-12 07:43hgbotCheckin
2019-04-12 07:43hgbotNote Added: 0111088
2019-04-12 07:43hgbotStatusscheduled => resolved
2019-04-12 07:43hgbotResolutionopen => fixed
2019-04-12 07:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b23ba3569b57850fa59c9bd8bfdfabb56c30e06c [^]
2019-04-12 07:44hgbotCheckin
2019-04-12 07:44hgbotNote Added: 0111089
2019-04-12 07:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b23ba3569b57850fa59c9bd8bfdfabb56c30e06c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c82334b59fdf53cb9b49284e8ff3a939c5c46d03 [^]
2019-04-12 07:45ranjith_qualiantech_comNote Deleted: 0111089
2019-04-24 12:44adrianromeroReview Assigned To => adrianromero
2019-04-24 12:44adrianromeroNote Added: 0111268
2019-04-24 12:44adrianromeroStatusresolved => closed
2019-04-24 12:44adrianromeroFixed in Version => RR19Q3
2019-04-30 11:53shuehnerNote Added: 0111384
2019-04-30 11:53shuehnerStatusclosed => new
2019-04-30 11:53shuehnerResolutionfixed => open
2019-04-30 11:53shuehnerFixed in VersionRR19Q3 =>
2019-04-30 11:53shuehnerStatusnew => scheduled
2019-04-30 11:54shuehnerStatusscheduled => resolved
2019-04-30 11:54shuehnerFixed in Version => RR19Q3
2019-04-30 11:54shuehnerResolutionopen => fixed
2019-04-30 11:54shuehnerStatusresolved => closed

Notes
(0111088)
hgbot   
2019-04-12 07:43   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b23ba3569b57850fa59c9bd8bfdfabb56c30e06c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Apr 12 11:13:28 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b23ba3569b57850fa59c9bd8bfdfabb56c30e06c [^]

Fixed issue 40583 : Update POSUtils query to use query parameter

---
M src/org/openbravo/retail/posterminal/POSUtils.java
---
(0111268)
adrianromero   
2019-04-24 12:44   
Verified.
(0111384)
shuehner   
2019-04-30 11:53   
Reopening just to schedule backports