Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0040579Openbravo ERP09. Financial managementpublic2019-04-10 12:352019-05-21 15:17
shuehner 
Triage Finance 
normalminorhave not tried
closedfixed 
5
 
3.0PR19Q3 
Sandrahuguet
Core
No
0040579: ResetAccounting.hasProcessing is not using bind-parameters
This code is not using bind-params:

    String hql = " select count(*) from ADColumn where table.id = '" + strTableId + "' "
        + " and lower(dBColumnName) = 'processing'";
    Query<Long> query = OBDal.getInstance().getSession().createQuery(hql, Long.class);
-
No tags attached.
depends on backport 00407753.0PR19Q2 closed nonofrancisco ResetAccounting.hasProcessing is not using bind-parameters 
depends on backport 00407763.0PR19Q1.2 closed Triage Finance ResetAccounting.hasProcessing is not using bind-parameters 
depends on backport 00407773.0PR18Q4.4 closed Triage Finance ResetAccounting.hasProcessing is not using bind-parameters 
blocks design defect 0038136 acknowledged platform Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Issue History
2019-04-10 12:35shuehnerNew Issue
2019-04-10 12:35shuehnerAssigned To => Triage Finance
2019-04-10 12:35shuehnerModules => Core
2019-04-10 12:35shuehnerTriggers an Emergency Pack => No
2019-04-10 12:36shuehnerRelationship addedblocks 0038136
2019-04-23 22:12nonofranciscoStatusnew => scheduled
2019-05-04 17:16nonofranciscoStatusscheduled => acknowledged
2019-05-04 17:17nonofranciscoStatusacknowledged => scheduled
2019-05-04 17:27nonofranciscoNote Added: 0111484
2019-05-08 11:14hgbotCheckin
2019-05-08 11:14hgbotNote Added: 0111562
2019-05-08 11:14hgbotStatusscheduled => resolved
2019-05-08 11:14hgbotResolutionopen => fixed
2019-05-08 11:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e98fa7d50bdbacb0ce7adc52d97b4f4e56fd1e93 [^]
2019-05-08 11:35SandrahuguetReview Assigned To => Sandrahuguet
2019-05-08 11:35SandrahuguetNote Added: 0111565
2019-05-08 11:35SandrahuguetStatusresolved => closed
2019-05-08 11:35SandrahuguetFixed in Version => 3.0PR19Q3
2019-05-21 15:17hudsonbotCheckin
2019-05-21 15:17hudsonbotNote Added: 0112018

Notes
(0111484)
nonofrancisco   
2019-05-04 17:27   
Test Plan

Logged as F&B International Group Admin
Open Sales Invoice window
Create a new Sales invoice with a line of product
Complete the document
Post the document
Unpost the document deleting accounting entries
Verify the process completes successfully
(0111562)
hgbot   
2019-05-08 11:14   
Repository: erp/devel/pi
Changeset: e98fa7d50bdbacb0ce7adc52d97b4f4e56fd1e93
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Apr 22 16:23:50 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/e98fa7d50bdbacb0ce7adc52d97b4f4e56fd1e93 [^]

Fixes issue 40579: Uses bind parameters in query

Instead of using string concatenation in query, bind parameters are used.

---
M src/org/openbravo/financial/ResetAccounting.java
---
(0111565)
Sandrahuguet   
2019-05-08 11:35   
code review + testing OK
(0112018)
hudsonbot   
2019-05-21 15:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test