Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040568Retail ModulesWeb POSpublic2019-04-10 11:132019-05-24 12:50
Reportershuehner 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q3Fixed in VersionRR19Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040568: RolePermissions.getPrefList is not using bind-parameters
DescriptionThis code is not using bind-params:

    String whereClause = "where reference.id = :refId and module.id in "
        + LabelsComponent.getMobileAppDependantModuleIds(moduleId);

Note: Value list comes from public utility method which needs changing. All 2 others in-tree users of this methods are also wrong (see related issue about LabelsComponent.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040569RR19Q3 closed ranjith_qualiantech_com Retail Modules LabelsComponent.(getLabels+getLists) are not using bind-parameters 
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-10 11:13shuehnerNew Issue
2019-04-10 11:13shuehnerAssigned To => Retail
2019-04-10 11:13shuehnerTriggers an Emergency Pack => No
2019-04-10 11:13shuehnerRelationship addedblocks 0038136
2019-04-10 11:17shuehnerRelationship addedrelated to 0040569
2019-05-13 12:43shuehnerTarget Version => RR19Q3
2019-05-13 13:56ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-05-14 11:06ranjith_qualiantech_comStatusnew => scheduled
2019-05-16 10:02hgbotCheckin
2019-05-16 10:02hgbotNote Added: 0111705
2019-05-16 10:02hgbotStatusscheduled => resolved
2019-05-16 10:02hgbotResolutionopen => fixed
2019-05-16 10:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6a88184a88027bb956e792943d3489d4427c1e4d [^]
2019-05-24 12:50marvintmReview Assigned To => marvintm
2019-05-24 12:50marvintmStatusresolved => closed
2019-05-24 12:50marvintmFixed in Version => RR19Q3

Notes
(0111705)
hgbot   
2019-05-16 10:02   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 6a88184a88027bb956e792943d3489d4427c1e4d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu May 16 13:32:04 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6a88184a88027bb956e792943d3489d4427c1e4d [^]

Fixed issue 40568 : RolePermissions.getPrefList is not using bind-parameters

---
M src/org/openbravo/mobile/core/login/RolePermissions.java
---