Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040565Openbravo ERPA. Platformpublic2019-04-09 21:082019-05-21 15:16
Reportershuehner 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040565: SelectorFieldPropertyCallout.execute is not using bind-variables
DescriptionThis code is not using bind-params:

      final Table propertyTable = OBDal.getInstance()
          .createQuery(Table.class, Table.PROPERTY_ID + "='" + tableId + "'")
          .list()
          .get(0);
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-09 21:08shuehnerNew Issue
2019-04-09 21:08shuehnerAssigned To => platform
2019-04-09 21:08shuehnerModules => Core
2019-04-09 21:08shuehnerTriggers an Emergency Pack => No
2019-04-09 21:08shuehnerRelationship addedblocks 0038136
2019-04-11 08:41alostaleAssigned Toplatform => alostale
2019-04-11 08:42alostaleReview Assigned To => caristu
2019-04-11 08:44hgbotCheckin
2019-04-11 08:44hgbotNote Added: 0111075
2019-04-11 08:44hgbotStatusnew => resolved
2019-04-11 08:44hgbotResolutionopen => fixed
2019-04-11 08:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b45635db7349ae3bc4c0bca78aea97915336df56 [^]
2019-04-12 08:21caristuNote Added: 0111093
2019-04-12 08:21caristuStatusresolved => closed
2019-04-12 08:21caristuFixed in Version => 3.0PR19Q3
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0111969

Notes
(0111075)
hgbot   
2019-04-11 08:44   
Repository: erp/devel/pi
Changeset: b45635db7349ae3bc4c0bca78aea97915336df56
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 11 08:40:44 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b45635db7349ae3bc4c0bca78aea97915336df56 [^]

fixed issue 40565: SelectorFieldPropertyCallout.execute is not using bind-variables

  No need to query for table by id, getting a proxy is enough.

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorFieldPropertyCallout.java
---
(0111093)
caristu   
2019-04-12 08:21   
Reviewed
(0111969)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test