Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040564Openbravo ERPA. Platformpublic2019-04-09 21:042019-05-21 15:16
Reportershuehner 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040564: MyOpenbravoActionHandler.processWidgets is not using bind-variables
DescriptionThis code is not using bind-params:

          // Remove all instances of the widget instance that is to be removed
          OBQuery<WidgetInstance> widgetInstanceQuery = OBDal.getInstance()
              .createQuery(WidgetInstance.class, "copiedFrom='" + widgetInstance.getId() + "'");
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-09 21:04shuehnerNew Issue
2019-04-09 21:04shuehnerAssigned To => platform
2019-04-09 21:04shuehnerModules => Core
2019-04-09 21:04shuehnerTriggers an Emergency Pack => No
2019-04-09 21:05shuehnerRelationship addedblocks 0038136
2019-04-11 08:41alostaleAssigned Toplatform => alostale
2019-04-11 08:42alostaleReview Assigned To => caristu
2019-04-11 08:44hgbotCheckin
2019-04-11 08:44hgbotNote Added: 0111074
2019-04-11 08:44hgbotStatusnew => resolved
2019-04-11 08:44hgbotResolutionopen => fixed
2019-04-11 08:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/eed3ff80f38875b145f257910800d4c0142bc9f2 [^]
2019-04-12 08:25caristuNote Added: 0111094
2019-04-12 08:25caristuStatusresolved => closed
2019-04-12 08:25caristuFixed in Version => 3.0PR19Q3
2019-04-12 09:56hgbotCheckin
2019-04-12 09:56hgbotNote Added: 0111107
2019-04-12 10:12hgbotCheckin
2019-04-12 10:12hgbotNote Added: 0111108
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0111968
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0111974
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0111975

Notes
(0111074)
hgbot   
2019-04-11 08:44   
Repository: erp/devel/pi
Changeset: eed3ff80f38875b145f257910800d4c0142bc9f2
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 11 08:34:29 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/eed3ff80f38875b145f257910800d4c0142bc9f2 [^]

fixed issue 40564: MyOpenbravoActionHandler.processWidgets is not using bind-variables

---
M modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOpenbravoActionHandler.java
---
(0111094)
caristu   
2019-04-12 08:25   
Reviewed
(0111107)
hgbot   
2019-04-12 09:56   
Repository: erp/devel/pi
Changeset: c40147ef32b332931a9578919d2b930162ab4228
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Apr 12 09:55:18 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c40147ef32b332931a9578919d2b930162ab4228 [^]

related to issue 40564: fixed types in query

---
M modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOpenbravoActionHandler.java
---
(0111108)
hgbot   
2019-04-12 10:12   
Repository: erp/devel/pi
Changeset: f3ff80a1ad208a3b6b79efd515d69f67d4552c45
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Apr 12 10:11:29 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f3ff80a1ad208a3b6b79efd515d69f67d4552c45 [^]

related to issue 40564: minor code improvements

  - Use isEmpty() to check whether the collection is empty or not
  - Use diamond operator
  - Removed useless assignment for "alertListToRemove"
  - Immediately return the result instead of assigning it to the temporary "total" variable

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/AlertActionHandler.java
---
(0111968)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test
(0111974)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test
(0111975)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test