Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040563Openbravo ERP09. Financial managementpublic2019-04-09 21:022019-05-20 09:42
ReporterAtulOpenbravo 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040563: API Change:Remove process Match Statement & Match Statement Force, Model Object & its Mapping, Messages, Text Interfaces
DescriptionRemove process Match Statement & Match Statement Force, Model Object & its Mapping, Messages, Text Interfaces.

The processes are inactive and not used any more. Removing MatchTransaction.html, MatchTransaction.java, MatchTransaction.xml, MatchTransactionGrid.srpt, MatchTransactionGrid.xml and related to processes Match Statement & Match Statement Force has low risk as sample data references in AD_Process_Access could be managed.

AD_Process_Access has references to the AccountsTransactions with id 19EEA22FCA464979B3ADAD3A967ADA52 & C125EA7C85234D8B89FEA511FCCD2E9E in Sample Data for F&B International Group, QA Testing in Core, The White Valley Group in Retail Sample Data module, AWO QA in AWO Sample Data Module, v3 Dataset module.

Removing below methods that were only used in MatchTransaction.java also has low risk as they are not used in the any other classes.
- MatchTransactionDao.addNewReconciliation
- MatchTransactionDao.getMatchingBankStatementLines
Steps To Reproduce-
Proposed Solution
Additional Information
TagsApproved
Relationships
blocks feature request 00357883.0PR19Q3 closed AtulOpenbravo Remove obsolete, disabled & non-working class: org.openbravo.advpaymentmngt.ad_forms.Transactions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-09 21:02AtulOpenbravoNew Issue
2019-04-09 21:02AtulOpenbravoAssigned To => Triage Finance
2019-04-09 21:02AtulOpenbravoModules => Core
2019-04-09 21:02AtulOpenbravoTriggers an Emergency Pack => No
2019-04-09 21:02AtulOpenbravoIssue generated from0040561
2019-04-09 21:02AtulOpenbravoRelationship addedblocks 0035788
2019-04-09 21:09AtulOpenbravoDescription Updatedbug_revision_view_page.php?rev_id=18610#r18610
2019-04-09 21:10AtulOpenbravoDescription Updatedbug_revision_view_page.php?rev_id=18611#r18611
2019-04-25 17:01AtulOpenbravoAssigned ToTriage Finance => dmitry_mezentsev
2019-04-25 17:03AtulOpenbravoDescription Updatedbug_revision_view_page.php?rev_id=18677#r18677
2019-04-25 19:50AtulOpenbravoIssue cloned0040688
2019-04-29 13:57dmitry_mezentsevTag Attached: Approved
2019-04-29 13:58dmitry_mezentsevAssigned Todmitry_mezentsev => AtulOpenbravo
2019-05-16 20:41hgbotCheckin
2019-05-16 20:41hgbotNote Added: 0111736
2019-05-16 20:41hgbotCheckin
2019-05-16 20:41hgbotNote Added: 0111740
2019-05-20 09:41vmromanosStatusnew => scheduled
2019-05-20 09:42vmromanosStatusscheduled => resolved
2019-05-20 09:42vmromanosFixed in Version => 3.0PR19Q3
2019-05-20 09:42vmromanosFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/08b774b8d4c948f7448a9c9c5a711c556e1f1494 [^]
2019-05-20 09:42vmromanosResolutionopen => fixed
2019-05-20 09:42vmromanosReview Assigned To => vmromanos
2019-05-20 09:42vmromanosNote Added: 0111784
2019-05-20 09:42vmromanosStatusresolved => closed

Notes
(0111736)
hgbot   
2019-05-16 20:41   
Repository: erp/devel/api-checks
Changeset: 08b774b8d4c948f7448a9c9c5a711c556e1f1494
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri May 03 15:03:58 2019 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/08b774b8d4c948f7448a9c9c5a711c556e1f1494 [^]

Fixes Issue 40561, Issue 40563, Issue 40688:Api Change

** Remove form AccountTransaction
** Remove Transaction Old tab and its field in financial
account window.
** Remove process Match Statement & Match Statement Force
** Remove process AddOrderOrInvoice, AddPaymentFromTransaction,
AddPaymentFromInvoice, AddTransaction, SelectExpectedPayments
** Remove model object & its mapping for above form/process
** Remove EM_APRM_ADDTRANSACTION column from Financial Account,
related field, element.
** Remove related ad_message in above form/process.
** Remove related ad_textinterfaces in above form/process.
** Remove fin_recline_temp table, its ad elements, ad_message,
ad_references, selector, selector field, validation rule

---
M model/modules/org.openbravo.advpaymentmngt/src-db/database/model/modifiedTables/FIN_FINANCIAL_ACCOUNT.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FORM.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_PROCESS.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REFERENCE.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REF_LIST.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TAB.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_VAL_RULE.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
M model/modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_DATASET_TABLE.xml
M model/src-db/database/sourcedata/AD_ELEMENT.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
M model/src-db/database/sourcedata/AD_MESSAGE.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M model/src-db/database/sourcedata/AD_PROCESS.xml
M model/src-db/database/sourcedata/AD_TABLE.xml
M model/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
R model/src-db/database/model/tables/FIN_RECLINE_TEMP.xml
---
(0111740)
hgbot   
2019-05-16 20:41   
Repository: erp/devel/api-checks
Changeset: 0c161656288bbd6bf12b48f13327bf4126c8e376
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri May 17 00:08:58 2019 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/0c161656288bbd6bf12b48f13327bf4126c8e376 [^]

Related To Issue 40561, Issue 40563, Issue 40688:Api Change

** Remove unused classes AddOrderOrInvoice, AddPaymentFromInvoice,
AddPaymentFromTransaction, AddTransaction, MatchTransaction,
SelectExpectedPayments, Transactions, CreateFile,
FIN_ReconciliationLineTemp
** Remove unused methods getTrxGridRows, getTrxGridRowCount,
getPaymentsNotDeposited, getPaymentProposalDetailAmount,
getNewFinancialTransaction, getFilteredScheduledPaymentDetails,
getCustomerPaymentsWithCredit, getAlternativePaymentsNotDeposited,
getCustomerCredit from class AdvPaymentMngtDao.
** Remove unused methods getReconciliationEndingBalance,
getMatchedBankStatementLines, addNewReconciliation from class
MatchTransactionDao.
** Remove unused methods process, getPendingToMatchCount from class
TransactionsDao.
** Remove unused methods isForcedFinancialAccountTransaction,
getShownScheduledPaymentDetails, getSelectedPendingPaymentsFromProposal,
getSelectedPaymentDetailsAndAmount, getGLItemScheduleDetails
from class FIN_AddPayment.
** Remove unused method prepareRelationTemplateNoSearch
from class ToolBar
** Remove unused methods displayAcctDimensions from
class DimensionDisplayUtility

---
M java/reference/java.japi.gz
---
(0111784)
vmromanos   
2019-05-20 09:42   
CI passed successfully