Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040559Openbravo ERP07. Sales managementpublic2019-04-09 20:292019-05-21 15:17
Reportershuehner 
Assigned Tononofrancisco 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040559: SL_TaxCategory_Org.execute is not using bind-parameters
DescriptionThis method is not using bind-parameters in lines 49 + 58

      whereClause = "as tn where tn.node = '" + organization.getId() + "' and tn.client.id = '"
          + organization.getClient().getId() + "'";

        OBQuery<TreeNode> query = OBDal.getInstance().createQuery(TreeNode.class, whereClause);
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00407723.0PR19Q2 closed nonofrancisco SL_TaxCategory_Org.execute is not using bind-parameters 
depends on backport 00407733.0PR19Q1.2 closed nonofrancisco SL_TaxCategory_Org.execute is not using bind-parameters 
depends on backport 00407743.0PR18Q4.4 closed nonofrancisco SL_TaxCategory_Org.execute is not using bind-parameters 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-09 20:29shuehnerNew Issue
2019-04-09 20:29shuehnerAssigned To => Triage Finance
2019-04-09 20:29shuehnerModules => Core
2019-04-09 20:29shuehnerTriggers an Emergency Pack => No
2019-04-09 20:30shuehnerRelationship addedblocks 0038136
2019-04-23 22:11nonofranciscoStatusnew => scheduled
2019-05-03 11:53SandrahuguetAssigned ToTriage Finance => nonofrancisco
2019-05-04 16:54nonofranciscoStatusscheduled => acknowledged
2019-05-04 16:55nonofranciscoStatusacknowledged => scheduled
2019-05-04 16:55nonofranciscoNote Added: 0111483
2019-05-04 17:27nonofranciscoNote Edited: 0111483bug_revision_view_page.php?bugnote_id=0111483#r18706
2019-05-08 12:25hgbotCheckin
2019-05-08 12:25hgbotNote Added: 0111566
2019-05-08 12:25hgbotStatusscheduled => resolved
2019-05-08 12:25hgbotResolutionopen => fixed
2019-05-08 12:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2eab22ee5862c243704b87445079ea184bd43341 [^]
2019-05-08 12:47SandrahuguetReview Assigned To => Sandrahuguet
2019-05-08 12:47SandrahuguetNote Added: 0111573
2019-05-08 12:47SandrahuguetStatusresolved => closed
2019-05-08 12:47SandrahuguetFixed in Version => 3.0PR19Q3
2019-05-21 15:17hudsonbotCheckin
2019-05-21 15:17hudsonbotNote Added: 0112019

Notes
(0111483)
nonofrancisco   
2019-05-04 16:55   
(edited on: 2019-05-04 17:27)
Test Plan

Logged as F&B International Group Admin
Open Tax Category window
Create a new record
  Organization: *
  Default: true
Open Product window
Create a new record
Select organization F&B International Group
Verify Tax category selected is the previously created
(0111566)
hgbot   
2019-05-08 12:25   
Repository: erp/devel/pi
Changeset: 2eab22ee5862c243704b87445079ea184bd43341
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Apr 22 15:04:05 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/2eab22ee5862c243704b87445079ea184bd43341 [^]

Fixes issue 40559: Uses bind parameters in query

Instead of using string concatenation in client and organization filters in
where clause, bind parameters are used

---
M src/org/openbravo/erpCommon/ad_callouts/SL_TaxCategory_Org.java
---
(0111573)
Sandrahuguet   
2019-05-08 12:47   
code review + testing ok
(0112019)
hudsonbot   
2019-05-21 15:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test