Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040545Openbravo ERP09. Financial managementpublic2019-04-05 15:052019-07-17 10:09
Reporterngarcia 
Assigned Tononofrancisco 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket9201
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040545: Wrong payment schedule details when paying an invoice with more than one order if Invoice Transaction Type is selected
DescriptionWrong payment schedule details when paying an invoice with more than one order if Invoice Transaction Type is selected instead of 'Orders and Invoices'
Steps To ReproduceAs group admin role:
   Create 5 sales orders for the same business partner, price not including taxes and 21% of tax Set it's invoice terms as immediate:
      1) 1 unit with a net unit price of 21.95 (total of 26.56)
      2) 3 units with a net unit price of 25 (total of 90.75)
      3) -12 units with a net unit price of 12 (total of -174.24)
      4) 15 units with a net unit price of 0.86 (total of 15.61)
      5) 20 units with a net unit price of 0.35
         1 unit with a net unit price of 25
         1 unit with a net unit price of 13.20
         (total of 54.69)

   Add all of them in the same invoice. Total amount (13.37). Complete it
   Create a new sales invoice and add all the previous lines but with the opposite quantities
   Add a payment of 0 to it
   Check the transaction type is set to Invoices
   Select the two invoices created, set the total amount to pay and process

   Create a new Payment in for the same business partner
   Add details and check the invoice is still pending to be paid
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-05 15:05ngarciaNew Issue
2019-04-05 15:05ngarciaAssigned To => Triage Finance
2019-04-05 15:05ngarciaOBNetwork customer => OBPS
2019-04-05 15:05ngarciaModules => Core
2019-04-05 15:05ngarciaSupport ticket => 9201
2019-04-05 15:05ngarciaResolution time => 1556229600
2019-04-05 15:05ngarciaTriggers an Emergency Pack => No
2019-04-05 15:08SandrahuguetAssigned ToTriage Finance => nonofrancisco
2019-04-05 15:13PracticsIssue Monitored: Practics
2019-04-08 10:07ngarciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18604#r18604
2019-04-08 15:12SandrahuguetRegression level => Production - Confirmed Stable
2019-04-08 15:12SandrahuguetRegression introduced in release => 3.0PR18Q2
2019-04-15 12:35SandrahuguetRegression levelProduction - Confirmed Stable =>
2019-04-15 12:35SandrahuguetRegression introduced in release3.0PR18Q2 =>
2019-04-17 13:04ngarciaPriorityimmediate => urgent
2019-04-26 08:23SandrahuguetNote Added: 0111336
2019-04-26 08:27SandrahuguetStatusnew => scheduled
2019-04-29 12:59hgbotCheckin
2019-04-29 12:59hgbotNote Added: 0111367
2019-04-29 12:59hgbotStatusscheduled => resolved
2019-04-29 12:59hgbotResolutionopen => fixed
2019-04-29 12:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/49fefc70a4c7bc4e5620b9dcdc93f2b1c6dc8454 [^]
2019-04-29 13:07SandrahuguetReview Assigned To => Sandrahuguet
2019-04-29 13:08SandrahuguetNote Added: 0111368
2019-04-29 13:08SandrahuguetStatusresolved => closed
2019-04-29 13:08SandrahuguetFixed in Version => 3.0PR19Q3
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0112003
2019-07-17 10:09hgbotCheckin
2019-07-17 10:09hgbotNote Added: 0113466

Notes
(0111336)
Sandrahuguet   
2019-04-26 08:23   
Test Plan:

    As group admin role:
   Create 5 sales orders for the same business partner, price not including taxes and 21% of tax Set it's invoice terms as immediate:
      1) 1 unit with a net unit price of 21.95 (total of 26.56)
      2) 3 units with a net unit price of 25 (total of 90.75)
      3) -12 units with a net unit price of 12 (total of -174.24)
      4) 15 units with a net unit price of 0.86 (total of 15.61)
      5) 20 units with a net unit price of 0.35
         1 unit with a net unit price of 25
         1 unit with a net unit price of 13.20
         (total of 54.69)

   Add all of them in the same invoice. Total amount (13.37). Complete it
   Create a new sales invoice and add all the previous lines but with the opposite quantities
   Add a payment of 0 to it
   Check the transaction type is set to Invoices
   Select the two invoices created, set the total amount to pay and process

   Create a new Payment in for the same business partner
   Add details and check no invoice is pending to be paid
(0111367)
hgbot   
2019-04-29 12:59   
Repository: erp/devel/pi
Changeset: 49fefc70a4c7bc4e5620b9dcdc93f2b1c6dc8454
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Apr 25 11:44:14 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/49fefc70a4c7bc4e5620b9dcdc93f2b1c6dc8454 [^]

Fixes issue 40545: Update payment schedule detail with line amount

When paying completely an Invoice with negative lines, some lines could remain
with zero payment schedule details after payment is processed.
In this fix, the payment schedule detail for each line is updated with the
line amount.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
---
(0111368)
Sandrahuguet   
2019-04-29 13:07   
code review + testing ok
(0112003)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test
(0113466)
hgbot   
2019-07-17 10:09   
Repository: tools/automation/int
Changeset: cf690458e8b9fcd3f38eeef38b1fa5ea4c1b6902
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Jul 02 13:19:40 2019 -0400
URL: http://code.openbravo.com/tools/automation/int/rev/cf690458e8b9fcd3f38eeef38b1fa5ea4c1b6902 [^]

Added some automated test for issue 40545

---
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_AddPaymentRefactor/APR_AddPaymentRefactor3/AddPaymentSuite3.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_AddPaymentRefactor/APR_AddPaymentRefactor3/APRSales015.java
---