Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040535Openbravo ERPA. Platformpublic2019-04-05 10:112020-01-24 09:17
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040535: old callouts should use OBScriptEngine to evaluate response
DescriptionOld callouts implemented as Servlets instead of SimpleCallout evaluate response as Javascript using rhino instead of using OBScriptEngine which selects the engine provided by jdk.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0036067 closed markmm82 Openbravo ERP old callouts should be refactored to implement SimpleCallout 
related to defect 0042919 closed alostale Modules Export Analytics reports on PDF doesn't work 
depends on defect 0040548 closed alostale Openbravo ERP API change removed constructor in HttpServletCalloutInformationProvider 
related to defect 0040629 closed alostale Openbravo ERP jdk11+: removal warning in HttpServletCalloutInformationProvider 
blocks feature request 0039983 closed jarmendariz Openbravo ERP Upgrade javascript linter and formatter 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-05 10:11alostaleNew Issue
2019-04-05 10:11alostaleAssigned To => platform
2019-04-05 10:11alostaleModules => Core
2019-04-05 10:11alostaleTriggers an Emergency Pack => No
2019-04-05 10:14alostaleRelationship addedblocks 0039983
2019-04-05 10:14alostaleRelationship addedrelated to 0036067
2019-04-08 10:58alostaleAssigned Toplatform => alostale
2019-04-08 11:01alostaleRelationship addeddepends on 0040548
2019-04-08 11:04hgbotCheckin
2019-04-08 11:04hgbotNote Added: 0111009
2019-04-08 11:04hgbotStatusnew => resolved
2019-04-08 11:04hgbotResolutionopen => fixed
2019-04-08 11:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4802bbc887308a0dab5f45beec7095768eeb907b [^]
2019-04-08 11:04alostaleReview Assigned To => caristu
2019-04-08 11:04hgbotCheckin
2019-04-08 11:04hgbotNote Added: 0111010
2019-04-08 11:04hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/4802bbc887308a0dab5f45beec7095768eeb907b [^] => http://code.openbravo.com/erp/devel/api-checks/rev/9f7b34759d69874321dd0b0bdbfbde40a5a7b4a2 [^]
2019-04-12 09:15hgbotCheckin
2019-04-12 09:15hgbotNote Added: 0111101
2019-04-12 09:16caristuNote Added: 0111102
2019-04-12 09:16caristuStatusresolved => closed
2019-04-12 09:16caristuFixed in Version => 3.0PR19Q3
2019-04-17 09:47alostaleRelationship addedrelated to 0040629
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0111973
2020-01-24 09:17alostaleRelationship addedrelated to 0042919

Notes
(0111009)
hgbot   
2019-04-08 11:04   
Repository: erp/devel/pi
Changeset: 4802bbc887308a0dab5f45beec7095768eeb907b
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Apr 05 13:40:57 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4802bbc887308a0dab5f45beec7095768eeb907b [^]

fixes 40535: old callouts should use OBScriptEngine to evaluate response

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
M src-test/src/org/openbravo/test/AllAntTaskTests.java
M src/org/openbravo/erpCommon/ad_callouts/HttpServletCalloutInformationProvider.java
A src-test/src/org/openbravo/test/system/OldCallouts.java
---
(0111010)
hgbot   
2019-04-08 11:04   
Repository: erp/devel/api-checks
Changeset: 9f7b34759d69874321dd0b0bdbfbde40a5a7b4a2
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Apr 08 11:03:16 2019 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/9f7b34759d69874321dd0b0bdbfbde40a5a7b4a2 [^]

fixes 40535: old callouts should use OBScriptEngine to evaluate response

---
M java/reference/java.japi.gz
---
(0111101)
hgbot   
2019-04-12 09:15   
Repository: erp/devel/pi
Changeset: ec0386dd0e01c6989d0e849a79837d343a874f30
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Apr 12 09:15:25 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ec0386dd0e01c6989d0e849a79837d343a874f30 [^]

related to issue 40535: minor code improvements

  - Reorder modifiers of log attribute
  - Use diamond operator

---
M src/org/openbravo/erpCommon/ad_callouts/HttpServletCalloutInformationProvider.java
---
(0111102)
caristu   
2019-04-12 09:16   
Reviewed
(0111973)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test