Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040522Openbravo ERP09. Financial managementpublic2019-04-04 13:272019-05-21 15:16
Reporteralostale 
Assigned Tononofrancisco 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040522: use bind-parameters in FIN_BankStatementImport
DescriptionFIN_BankStatementImport.matchBusinessPartnerByNameTokens method is generating a sql setting parameters by String concatenation, replace tokens by bind parameters.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00406813.0PR19Q2 closed nonofrancisco use bind-parameters in FIN_BankStatementImport 
depends on backport 00406823.0PR19Q1.1 closed nonofrancisco use bind-parameters in FIN_BankStatementImport 
depends on backport 00406833.0PR18Q4.4 closed nonofrancisco use bind-parameters in FIN_BankStatementImport 
related to defect 0040628 closed nonofrancisco Match the business partner by tokens does not work in an import bank statement process 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-04 13:27alostaleNew Issue
2019-04-04 13:27alostaleAssigned To => Triage Finance
2019-04-04 13:27alostaleModules => Core
2019-04-04 13:27alostaleTriggers an Emergency Pack => No
2019-04-04 13:27alostaleRelationship addedblocks 0038136
2019-04-04 13:38alostaleRelationship addeddepends on 0040523
2019-04-05 10:09vmromanosStatusnew => scheduled
2019-04-05 10:09vmromanosAssigned ToTriage Finance => nonofrancisco
2019-04-05 10:19vmromanosNote Added: 0110994
2019-04-05 10:19vmromanosNote Edited: 0110994bug_revision_view_page.php?bugnote_id=0110994#r18595
2019-04-09 20:57shuehnerRelationship deleteddepends on 0040523
2019-04-25 12:25SandrahuguetRelationship addedrelated to 0040628
2019-04-25 13:18hgbotCheckin
2019-04-25 13:18hgbotNote Added: 0111314
2019-04-25 13:18hgbotStatusscheduled => resolved
2019-04-25 13:18hgbotResolutionopen => fixed
2019-04-25 13:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a5d02171e10c523cfac9da2c54e6fb29ee292514 [^]
2019-04-25 13:18hgbotCheckin
2019-04-25 13:18hgbotNote Added: 0111315
2019-04-25 13:19SandrahuguetStatusresolved => new
2019-04-25 13:19SandrahuguetResolutionfixed => open
2019-04-25 13:20SandrahuguetStatusnew => scheduled
2019-04-25 13:20SandrahuguetStatusscheduled => resolved
2019-04-25 13:20SandrahuguetResolutionopen => fixed
2019-04-25 16:58hgbotCheckin
2019-04-25 16:58hgbotNote Added: 0111327
2019-04-25 16:58hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/a5d02171e10c523cfac9da2c54e6fb29ee292514 [^] => http://code.openbravo.com/erp/backports/3.0PR18Q4.4/rev/cad0e7a1e66397273227a5757b4c854c7f4f1a56 [^]
2019-04-25 16:58hgbotCheckin
2019-04-25 16:58hgbotNote Added: 0111328
2019-04-25 17:00SandrahuguetNote Deleted: 0111327
2019-04-25 17:00SandrahuguetNote Deleted: 0111328
2019-04-25 17:01SandrahuguetReview Assigned To => Sandrahuguet
2019-04-25 17:01SandrahuguetNote Added: 0111332
2019-04-25 17:01SandrahuguetStatusresolved => closed
2019-04-25 17:01SandrahuguetFixed in Version => 3.0PR19Q3
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0111997
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0111998

Notes
(0110994)
vmromanos   
2019-04-05 10:19   
Backport to previous releases
(0111314)
hgbot   
2019-04-25 13:18   
Repository: erp/devel/pi
Changeset: a5d02171e10c523cfac9da2c54e6fb29ee292514
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Apr 25 12:39:23 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a5d02171e10c523cfac9da2c54e6fb29ee292514 [^]

Fixes issue 40522: Prevents use of string concatenation in query

Query to get business partners was formed using string concatenation.
This fix replaces the string concatenation by bind parameters in query.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---
(0111315)
hgbot   
2019-04-25 13:18   
Repository: erp/devel/pi
Changeset: cfc6ddc67eb0b04be2737bdc22cce8c9b314d4c6
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Apr 25 13:12:34 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cfc6ddc67eb0b04be2737bdc22cce8c9b314d4c6 [^]

related to issue 40522 code review changes

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---
(0111332)
Sandrahuguet   
2019-04-25 17:01   
Code review + testing OK
(0111997)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test
(0111998)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test