Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040521ModulesExternal Integration Infrastructurepublic2019-04-04 13:242019-04-05 15:06
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToAugustoMauch
Support ticket
OBNetwork customer
Regression introduced in release
Summary0040521: ConditionalPropertyMapping and AfterFlushHook instances are not being injected
DescriptionAfter the Weld upgrade (0040193), ConditionalPropertyMapping and AfterFlushHook instances are not being injected.

Seems that the behavior when injecting classes that implement generic interfaces has been redefined. See[1].

[1] https://docs.jboss.org/cdi/spec/2.0-PFD/cdi-spec.html#assignable_parameters [^]
Steps To Reproduce1) Install the https://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration.examples [^] test module
2) Execute the ExportPropertyMappingTest.testUnsatisfiedConditionalMapping test. Note that the test fails because the related expected ConditionalPropertyMapping instance is not executed.

Note that also test of CountryImportWithExtensionsTest class are failing for the same reason.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0040193 closed caristu Openbravo ERP upgrade Weld to version 3.1.0.Final 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-04 13:24caristuNew Issue
2019-04-04 13:24caristuAssigned To => platform
2019-04-04 13:24caristuRelationship addedrelated to 0040193
2019-04-04 13:24caristuDescription Updatedbug_revision_view_page.php?rev_id=18579#r18579
2019-04-04 13:25caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18581#r18581
2019-04-04 13:27caristuSummaryConditionalPropertyMapping instances are not being injected => ConditionalPropertyMapping and AfterFlushHook instances are not being injected
2019-04-04 13:27caristuDescription Updatedbug_revision_view_page.php?rev_id=18582#r18582
2019-04-04 13:29caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18583#r18583
2019-04-04 13:32hgbotCheckin
2019-04-04 13:32hgbotNote Added: 0110982
2019-04-04 13:32hgbotStatusnew => resolved
2019-04-04 13:33hgbotResolutionopen => fixed
2019-04-04 13:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration/rev/a66bee8a48068e8a0b9a497fbf18d2e8f3677d22 [^]
2019-04-04 13:33caristuAssigned Toplatform => caristu
2019-04-04 13:33caristuRelationship deletedrelated to 0040193
2019-04-04 13:33caristuRelationship addedcaused by 0040193
2019-04-04 13:34caristuReview Assigned To => AugustoMauch
2019-04-05 15:06AugustoMauchNote Added: 0111007
2019-04-05 15:06AugustoMauchStatusresolved => closed

Notes
(0110982)
hgbot   
2019-04-04 13:32   
Repository: erp/pmods/org.openbravo.service.external.integration
Changeset: a66bee8a48068e8a0b9a497fbf18d2e8f3677d22
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Apr 04 13:30:38 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration/rev/a66bee8a48068e8a0b9a497fbf18d2e8f3677d22 [^]

fixes bug 40521: ConditionalPropertyMapping and AfterFlushHook are not injected

  The behavior when injecting classes that implement generic interfaces is different in CDI 2.0. (See[1]). For this reason we need to use wildcards for defining the injection points for such classes.

---
M src/org/openbravo/service/external/integration/importer/SynchronizableBusinessObjectImporter.java
M src/org/openbravo/service/external/integration/mapping/PropertyMapper.java
---
(0111007)
AugustoMauch   
2019-04-05 15:06   
Code reviewed and verified