Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040516Openbravo ERP04. Warehouse managementpublic2019-04-04 09:512019-05-21 15:16
Reportergorkaion 
Assigned Tononofrancisco 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket9099
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040516: Cannot process a Landed Cost if the role does not have access to its Legal Entity
DescriptionCannot process a Landed Cost if the role does not have access to the Legal Entity.
Steps To ReproduceCreate a role that ONLY has access to F&B España - Región Norte organization.

With that role:
   Create a Goods Receipt for two days before today.
   Add a product and complete it

   Launch Costing Background Process and check its cost is calculated

   Create a Landed Cost Type
   Create a Landed Cost
   Set a Cost to it
   Select the previously created receipt
   Try to complete it and check the following error message is shown:

Organization <> of object (CostAdjustment(<>) (documentNo: <>, referenceData: <>)) is not present in OrganizationList [<>]
   
Proposed SolutionOn LandedCostProcess.java

Change the setAdminMode to setAdminMode(false) so no org access check is executed.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038867 closed AtulOpenbravo Cannot process a Landed Cost if the role does not have access to the organization of a transaction that needs to be adjusted 
related to defect 0040517 closed nonofrancisco In Landed Cost it is possible to see receipts of parent org when role does not have access to it 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-04 09:51gorkaionNew Issue
2019-04-04 09:51gorkaionAssigned To => AtulOpenbravo
2019-04-04 09:51gorkaionOBNetwork customer => OBPS
2019-04-04 09:51gorkaionModules => Core
2019-04-04 09:51gorkaionSupport ticket => 9099
2019-04-04 09:51gorkaionResolution time => 1556143200
2019-04-04 09:51gorkaionTriggers an Emergency Pack => No
2019-04-04 09:51gorkaionIssue generated from0038867
2019-04-04 09:51gorkaionRelationship addedrelated to 0038867
2019-04-04 10:11gorkaionIssue cloned0040517
2019-04-04 10:11gorkaionRelationship addedrelated to 0040517
2019-04-04 10:12gorkaionAssigned ToAtulOpenbravo => Triage Finance
2019-04-04 10:35SandrahuguetAssigned ToTriage Finance => nonofrancisco
2019-04-04 21:17nonofranciscoStatusnew => scheduled
2019-04-05 14:46nonofranciscoNote Added: 0111005
2019-04-08 17:39hgbotCheckin
2019-04-08 17:39hgbotNote Added: 0111028
2019-04-08 17:39hgbotStatusscheduled => resolved
2019-04-08 17:39hgbotResolutionopen => fixed
2019-04-08 17:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5abaf711e34101202c529da677505505ec8c1c08 [^]
2019-04-08 17:40SandrahuguetReview Assigned To => Sandrahuguet
2019-04-08 17:40SandrahuguetNote Added: 0111029
2019-04-08 17:40SandrahuguetStatusresolved => closed
2019-04-08 17:40SandrahuguetFixed in Version => 3.0PR19Q3
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0111963

Notes
(0111005)
nonofrancisco   
2019-04-05 14:46   
Test Plan

Create a role that ONLY has access to F&B España - Región Norte organization.
  Grant access to windows
    Process Request
    Goods Receipt
    Product
    Landed Cost Type
    Landed Cost

With that role:
   Create a Goods Receipt for two days before today.
   Add a product and complete it

   Launch Costing Background Process and check its cost is calculated

   Create a Landed Cost Type
   Create a Landed Cost
   Set a Cost to it
   Select the previously created receipt
   Process the Landed Cost it and verify the process completes successfully
(0111028)
hgbot   
2019-04-08 17:39   
Repository: erp/devel/pi
Changeset: 5abaf711e34101202c529da677505505ec8c1c08
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Apr 08 17:20:15 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5abaf711e34101202c529da677505505ec8c1c08 [^]

Fixes issue 40516: Disables organization check when processing landed cost

Disables organization access check to allow landed cost processing, when
it was created from a role not having access to then Legal Entity.

---
M src/org/openbravo/costing/CostAdjustmentProcess.java
M src/org/openbravo/costing/LandedCostProcess.java
---
(0111029)
Sandrahuguet   
2019-04-08 17:40   
Code review + testing OK
(0111963)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test