Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040494Retail ModulesCopy Retail Storepublic2019-03-29 13:332019-06-11 12:00
Reporterucarrion 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040494: Several fields not copied when using 'Copy Terminal' process
DescriptionSeveral fields not copied when using 'Copy Terminal' process

'Return No Prefix'
'Gift Certificate Sequence Prefix'
Steps To ReproduceThe prefix must be copied (change the original by the new one) in these all fields
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040740 closed ranjith_qualiantech_com Field not copied when using 'Copy Terminal' process 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-29 13:33ucarrionNew Issue
2019-03-29 13:33ucarrionAssigned To => Triage Finance
2019-03-29 13:33ucarrionModules => Core
2019-03-29 13:33ucarrionResolution time => 1556575200
2019-03-29 13:33ucarrionTriggers an Emergency Pack => No
2019-03-29 14:16SandrahuguetAssigned ToTriage Finance => markmm82
2019-03-29 14:22SandrahuguetAssigned Tomarkmm82 => Retail
2019-03-29 14:24SandrahuguetProjectOpenbravo ERP => Retail Modules
2019-03-29 14:25SandrahuguetCategory02. Master data management => Copy Retail Store
2019-03-29 16:27markmm82Statusnew => scheduled
2019-03-31 20:20markmm82Statusscheduled => feedback
2019-03-31 20:20markmm82Statusfeedback => new
2019-04-01 03:28rqueraltaAssigned ToRetail => rqueralta
2019-04-01 03:28rqueraltaStatusnew => scheduled
2019-04-22 18:16hgbotCheckin
2019-04-22 18:16hgbotNote Added: 0111219
2019-04-22 18:16hgbotStatusscheduled => resolved
2019-04-22 18:16hgbotResolutionopen => fixed
2019-04-22 18:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/b80ef3ffc14d8d7c47a713053bbdab8f7626fd75 [^]
2019-04-23 17:55adrianromeroNote Added: 0111244
2019-04-23 17:55adrianromeroStatusresolved => new
2019-04-23 17:55adrianromeroResolutionfixed => open
2019-04-23 21:53hgbotCheckin
2019-04-23 21:53hgbotNote Added: 0111249
2019-04-23 23:30rqueraltaStatusnew => scheduled
2019-04-23 23:30rqueraltaStatusscheduled => resolved
2019-04-23 23:30rqueraltaResolutionopen => fixed
2019-04-24 13:14hgbotCheckin
2019-04-24 13:14hgbotNote Added: 0111275
2019-04-24 13:15adrianromeroStatusresolved => new
2019-04-24 13:15adrianromeroResolutionfixed => open
2019-04-24 13:19adrianromeroReview Assigned To => adrianromero
2019-04-24 13:19adrianromeroNote Added: 0111276
2019-04-24 13:19adrianromeroStatusnew => closed
2019-04-24 13:19adrianromeroResolutionopen => no change required
2019-04-25 11:58ucarrionAssigned Torqueralta => adrianromero
2019-04-25 11:58ucarrionNote Added: 0111307
2019-04-25 11:58ucarrionStatusclosed => new
2019-04-25 11:58ucarrionResolutionno change required => open
2019-04-25 13:20hgbotCheckin
2019-04-25 13:20hgbotNote Added: 0111316
2019-04-25 13:21adrianromeroStatusnew => scheduled
2019-04-25 13:22adrianromeroNote Added: 0111317
2019-04-25 13:22adrianromeroStatusscheduled => resolved
2019-04-25 13:22adrianromeroFixed in Version => RR19Q3
2019-04-25 13:22adrianromeroResolutionopen => fixed
2019-04-25 13:22adrianromeroNote Added: 0111318
2019-04-25 13:22adrianromeroStatusresolved => closed
2019-05-02 09:21ucarrionNote Added: 0111420
2019-05-02 09:21ucarrionStatusclosed => new
2019-05-02 09:21ucarrionResolutionfixed => open
2019-05-02 09:21ucarrionFixed in VersionRR19Q3 =>
2019-05-02 12:08adrianromeroStatusnew => scheduled
2019-05-02 12:08adrianromeroStatusscheduled => resolved
2019-05-02 12:08adrianromeroResolutionopen => fixed
2019-05-02 12:10adrianromeroNote Added: 0111429
2019-05-02 12:10adrianromeroStatusresolved => closed
2019-05-02 12:10adrianromeroFixed in Version => RR19Q3
2019-05-02 12:10adrianromeroRelationship addedrelated to 0040740
2019-05-23 16:37barbararoncatoNote Added: 0112097
2019-05-23 16:38barbararoncatoStatusclosed => new
2019-05-23 16:38barbararoncatoResolutionfixed => open
2019-05-23 16:38barbararoncatoFixed in VersionRR19Q3 =>
2019-05-24 12:03marvintmReview Assigned Toadrianromero =>
2019-05-24 12:03marvintmResolution time1556575200 => 1559253600
2019-05-24 12:03marvintmAssigned Toadrianromero => rqueralta
2019-05-27 21:35hgbotCheckin
2019-05-27 21:35hgbotNote Added: 0112188
2019-05-27 21:35hgbotStatusnew => resolved
2019-05-27 21:35hgbotResolutionopen => fixed
2019-05-27 21:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/b80ef3ffc14d8d7c47a713053bbdab8f7626fd75 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/e2d3b1ce0a62ff651e4bebc6582e05eda55d2c1a [^]
2019-05-27 22:55hgbotCheckin
2019-05-27 22:55hgbotNote Added: 0112190
2019-05-27 22:55hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/e2d3b1ce0a62ff651e4bebc6582e05eda55d2c1a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore.giftcards/rev/91fe78eaadd9d648986b166909d5ecdc69f97782 [^]
2019-05-31 09:13marvintmReview Assigned To => marvintm
2019-05-31 09:13marvintmStatusresolved => closed
2019-05-31 09:13marvintmFixed in Version => RR19Q3
2019-05-31 19:42hgbotCheckin
2019-05-31 19:42hgbotNote Added: 0112322
2019-06-03 12:25ranjith_qualiantech_comNote Added: 0112336
2019-06-03 12:25ranjith_qualiantech_comStatusclosed => new
2019-06-03 12:25ranjith_qualiantech_comResolutionfixed => open
2019-06-03 12:25ranjith_qualiantech_comFixed in VersionRR19Q3 =>
2019-06-03 14:59hgbotCheckin
2019-06-03 14:59hgbotNote Added: 0112337
2019-06-04 08:32ranjith_qualiantech_comStatusnew => scheduled
2019-06-04 08:32ranjith_qualiantech_comStatusscheduled => resolved
2019-06-04 08:32ranjith_qualiantech_comResolutionopen => fixed
2019-06-05 10:13hgbotCheckin
2019-06-05 10:13hgbotNote Added: 0112407
2019-06-05 15:16marvintmStatusresolved => closed
2019-06-05 15:16marvintmFixed in Version => RR19Q3
2019-06-11 12:00hgbotCheckin
2019-06-11 12:00hgbotNote Added: 0112576
2019-06-11 12:00hgbotCheckin
2019-06-11 12:00hgbotNote Added: 0112577

Notes
(0111219)
hgbot   
2019-04-22 18:16   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: b80ef3ffc14d8d7c47a713053bbdab8f7626fd75
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Apr 22 12:08:43 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/b80ef3ffc14d8d7c47a713053bbdab8f7626fd75 [^]

Fixed issue 40494: Several fields not copied when using 'Copy Terminal' process

- Copied and replaced by the new value, missing fields in 'Copy Terminal' process

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0111244)
adrianromero   
2019-04-23 17:55   
The copy definition for the field 'gcnvGcseqPrefix' is already defined in another module and must not go in posterminal: https://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore.giftcards/file/tip/src/org/openbravo/retail/copystore/giftcards/DefaultGiftcardsPropertiesHandler.java [^]

If the user wants to copy this field he must install org.openbravo.retail.copystore.giftcards
(0111249)
hgbot   
2019-04-23 21:53   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 1722a6495af27ea639f1eb234c4ff1cc51b6ca3b
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Apr 23 15:28:15 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/1722a6495af27ea639f1eb234c4ff1cc51b6ca3b [^]

Related to issue 40494: Several fields not copied when using 'Copy Terminal'
process

- Removed changes in giftcard prefix

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0111275)
hgbot   
2019-04-24 13:14   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 7cbf5e54718b87ccb7a7a8abd4d31f5f54bc7b4b
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Apr 24 13:14:38 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/7cbf5e54718b87ccb7a7a8abd4d31f5f54bc7b4b [^]

Reverting all changes in issue 40494: Several fields not copied when using 'Copy Terminal' process
Issue has been rejected

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0111276)
adrianromero   
2019-04-24 13:19   
No need to do any modification of the behavior:

'Return No Prefix' No need to save any value in this field when copy a terminal. By default the prefix of a return will be the order prefix. This is the expected behaviour when copying a terminal.

'Gift Certificate Sequence Prefix'. The copy of this field is managed in the module org.openbravo.retail.copystore.giftcards that needs to be installed first to copy the field when copying a terminal.
(0111307)
ucarrion   
2019-04-25 11:58   
Hi,

if indicated in original terminal, the copied terminal should be in coherence with its new prefix (see example screenshot below).

https://drive.google.com/drive/folders/0BzzTCqxUdgWYfl84M0lJd0I4b3Z3VHEwd0JzLVJ4ckRNR3V1SDlodnRLcDF0ajNfWVIyeUk [^]
(0111316)
hgbot   
2019-04-25 13:20   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: b69fd996ad595541d0c46d55221dbbf68bb14644
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Apr 25 13:10:25 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/b69fd996ad595541d0c46d55221dbbf68bb14644 [^]

Backed out changeset 7cbf5e54718b Reverting all changes in issue 40494: Several fields not copied when using 'Copy Terminal' process

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0111317)
adrianromero   
2019-04-25 13:22   
Finally it is needed to save a new 'Return No Prefix' to not to copy the value from the previous terminal and have a new one based on the search key of the new terminal.
(0111318)
adrianromero   
2019-04-25 13:22   
Verified
(0111420)
ucarrion   
2019-05-02 09:21   
Hi,

the process is not working correctly also for 'Order Preparation No Prefix' field. See the screeshot below taken from livebuilds:

https://drive.google.com/file/d/1zeNUehBmpGAIa7cwP8F_1g8JgqSmpU5T/view?usp=sharing [^]
(0111429)
adrianromero   
2019-05-02 12:10   
A new issue has been created to make reference to a new field not properly managed in the copy terminal process -> 0040740
(0112097)
barbararoncato   
2019-05-23 16:37   
Hi, the below fields are still not created correctly:

Order Quotation No Prefix
Return No Prefix
Order Document No Prefix
Order Preparation No Prefix
Gift Certificate Sequence Prefix

Please see video from livebuilds:
https://drive.google.com/file/d/1QteoK_2j-JgJIwRYGYMGp8QDHfI605Hs/view [^]
(0112188)
hgbot   
2019-05-27 21:35   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: e2d3b1ce0a62ff651e4bebc6582e05eda55d2c1a
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon May 27 15:29:58 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/e2d3b1ce0a62ff651e4bebc6582e05eda55d2c1a [^]

Fixed issue 40494: Several fields not copied when using 'Copy Terminal' process

- Added suffix to the searchKey by Document Type

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0112190)
hgbot   
2019-05-27 22:55   
Repository: erp/pmods/org.openbravo.retail.copystore.giftcards
Changeset: 91fe78eaadd9d648986b166909d5ecdc69f97782
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon May 27 16:55:40 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore.giftcards/rev/91fe78eaadd9d648986b166909d5ecdc69f97782 [^]

Fixed issue 40494: Several fields not copied when using 'Copy Terminal' process

- Added "GC" suffix to the new searchKey

---
M src/org/openbravo/retail/copystore/giftcards/DefaultGiftcardsPropertiesHandler.java
---
(0112322)
hgbot   
2019-05-31 19:42   
Repository: erp/pmods/org.openbravo.retail.copystore.giftcards
Changeset: 09ca466136e82b17c6a36a43b4ed592e571e9c5d
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Fri May 31 13:41:01 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore.giftcards/rev/09ca466136e82b17c6a36a43b4ed592e571e9c5d [^]

Related issue 40494: Several fields not copied when using 'Copy Terminal' process

- Restored qualifier values

---
M src/org/openbravo/retail/copystore/giftcards/DefaultGiftcardsPropertiesHandler.java
---
(0112336)
ranjith_qualiantech_com   
2019-06-03 12:25   
While copying Terminal, if prefixNo(return, quotation, orderpreparation) is empty, then new terminal prefixno should be empty else prefixNo should be updated with new terminal searchKey
(0112337)
hgbot   
2019-06-03 14:59   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 612ffc8d2a31a165dba9ed999ba03dac17ccded4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 03 18:28:54 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/612ffc8d2a31a165dba9ed999ba03dac17ccded4 [^]

Related to issue 40494 : Prefix No should be copied if the value is empty in Old terminal

* While copying terminal, if prefixNo is empty in old Terminal then same should be copied to new terminal
  instead of updating with new terminal searchKey

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0112407)
hgbot   
2019-06-05 10:13   
Repository: erp/pmods/org.openbravo.retail.copystore.giftcards
Changeset: f432a22a77fb1fdab0c4a9cfbd01c4c7f82c6077
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jun 05 13:43:16 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore.giftcards/rev/f432a22a77fb1fdab0c4a9cfbd01c4c7f82c6077 [^]

Related to issue 40494 : Prefix No should be set as empty if the value is empty in Old terminal

* While copying terminal, if prefixNo is empty in old Terminal then same should be copied to new terminal
instead of updating with new terminal searchKey

---
M src/org/openbravo/retail/copystore/giftcards/DefaultGiftcardsPropertiesHandler.java
---
(0112576)
hgbot   
2019-06-11 12:00   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 4f9efb601cd79b38da8de65123bd5f13c6a93b16
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jun 11 15:30:27 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/4f9efb601cd79b38da8de65123bd5f13c6a93b16 [^]

Related to issue 40494 : Updates Standard Package Import for StringUtils

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0112577)
hgbot   
2019-06-11 12:00   
Repository: erp/pmods/org.openbravo.retail.copystore.giftcards
Changeset: d7bbec3b0170e7d950480cba625c762e6c8f5efd
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jun 11 15:30:29 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore.giftcards/rev/d7bbec3b0170e7d950480cba625c762e6c8f5efd [^]

Related to issue 40494 : Updates Standard Package Import for StringUtils

---
M src/org/openbravo/retail/copystore/giftcards/DefaultGiftcardsPropertiesHandler.java
---