Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040477Retail ModulesWeb POSpublic2019-03-28 13:392019-05-06 11:35
Reportersamuel_nicuesa 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040477: Cancel Button removes tickets doing the cash up from the previous day.
DescriptionCancel Button removes tickets doing the cash up from the previous day.
Steps To Reproduce[POS]

User 1

Create 1 ticket and add payment

Don't pay it

Click on Lock screen

User 2

Create 1 ticket and add payment

Don't pay it

Click on lock screen

Don't do cash up

[BO]

Execute close store

Execute open store setting a new Business Date

[POS]

Login using User 1

Cash up needs to be done

Click on Bring all button

Click on delete all button and the tickets won't be deleted because there are payments associated

Click on Cancel Button and OBPOS_preRemovePayment is being executed.

I think that it is not correct.

If you press Cancel Button you should have all pending tickets with payment in this Terminal.

 
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040326 closed ranjith_qualiantech_com Doing cash up Delete all button is not working properly. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-28 13:39samuel_nicuesaNew Issue
2019-03-28 13:39samuel_nicuesaAssigned To => Retail
2019-03-28 13:39samuel_nicuesaResolution time => 1555538400
2019-03-28 13:39samuel_nicuesaTriggers an Emergency Pack => No
2019-03-28 14:21rafarodaRelationship addedrelated to 0040326
2019-03-28 14:26ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-03-28 15:21rqueraltaAssigned Toranjith_qualiantech_com => rqueralta
2019-04-26 21:33hgbotCheckin
2019-04-26 21:33hgbotNote Added: 0111364
2019-04-26 21:33hgbotStatusnew => resolved
2019-04-26 21:33hgbotResolutionopen => fixed
2019-04-26 21:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/faf0314ec02f4a619765fe27e3f22a6695c118e7 [^]
2019-04-29 13:14marvintmNote Added: 0111369
2019-04-29 13:14marvintmStatusresolved => new
2019-04-29 13:14marvintmResolutionfixed => open
2019-04-29 20:16hgbotCheckin
2019-04-29 20:16hgbotNote Added: 0111374
2019-04-29 20:17hgbotStatusnew => resolved
2019-04-29 20:17hgbotResolutionopen => fixed
2019-04-29 20:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/faf0314ec02f4a619765fe27e3f22a6695c118e7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/491e047df8d99a18f5868d1565d85549aac28f95 [^]
2019-04-29 20:17hgbotCheckin
2019-04-29 20:17hgbotNote Added: 0111375
2019-04-29 20:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/491e047df8d99a18f5868d1565d85549aac28f95 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/c188e7072d9a3b4078383d3141de8b743a34c504 [^]
2019-05-06 11:35guilleaerReview Assigned To => guilleaer
2019-05-06 11:35guilleaerStatusresolved => closed
2019-05-06 11:35guilleaerFixed in Version => RR19Q3

Notes
(0111364)
hgbot   
2019-04-26 21:33   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: faf0314ec02f4a619765fe27e3f22a6695c118e7
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sun Mar 31 18:55:39 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/faf0314ec02f4a619765fe27e3f22a6695c118e7 [^]

Fixed issue 40477: Cancel Button removes tickets doing the cash up from the
previous day.

- Avoided remove all pending tickets with payment when "Cancel" button is clicked
on Cash Up popup.

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0111369)
marvintm   
2019-04-29 13:14   
This commit is adding a dependency from posterminal to sessions module as it is checking several properties belonging to the sessions module (the ones which start with "poss_").

Moreover, it is also unclear why these need to be checked. In fact, ideally a simpler solution would just be to force a "lock" instead of a "logout" when the cancel button is pressed. This way no tickets would be deleted, which is most likely the preferred route in this scenario.
(0111374)
hgbot   
2019-04-29 20:16   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 491e047df8d99a18f5868d1565d85549aac28f95
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Apr 29 13:01:29 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/491e047df8d99a18f5868d1565d85549aac28f95 [^]

Fixed issue 40477: Cancel Button removes tickets doing the cash up from the
previous day.

- Pending to be paid orders will be removed on logout just if it do not have
payments related, in other case terminal will be lock.

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0111375)
hgbot   
2019-04-29 20:17   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: c188e7072d9a3b4078383d3141de8b743a34c504
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Apr 29 13:00:46 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/c188e7072d9a3b4078383d3141de8b743a34c504 [^]

Fixed issue 40477: Cancel Button removes tickets doing the cash up from the
previous day.

- Pending to be paid orders will be removed on logout just if it do not have
payments related, in other case terminal will be lock.

---
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---