Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040472Openbravo ERPB. User interfacepublic2019-03-28 10:292019-05-21 15:17
Reporterdbaz 
Assigned ToAugustoMauch 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q3Fixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerGold
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040472: [UX] Inconsistent behavior of the dropdown list in the combo boxes of the filtering row in grid
DescriptionIn the backoffice grid, in the filter row, if there is a field pointing to a foreign key, once it is opened a dropdown list with the options is shown with a checkbox at the beginning of each row.

The problem is that this dropdown list only reacts if there is a click in the checkbox. If a click is done in any part of the row at the right of the checkbox (the label or the empty space in its right side), nothing happens.

Steps To ReproduceLogin
Open "Sales Order" window in grid view
Open the "Business Partner" combo box in the filter row.
Note that the dropdown list only reacts to clicks on the checkbox at the beginning of each row.
Proposed SolutionThe behavior should be exactly the same than the grid rows/records so:
* Click in the checkbox, it select the row and the dropdown list remains open in case the user needs to select more items (the same than the current behavior)
* Click in any other part of the row, it deletes any previous selection (uncheck all the selected rows, if exist), select the pressed row (and just the pressed row) and closes automatically the combo box.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-28 10:29dbazNew Issue
2019-03-28 10:29dbazAssigned To => platform
2019-03-28 10:29dbazOBNetwork customer => No
2019-03-28 10:29dbazModules => Core
2019-03-28 10:29dbazTriggers an Emergency Pack => No
2019-03-28 10:47azabaletaIssue Monitored: azabaleta
2019-03-29 07:41alostaleStatusnew => acknowledged
2019-03-29 07:42alostaleOBNetwork customerNo => Gold
2019-03-29 07:42alostaleTarget Version => 3.0PR19Q3
2019-04-11 12:47jarmendarizAssigned Toplatform => jarmendariz
2019-04-16 13:55alostaleDescription Updatedbug_revision_view_page.php?rev_id=18637#r18637
2019-04-16 13:55alostaleProposed Solution updated
2019-04-23 14:35AugustoMauchAssigned Tojarmendariz => AugustoMauch
2019-04-23 15:13AugustoMauchStatusacknowledged => scheduled
2019-04-24 11:02hgbotCheckin
2019-04-24 11:02hgbotNote Added: 0111259
2019-04-24 11:02hgbotStatusscheduled => resolved
2019-04-24 11:02hgbotResolutionopen => fixed
2019-04-24 11:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b71414db01be193dfd553abb2defa8869b92a8a7 [^]
2019-04-24 11:02AugustoMauchReview Assigned To => caristu
2019-05-06 09:28caristuNote Added: 0111488
2019-05-06 09:28caristuStatusresolved => new
2019-05-06 09:28caristuResolutionfixed => open
2019-05-07 09:48hgbotCheckin
2019-05-07 09:48hgbotNote Added: 0111525
2019-05-07 09:48hgbotStatusnew => resolved
2019-05-07 09:48hgbotResolutionopen => fixed
2019-05-07 09:48hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/b71414db01be193dfd553abb2defa8869b92a8a7 [^] => http://code.openbravo.com/erp/devel/pi/rev/15cdfeb7c6ac5e127a95e1ce9451bc6a723a4f43 [^]
2019-05-10 15:20caristuNote Added: 0111625
2019-05-10 15:20caristuStatusresolved => closed
2019-05-10 15:20caristuFixed in Version => 3.0PR19Q3
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0111993
2019-05-21 15:17hudsonbotCheckin
2019-05-21 15:17hudsonbotNote Added: 0112013

Notes
(0111259)
hgbot   
2019-04-24 11:02   
Repository: erp/devel/pi
Changeset: b71414db01be193dfd553abb2defa8869b92a8a7
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Apr 23 14:43:15 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b71414db01be193dfd553abb2defa8869b92a8a7 [^]

Fixes issue 40472: Clicking on text of combo filter selects the clicked row

Before this change, when a row was clicked on a combo filter outside its checkbox, nothing happened.

Now, to make it consistent with the grid's behaviour, clicking on the text of a filter combo item will
result in that particular row being selected.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
---
(0111488)
caristu   
2019-05-06 09:28   
Reopened: fix needs to take into account if the grid is configured with "lazy filtering"
(0111525)
hgbot   
2019-05-07 09:48   
Repository: erp/devel/pi
Changeset: 15cdfeb7c6ac5e127a95e1ce9451bc6a723a4f43
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue May 07 09:47:49 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/15cdfeb7c6ac5e127a95e1ce9451bc6a723a4f43 [^]

Fixes issue 40472: New filtering logic takes into account lazy filtering

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
---
(0111625)
caristu   
2019-05-10 15:20   
Code reviewed + tested OK.
(0111993)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test
(0112013)
hudsonbot   
2019-05-21 15:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test