Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040460Retail ModulesDiscounts by Totalpublic2019-03-26 15:472019-04-24 12:01
Reporterguillermogil 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040460: Discounts by Total are not applied properly based on priority
DescriptionDiscounts by Total are not applied properly based on priority. It seems to be taking into account the line price instead of the total price of the ticket.
Steps To Reproduce- Configure discount as image Image1.png
- Configure discount as image Image2.png
- Login on WebPOS
- Add product Basecamp Lantern with legs
  - Discount "by total 1" is applied correctly
- Add Avalanche Transceiver
  - Discount "by total 2" should be applied but it is only shows on the 2nd line - check Image3.png

If you modify the prices (Image4.png & Image5.png) the discount changes
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040620 closed jorge-garcia The priority of promotions is not managed properly 
Attached Filespng Image1.png (100,129) 2019-03-26 15:47
https://issues.openbravo.com/file_download.php?file_id=12788&type=bug
png

png Image2.png (98,023) 2019-03-26 15:47
https://issues.openbravo.com/file_download.php?file_id=12789&type=bug
png

png Image3.png (366,724) 2019-03-26 15:48
https://issues.openbravo.com/file_download.php?file_id=12790&type=bug
png Image4.png (161,576) 2019-03-26 15:48
https://issues.openbravo.com/file_download.php?file_id=12791&type=bug
png

png Image5.png (161,960) 2019-03-26 15:48
https://issues.openbravo.com/file_download.php?file_id=12792&type=bug
png

diff I40460_possibleFix.diff (2,955) 2019-03-27 12:22
https://issues.openbravo.com/file_download.php?file_id=12797&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-03-26 15:47guillermogilNew Issue
2019-03-26 15:47guillermogilAssigned To => Retail
2019-03-26 15:47guillermogilFile Added: Image1.png
2019-03-26 15:47guillermogilOBNetwork customer => Gold
2019-03-26 15:47guillermogilResolution time => 1555365600
2019-03-26 15:47guillermogilTriggers an Emergency Pack => No
2019-03-26 15:47guillermogilFile Added: Image2.png
2019-03-26 15:48guillermogilFile Added: Image3.png
2019-03-26 15:48guillermogilFile Added: Image4.png
2019-03-26 15:48guillermogilFile Added: Image5.png
2019-03-26 15:49guillermogilDescription Updatedbug_revision_view_page.php?rev_id=18542#r18542
2019-03-26 15:51guillermogilIssue Monitored: umartirena
2019-03-26 17:19jorge-garciaStatusnew => scheduled
2019-03-26 17:19jorge-garciaAssigned ToRetail => jorge-garcia
2019-03-27 12:22jorge-garciaFile Added: I40460_possibleFix.diff
2019-04-09 13:11jorge-garciaAssigned Tojorge-garcia => Retail
2019-04-10 14:12ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-04-11 09:23hgbotCheckin
2019-04-11 09:23hgbotNote Added: 0111076
2019-04-12 07:40hgbotCheckin
2019-04-12 07:40hgbotNote Added: 0111086
2019-04-12 07:40ranjith_qualiantech_comStatusscheduled => resolved
2019-04-12 07:40ranjith_qualiantech_comResolutionopen => fixed
2019-04-16 09:14ranjith_qualiantech_comRelationship addedrelated to 0040620
2019-04-23 10:04hgbotCheckin
2019-04-23 10:04hgbotNote Added: 0111223
2019-04-24 12:01adrianromeroReview Assigned To => adrianromero
2019-04-24 12:01adrianromeroNote Added: 0111263
2019-04-24 12:01adrianromeroStatusresolved => closed
2019-04-24 12:01adrianromeroFixed in Version => RR19Q3

Notes
(0111076)
hgbot   
2019-04-11 09:23   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 093996f367231f1ecac3ef3dc714ac649df21bd7
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Apr 11 12:53:12 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/093996f367231f1ecac3ef3dc714ac649df21bd7 [^]

Related to issue 40460 : Update discount calculation for applying discounts based on priority

---
M web/org.openbravo.retail.discounts.bytotal/js/promotion-by-total-utils.js
M web/org.openbravo.retail.discounts.bytotal/js/promotion-discounttotal.js
---
(0111086)
hgbot   
2019-04-12 07:40   
Repository: tools/automation/pi-mobile
Changeset: 799596a77295f88792acc98569c8ad5d4de7d3c1
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Apr 12 11:10:22 2019 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/799596a77295f88792acc98569c8ad5d4de7d3c1 [^]

Verifies issue 40460 : Added automated test 'I40460_VerifyTotalDiscountWithPriority'

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I40460_VerifyTotalDiscountWithPriority.java
---
(0111223)
hgbot   
2019-04-23 10:04   
Repository: tools/automation/pi-mobile
Changeset: 9e92b0d0670a9890d96452b30644ef281ea88d08
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Apr 23 13:34:09 2019 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/9e92b0d0670a9890d96452b30644ef281ea88d08 [^]

Verifies issue 40460 : Modified automated test 'SplitLineWithAutomaticPromoScaledPrice'

* Modified automated test 'SplitLineWithAutomaticPromoFreeProdScaledPriceAndManualPromo'

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/splitline/SplitLineWithAutomaticPromoFreeProdScaledPriceAndManualPromo.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/splitline/SplitLineWithAutomaticPromoScaledPrice.java
---
(0111263)
adrianromero   
2019-04-24 12:01   
Verified.