Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040453Retail ModulesWeb POSpublic2019-03-26 12:052019-04-15 12:38
Reportersamuel_nicuesa 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customerGold
Support ticket8788
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040453: Return line button should be disabled selecting positive and negative lines.
DescriptionReturn line button should be disabled selecting positive and negative lines.
Steps To Reproduce[POS]

- Create a new ticket

- Add 2 products

- Select one line an press return line button

- Select both product lines

- Return line button shouldn't be available.
Proposed SolutionThe idea is for the Return Line button to be enabled only when all lines are positive, or all are negative. If both negative and positive lines are selected, it is not clear how it should work, it would be quite confusing anyway, so it's best to just hide it.
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch issue 40453 source posterminal.patch (6,692) 2019-04-02 08:15
https://issues.openbravo.com/file_download.php?file_id=12819&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-03-26 12:05samuel_nicuesaNew Issue
2019-03-26 12:05samuel_nicuesaAssigned To => Retail
2019-03-26 12:05samuel_nicuesaOBNetwork customer => Gold
2019-03-26 12:05samuel_nicuesaSupport ticket => 8788
2019-03-26 12:05samuel_nicuesaResolution time => 1555365600
2019-03-26 12:05samuel_nicuesaTriggers an Emergency Pack => No
2019-03-26 12:33rafarodaIssue Monitored: rafaroda
2019-03-26 12:37ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-03-26 12:37ranjith_qualiantech_comStatusnew => scheduled
2019-03-26 13:42marvintmSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18540#r18540
2019-03-26 13:42marvintmProposed Solution updated
2019-03-27 11:24ranjith_qualiantech_comFile Added: issue 40453 source posterminal.patch
2019-04-02 08:15ranjith_qualiantech_comFile Deleted: issue 40453 source posterminal.patch
2019-04-02 08:15ranjith_qualiantech_comFile Added: issue 40453 source posterminal.patch
2019-04-08 11:42hgbotCheckin
2019-04-08 11:42hgbotNote Added: 0111015
2019-04-08 11:42hgbotStatusscheduled => resolved
2019-04-08 11:42hgbotResolutionopen => fixed
2019-04-08 11:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/016c34fc5c7111bf4760d8d564f4a0c0b3e1c862 [^]
2019-04-15 12:38adrianromeroReview Assigned To => adrianromero
2019-04-15 12:38adrianromeroNote Added: 0111128
2019-04-15 12:38adrianromeroStatusresolved => closed
2019-04-15 12:38adrianromeroFixed in Version => RR19Q3

Notes
(0111015)
hgbot   
2019-04-08 11:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 016c34fc5c7111bf4760d8d564f4a0c0b3e1c862
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Apr 08 15:12:37 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/016c34fc5c7111bf4760d8d564f4a0c0b3e1c862 [^]

Fixed issue 40453 : Hide Return Line Button in EDIT Tab when selected lines quantity sign are different

* Refactored rearrangeEditButtonBar function
  Logic for displaying returnLine, deleteLine, showRelatedServices are present inside the removeDiscountButton
  So added button exists condition for each EDIT tab button in rearrangeEditButtonBar function

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
---
(0111128)
adrianromero   
2019-04-15 12:38   
Verified