Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040448Retail ModulesOmnichannelpublic2019-03-20 13:162019-03-26 19:19
Reporterinaki_garcia 
Assigned ToRetail 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionRR19Q1Fixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression levelPackaging and release
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040448: [RR19Q1] [OMNI] Incorrect error message is shown when reopening a partially paid ticket with an attempted Cancel and Replace
DescriptionWhen reopening a partially paid ticket on which a "Cancel and Replace" has been attempted but not completed, the message "Receipt XXX is already opened in the session of 'user'" appears.
Steps To Reproduce0. Log in the Web POS.
1. Create a ticket with more than one line, and partially pay it.
2. Use the menu option "Open Receipt" to seek and open the ticket created above. Note the ticket is properly opened.
3. Click on the "Cancel and Replace" menu option. A new ticket is created with the same id and the "-1" concatenated. "'Cancel and Replace' of <id>" message appears on the ticket.
4. Add a payment and try to delete the ticket. A popup with the "There has been payment added..." message appears. Dismiss the popup, remove the payment and delete the ticket.
5. Repeat step 2. NOTICE that this time an error popup message as depicted in the attached screenshot is shown reminding as if the user were working with the ticket,
but said ticket shouldn't exist. The popup message keeps appearing each time this step is taken.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0040418 closed jorge-garcia [RR19Q1] [OMNI] Incorrect error message is shown when reopening a partially paid ticket with an attempted Cancel and Replace 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-25 16:36jorge-garciaTypedefect => backport
2019-03-25 16:36jorge-garciaTarget Version => RR19Q1
2019-03-25 16:36jorge-garciaReview Assigned To => jorge-garcia
2019-03-26 12:21hgbotCheckin
2019-03-26 12:21hgbotNote Added: 0110654
2019-03-26 12:21hgbotStatusscheduled => resolved
2019-03-26 12:21hgbotResolutionopen => fixed
2019-03-26 12:21hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/121556d5e8902151e6ec91a5c611a893d5e606ed [^]
2019-03-26 19:19marvintmStatusresolved => closed
2019-03-26 19:19marvintmFixed in Version => RR19Q1

Notes
(0110654)
hgbot   
2019-03-26 12:21   
Repository: retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal
Changeset: 121556d5e8902151e6ec91a5c611a893d5e606ed
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Mar 26 12:20:30 2019 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/121556d5e8902151e6ec91a5c611a893d5e606ed [^]

Fixed issue 40448: [RR19Q1] [OMNI] Incorrect error message is shown when
reopening a partially paid ticket with an attempted Cancel and Replace

Backbone has a functionality inside its collections where the added models ids
are save in an internal variable.

If a model inside a backbone collection change its id, the collection does not
remove the loaded id from its internal variable.

The solution is to remove element from collection before changing its id and add
it again after all changes.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---