Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040446Retail ModulesQuotationspublic2019-03-25 10:532019-05-09 18:50
Reportermontesm 
Assigned Torqueralta 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040446: Operating flow to an incorrect status of a quotation.
DescriptionIncorrect flow of a Quotation between a seller terminal and a cashier terminal.
Steps To Reproduce. A seller creates a Quotation and remains open in the seller's terminal (status: under evaluation).
. A cashier opens the Quotation, transforms it into Layaway and pays.
. The Quotation is still open in the Seller terminal.
. The seller executes the option 'reject quotation'
. The Quotation is updated to the 'closed-rejected' status and is also linked to the created Order.

Video: https://drive.google.com/file/d/1T85likG1Qg3rhSE96uRJgIy7dNxF5scW/view [^]
Proposed Solution2 proposals:

1) validate the change of status of the Quotation.
or
2) Close the document when it is under evaluation.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-25 10:53montesmNew Issue
2019-03-25 10:53montesmAssigned To => Retail
2019-03-25 10:53montesmResolution time => 1556575200
2019-03-25 10:53montesmTriggers an Emergency Pack => No
2019-03-26 15:06rqueraltaAssigned ToRetail => rqueralta
2019-03-26 15:08rqueraltaStatusnew => scheduled
2019-04-29 15:03hgbotCheckin
2019-04-29 15:03hgbotNote Added: 0111370
2019-04-29 15:03hgbotStatusscheduled => resolved
2019-04-29 15:03hgbotResolutionopen => fixed
2019-04-29 15:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cb37a8a809b09d6213a708af31abf278eac7af39 [^]
2019-05-06 13:32migueldejuanaNote Added: 0111499
2019-05-06 13:32migueldejuanaStatusresolved => new
2019-05-06 13:32migueldejuanaResolutionfixed => open
2019-05-07 14:39hgbotCheckin
2019-05-07 14:39hgbotNote Added: 0111545
2019-05-07 14:39hgbotStatusnew => resolved
2019-05-07 14:39hgbotResolutionopen => fixed
2019-05-07 14:39hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cb37a8a809b09d6213a708af31abf278eac7af39 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e75cde03ae992f50be620a32abcf4eee97031f05 [^]
2019-05-07 17:11migueldejuanaNote Added: 0111547
2019-05-07 17:11migueldejuanaStatusresolved => new
2019-05-07 17:11migueldejuanaResolutionfixed => open
2019-05-09 15:01hgbotCheckin
2019-05-09 15:01hgbotNote Added: 0111600
2019-05-09 15:01hgbotStatusnew => resolved
2019-05-09 15:01hgbotResolutionopen => fixed
2019-05-09 15:01hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e75cde03ae992f50be620a32abcf4eee97031f05 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6d319e0a1bbb59c64214e755ac3ea836a13e76fd [^]
2019-05-09 18:50migueldejuanaReview Assigned To => migueldejuana
2019-05-09 18:50migueldejuanaNote Added: 0111606
2019-05-09 18:50migueldejuanaStatusresolved => closed

Notes
(0111370)
hgbot   
2019-04-29 15:03   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: cb37a8a809b09d6213a708af31abf278eac7af39
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sun Apr 28 13:53:04 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cb37a8a809b09d6213a708af31abf278eac7af39 [^]

Fixed issue 40446: Operating flow to an incorrect status of a quotation

- If the status is "CA", reject this quotation is avoided

---
M src/org/openbravo/retail/posterminal/QuotationsReject.java
---
(0111499)
migueldejuana   
2019-05-06 13:32   
- If reason is null when rejecting the quotation we are getting NullPointerException.
- We are covering the case of create sales order first and then reject quotation, we are not covering reject first and then create sales order.
(0111545)
hgbot   
2019-05-07 14:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e75cde03ae992f50be620a32abcf4eee97031f05
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon May 06 16:07:44 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e75cde03ae992f50be620a32abcf4eee97031f05 [^]

Fixed issue 40446: Operating flow to an incorrect status of a quotation

- Added support we are covering reject first and then create sales order flow.

---
M src/org/openbravo/retail/posterminal/QuotationsReject.java
---
(0111547)
migueldejuana   
2019-05-07 17:11   
Still happening the same.
(0111600)
hgbot   
2019-05-09 15:01   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6d319e0a1bbb59c64214e755ac3ea836a13e76fd
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed May 08 11:41:58 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6d319e0a1bbb59c64214e755ac3ea836a13e76fd [^]

Fixed issue 40446: Operating flow to an incorrect status of a quotation

- Added support for covering reject quotation and then create sales order of the
same quotation.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/QuotationsReject.java
---
(0111606)
migueldejuana   
2019-05-09 18:50   
Tested and reviewed