Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040441Retail ModulesDiscounts and Promotionspublic2019-03-22 12:282019-05-22 10:50
Reporternicola_uva 
Assigned Tonicola_uva 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionRR19Q3Fixed in VersionRR19Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040441: Discounts Category Enhancement - New discount type: Set line price
DescriptionBackport the changes from the repository specified below into pi product version.

Repository:
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.posterminal-but-dev/rev/cce11ed1ffe0 [^]
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.discounts-but-dev/rev/bc8833e61bde [^]
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.discounts-but-dev/rev/34289103ffc9 [^]
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.discounts.coupons-but-dev/rev/51e5ad32221b [^]
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.discounts.category-but-dev/rev/7316c5f92dc9 [^]
Steps To Reproduce- Log into the backoffice
- Go to Discounts and Promotions
- Create a record with User Defined Line Amount Type and Line final gross 10
- Log into WebPOS
- Add an avalanche transceiver
- Click Discounts
- See that it adds a discount of 140.50€
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040981 closed nicola_uva We cannot decide the final price in WebPOS by using a "User Defined Line Amount" discount type. 
related to defect 0040980 closed nicola_uva "User Defined Line Amount" discount type in backend is forcing by the trigger to fill the Line Final Gross to save it. 
Attached Filesdiff 40441_1.diff (1,015) 2019-03-26 12:17
https://issues.openbravo.com/file_download.php?file_id=12779&type=bug
diff 40441_3.diff (1,108) 2019-03-26 12:18
https://issues.openbravo.com/file_download.php?file_id=12781&type=bug
diff 40441_4.diff (1,386) 2019-03-26 12:18
https://issues.openbravo.com/file_download.php?file_id=12782&type=bug
diff 40441_5.diff (522) 2019-03-26 12:18
https://issues.openbravo.com/file_download.php?file_id=12783&type=bug
diff 40441_6.diff (626) 2019-03-26 14:24
https://issues.openbravo.com/file_download.php?file_id=12786&type=bug
diff 40441_2.diff (17,944) 2019-03-26 14:26
https://issues.openbravo.com/file_download.php?file_id=12787&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-03-22 12:28nicola_uvaNew Issue
2019-03-22 12:28nicola_uvaAssigned To => nicola_uva
2019-03-22 12:28nicola_uvaOBNetwork customer => No
2019-03-22 12:28nicola_uvaTriggers an Emergency Pack => No
2019-03-22 13:25guillermogilCategoryDiscounts Category => Discounts and Promotions
2019-03-22 13:29guillermogilDescription Updatedbug_revision_view_page.php?rev_id=18522#r18522
2019-03-26 12:17nicola_uvaFile Added: 40441_1.diff
2019-03-26 12:18nicola_uvaFile Added: 40441_2.diff
2019-03-26 12:18nicola_uvaFile Added: 40441_3.diff
2019-03-26 12:18nicola_uvaFile Added: 40441_4.diff
2019-03-26 12:18nicola_uvaFile Added: 40441_5.diff
2019-03-26 14:24nicola_uvaFile Added: 40441_6.diff
2019-03-26 14:25nicola_uvaFile Deleted: 40441_2.diff
2019-03-26 14:26nicola_uvaFile Added: 40441_2.diff
2019-04-15 18:13hgbotCheckin
2019-04-15 18:13hgbotNote Added: 0111147
2019-04-15 18:13hgbotStatusnew => resolved
2019-04-15 18:13hgbotResolutionopen => fixed
2019-04-15 18:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/c2d277da1434c048f97820140e1b1e7c2b451273 [^]
2019-04-15 18:13hgbotCheckin
2019-04-15 18:13hgbotNote Added: 0111148
2019-04-15 18:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/c2d277da1434c048f97820140e1b1e7c2b451273 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.category/rev/0786652764156be8fb4014c913364c8100af8f23 [^]
2019-04-15 18:13hgbotCheckin
2019-04-15 18:13hgbotNote Added: 0111150
2019-04-15 18:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.category/rev/0786652764156be8fb4014c913364c8100af8f23 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7e69acb13b55f030e6eae0ca0ab421c79c964f6b [^]
2019-04-15 18:13hgbotCheckin
2019-04-15 18:13hgbotNote Added: 0111151
2019-05-15 09:06marvintmReview Assigned To => marvintm
2019-05-15 09:06marvintmStatusresolved => closed
2019-05-15 09:06marvintmFixed in Version => RR19Q3
2019-05-22 10:50guillermogilSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18805#r18805
2019-05-30 17:25guillermogilRelationship addedrelated to 0040981
2019-05-30 17:25guillermogilRelationship addedrelated to 0040980

Notes
(0111147)
hgbot   
2019-04-15 18:13   
Repository: erp/pmods/org.openbravo.retail.discounts.coupons
Changeset: c2d277da1434c048f97820140e1b1e7c2b451273
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Apr 15 10:33:19 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/c2d277da1434c048f97820140e1b1e7c2b451273 [^]

Fixed Issue 40441: Discounts Category Enhancement - New discount type: Set line price

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0111148)
hgbot   
2019-04-15 18:13   
Repository: erp/pmods/org.openbravo.retail.discounts.category
Changeset: 0786652764156be8fb4014c913364c8100af8f23
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Apr 15 10:15:52 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.category/rev/0786652764156be8fb4014c913364c8100af8f23 [^]

Fixed Issue 40441: New discount type: Set line price

---
M src-db/database/sourcedata/AD_FIELD.xml
M web/org.openbravo.retail.discounts.category/js/discountsButton.js
---
(0111150)
hgbot   
2019-04-15 18:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7e69acb13b55f030e6eae0ca0ab421c79c964f6b
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Apr 15 10:05:28 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7e69acb13b55f030e6eae0ca0ab421c79c964f6b [^]

Fixed issue 40441: New discount type: Set line price

---
M web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0111151)
hgbot   
2019-04-15 18:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7e69acb13b55f030e6eae0ca0ab421c79c964f6b
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Apr 15 10:05:28 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7e69acb13b55f030e6eae0ca0ab421c79c964f6b [^]

Fixed issue 40441: New discount type: Set line price

---
M web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---