Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040440Retail ModulesWeb POSpublic2019-03-22 12:252019-05-13 07:28
Reporternicola_uva 
Assigned Tonicola_uva 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionRR19Q3Fixed in VersionRR19Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040440: Discounts Category Enhancement - Multi selection will be kept in discounts window
DescriptionBackport the changes from the repository specified below into pi product version.

Repository:

https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.posterminal-but-dev/rev/58b24f7557d2 [^]
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.posterminal-but-dev/rev/bfe4035aad6a [^]
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.discounts.category-but-dev/rev/717699da0102 [^]
Steps To Reproduce- Login in backoffice
- Create preference "WebPOS Check Discounts if Lines are Selected" with value Y
- Login in WebPOS
- Add 3 different products
- Select line 1 and 3 (Multiselection)
- Click discounts button

You will notice that the previously selected lines are still selected
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 40440_1.diff (5,003) 2019-03-26 12:16
https://issues.openbravo.com/file_download.php?file_id=12777&type=bug
diff 40440_2.diff (704) 2019-03-26 12:17
https://issues.openbravo.com/file_download.php?file_id=12778&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-03-22 12:25nicola_uvaNew Issue
2019-03-22 12:25nicola_uvaAssigned To => nicola_uva
2019-03-22 12:25nicola_uvaOBNetwork customer => No
2019-03-22 12:25nicola_uvaTriggers an Emergency Pack => No
2019-03-22 13:25guillermogilCategoryDiscounts Category => Web POS
2019-03-22 13:29guillermogilDescription Updatedbug_revision_view_page.php?rev_id=18518#r18518
2019-03-26 12:16nicola_uvaFile Added: 40440_1.diff
2019-03-26 12:17nicola_uvaFile Added: 40440_2.diff
2019-04-15 18:13hgbotCheckin
2019-04-15 18:13hgbotNote Added: 0111152
2019-04-15 18:13hgbotStatusnew => resolved
2019-04-15 18:13hgbotResolutionopen => fixed
2019-04-15 18:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.category/rev/c9bceba9489392ea49ac7cb17d205d35e9710533 [^]
2019-04-15 18:13hgbotCheckin
2019-04-15 18:13hgbotNote Added: 0111153
2019-04-15 18:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.category/rev/c9bceba9489392ea49ac7cb17d205d35e9710533 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/805c102b224cc78c4a285d5f1abd0318b391ac56 [^]
2019-04-15 18:13hgbotCheckin
2019-04-15 18:13hgbotNote Added: 0111155
2019-04-15 18:13hgbotCheckin
2019-04-15 18:13hgbotNote Added: 0111156
2019-05-01 08:43marvintmReview Assigned To => marvintm
2019-05-01 08:43marvintmStatusresolved => closed
2019-05-01 08:43marvintmFixed in Version => RR19Q3
2019-05-13 07:28guillermogilSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18753#r18753

Notes
(0111152)
hgbot   
2019-04-15 18:13   
Repository: erp/pmods/org.openbravo.retail.discounts.category
Changeset: c9bceba9489392ea49ac7cb17d205d35e9710533
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Apr 15 10:25:39 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.category/rev/c9bceba9489392ea49ac7cb17d205d35e9710533 [^]

Fixed Issue 40440: Multi selection will be kept in discounts window

---
M web/org.openbravo.retail.discounts.category/js/discountsButton.js
---
(0111153)
hgbot   
2019-04-15 18:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 805c102b224cc78c4a285d5f1abd0318b391ac56
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Apr 15 10:35:38 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/805c102b224cc78c4a285d5f1abd0318b391ac56 [^]

Fixed Issue 40440: Multi selection will be kept in discounts window

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js
---
(0111155)
hgbot   
2019-04-15 18:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8287656722b71cff0537b6969289b28951ea43b0
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Apr 15 10:42:59 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8287656722b71cff0537b6969289b28951ea43b0 [^]

Related to issue 40440: Fixed JSBeutifier

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js
---
(0111156)
hgbot   
2019-04-15 18:13   
Repository: erp/pmods/org.openbravo.retail.discounts.category
Changeset: 4f5a01243d024de29b6807bcfacae9fb7e73ea11
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Apr 15 15:27:51 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.category/rev/4f5a01243d024de29b6807bcfacae9fb7e73ea11 [^]

Related to issue 40440: Multi selection will be kept in discounts window
Make it configurable with posterminal preference

---
M web/org.openbravo.retail.discounts.category/js/discountsButton.js
---