Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040430Retail ModulesWeb POSpublic2019-03-21 12:382019-03-26 17:57
Reporterpsanjuan 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040430: Duplicated negative invoice created by the cash up process.
DescriptionDuplicated negative invoice created by the cash up process.
Steps To ReproduceIn a 19Q1 enviroment, configure below system preference as described below, by putting Web POS module in development:

"Web POS restrict invoice if no tax ID"

as Y

In the backoffice configure channel touchpoint (VBS-1) as:

Group orders in one invoice = No
Generate invoice for orders = No

Go to Web POS and refresh it.
Run a cash up process to start.

Create a receipt for Arturo Montoro, invoice it and pay it. Write down order number for instance receipt 128

Return that receipt by using the option, verified returs. Invoice that return and pay it. Write down order number, for instace 129

Go to the back office and verify that 2 new invoices have been created:
Invoice number 16 related to receipt 128; and Reverse Sales Invoice number 2 related to receipt 129. See image attached 40430_1

Go to Web POS and make another sales for VBS Customer. Do not invoice it. Write down ticket number 130

Return this sales by using the option verified returns. Do not invoice it. Write down ticket number 131

Run Cash up process.

Go to the backoffice and verify that there are 2 sales orders, 2 return from customer orders and 5 invoices.

The error here is that an additional negative sales invoice is created related to the receipt 129, already invoiced (Reverse Sales Invoice). See image attached 40430_2
Proposed SolutionThere should only be 4 invoices in this scenario.

Last negative sales invoice should not have been created.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040371 closed jorge-garcia Cash up process is not creating reverse sales invoices 
Attached Filesjpg 40430_1.jpg (85,534) 2019-03-21 13:01
https://issues.openbravo.com/file_download.php?file_id=12769&type=bug
jpg

jpg 40430_2.jpg (81,208) 2019-03-21 13:02
https://issues.openbravo.com/file_download.php?file_id=12770&type=bug
jpg
Issue History
Date ModifiedUsernameFieldChange
2019-03-21 12:38psanjuanNew Issue
2019-03-21 12:38psanjuanAssigned To => Retail
2019-03-21 12:38psanjuanTriggers an Emergency Pack => No
2019-03-21 13:00psanjuanNote Added: 0110543
2019-03-21 13:00psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18508#r18508
2019-03-21 13:00psanjuanProposed Solution updated
2019-03-21 13:01psanjuanFile Added: 40430_1.jpg
2019-03-21 13:02psanjuanFile Added: 40430_2.jpg
2019-03-25 12:20psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18523#r18523
2019-03-25 12:20psanjuanProposed Solution updated
2019-03-25 12:20psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18524#r18524
2019-03-25 12:51ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-03-25 12:51ranjith_qualiantech_comStatusnew => scheduled
2019-03-26 07:32ranjith_qualiantech_comRelationship addedrelated to 0040371
2019-03-26 07:38hgbotCheckin
2019-03-26 07:38hgbotNote Added: 0110639
2019-03-26 07:38hgbotStatusscheduled => resolved
2019-03-26 07:38hgbotResolutionopen => fixed
2019-03-26 07:38hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.returns/rev/0a7856d5e4e7ae9ecea5973e70c54c83cbe39663 [^]
2019-03-26 17:57marvintmReview Assigned To => marvintm
2019-03-26 17:57marvintmStatusresolved => closed
2019-03-26 17:57marvintmFixed in Version => RR19Q1

Notes
(0110543)
psanjuan   
2019-03-21 13:00   
This is working OK in 18Q4
(0110639)
hgbot   
2019-03-26 07:38   
Repository: retail/backports/3.0RR19Q1/org.openbravo.retail.returns
Changeset: 0a7856d5e4e7ae9ecea5973e70c54c83cbe39663
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Mar 26 12:07:56 2019 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.returns/rev/0a7856d5e4e7ae9ecea5973e70c54c83cbe39663 [^]

Fixed issue 40430 : Duplicated negative invoice created by the cash up process

It necessary to reset invoicedQuantity property from order line when a verified
return line is added.

---
M web/org.openbravo.retail.returns/js/returnUtils.js
---