Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040419Retail ModulesQuotationspublic2019-03-20 13:292019-04-09 15:31
Reporterucarrion 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040419: A deferred service can be related to a products included in a quotation 'under evaluation'
DescriptionA deferred service can be related to a products included in a quotation 'under evaluation' by using 'Add associations' option.

In addition, if a quotation is opened when trying to create a deferred service, the quoation document is proposed to add the service there but the popup doesn't work if selecting it.


Steps To Reproducehttps://drive.google.com/file/d/1c0EgzQO_eYGmMeJZoMpvFAQ3r93PwGgo/view [^]
Proposed SolutionThe deferred service should not be able to be related to a quotation line.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-20 13:29ucarrionNew Issue
2019-03-20 13:29ucarrionAssigned To => Retail
2019-03-20 13:29ucarrionResolution time => 1553814000
2019-03-20 13:29ucarrionTriggers an Emergency Pack => No
2019-03-20 15:05rqueraltaAssigned ToRetail => rqueralta
2019-03-20 15:10rqueraltaStatusnew => scheduled
2019-03-23 13:17hgbotCheckin
2019-03-23 13:17hgbotNote Added: 0110604
2019-03-23 13:17hgbotStatusscheduled => resolved
2019-03-23 13:17hgbotResolutionopen => fixed
2019-03-23 13:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7dc49e384d0d047f13bae49c69a163bf76959397 [^]
2019-03-28 19:24marvintmNote Added: 0110904
2019-03-28 19:24marvintmStatusresolved => new
2019-03-28 19:24marvintmResolutionfixed => open
2019-03-29 12:08hgbotCheckin
2019-03-29 12:08hgbotNote Added: 0110923
2019-03-29 12:08hgbotStatusnew => resolved
2019-03-29 12:08hgbotResolutionopen => fixed
2019-03-29 12:08hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7dc49e384d0d047f13bae49c69a163bf76959397 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/25b878d252a5bd4de5ed7f787a68afd74c1b1fee [^]
2019-03-29 12:37marvintmReview Assigned To => marvintm
2019-03-29 12:37marvintmStatusresolved => closed
2019-03-29 12:37marvintmFixed in Version => RR19Q2
2019-04-09 15:31hgbotCheckin
2019-04-09 15:31hgbotNote Added: 0111044

Notes
(0110604)
hgbot   
2019-03-23 13:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7dc49e384d0d047f13bae49c69a163bf76959397
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Fri Mar 22 10:38:11 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7dc49e384d0d047f13bae49c69a163bf76959397 [^]

Fixed issue 40419: A deferred service can be related to a products included in a
quotation 'under evaluation'

- Query to retrieve sales orders to associate it with a deferred service was
changed to exclude quotations orders.

---
M src/org/openbravo/retail/posterminal/AssociateOrderLines.java
---
(0110904)
marvintm   
2019-03-28 19:24   
The proper way to filter quotations is by checking the document type, not the status of the document. By doing it in this way, you are missing for example Rejected Quotations which will probably still appear in the selector.

The added filter should be reverted, and a filter by the document type (filtering by the doc subtype) should be added instead.

Please do not remove the previously existing filter by the status "CL" as that is still needed for other reasons.
(0110923)
hgbot   
2019-03-29 12:08   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 25b878d252a5bd4de5ed7f787a68afd74c1b1fee
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu Mar 28 16:22:15 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/25b878d252a5bd4de5ed7f787a68afd74c1b1fee [^]

Fixed issue 40419: A deferred service can be related to a products included in a
quotation 'under evaluation'

- Filter by document status was replaced by doc subtype filter

---
M src/org/openbravo/retail/posterminal/AssociateOrderLines.java
---
(0111044)
hgbot   
2019-04-09 15:31   
Repository: tools/automation/pi-mobile
Changeset: f7e3bb2f9bccde4a5c5d67a8ddbfd2e333444da1
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Tue Mar 26 12:40:12 2019 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f7e3bb2f9bccde4a5c5d67a8ddbfd2e333444da1 [^]

Related to issue 40419: added automated test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/services/I40419_VerifyDeferredServiceInQuotation.java
---