Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040418Retail ModulesOmnichannelpublic2019-03-20 13:162019-03-26 19:18
Reporterinaki_garcia 
Assigned Tojorge-garcia 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelPackaging and release
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040418: [RR19Q1] [OMNI] Incorrect error message is shown when reopening a partially paid ticket with an attempted Cancel and Replace
DescriptionWhen reopening a partially paid ticket on which a "Cancel and Replace" has been attempted but not completed, the message "Receipt XXX is already opened in the session of 'user'" appears.
Steps To Reproduce0. Log in the Web POS.
1. Create a ticket with more than one line, and partially pay it.
2. Use the menu option "Open Receipt" to seek and open the ticket created above. Note the ticket is properly opened.
3. Click on the "Cancel and Replace" menu option. A new ticket is created with the same id and the "-1" concatenated. "'Cancel and Replace' of <id>" message appears on the ticket.
4. Add a payment and try to delete the ticket. A popup with the "There has been payment added..." message appears. Dismiss the popup, remove the payment and delete the ticket.
5. Repeat step 2. NOTICE that this time an error popup message as depicted in the attached screenshot is shown reminding as if the user were working with the ticket,
but said ticket shouldn't exist. The popup message keeps appearing each time this step is taken.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040088 closed javierRodriguez [RR19Q1] [OMNI] An incorrect error message is shown after picking a paid ticket 
depends on backport 0040448RR19Q1 closed Retail [RR19Q1] [OMNI] Incorrect error message is shown when reopening a partially paid ticket with an attempted Cancel and Replace 
related to defect 0049770 closed ranjith_qualiantech_com Cancel and replace ticket not displaying in pay open tickets 
Attached Filespng ReceiptAlreadyOpened.png (590,091) 2019-03-20 13:32
https://issues.openbravo.com/file_download.php?file_id=12767&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-03-20 13:16inaki_garciaNew Issue
2019-03-20 13:16inaki_garciaAssigned To => Retail
2019-03-20 13:16inaki_garciaRegression level => Packaging and release
2019-03-20 13:16inaki_garciaTriggers an Emergency Pack => No
2019-03-20 13:16inaki_garciaIssue generated from0040088
2019-03-20 13:16inaki_garciaRelationship addedrelated to 0040088
2019-03-20 13:28inaki_garciaSummary[RR19Q1] [OMNI] Incorrect error message is shown => [RR19Q1] [OMNI] Incorrect error message is shown when reopening a partially paid ticket with an attempted Cancel and Replace
2019-03-20 13:28inaki_garciaDescription Updatedbug_revision_view_page.php?rev_id=18501#r18501
2019-03-20 13:28inaki_garciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18503#r18503
2019-03-20 13:29inaki_garciaDescription Updatedbug_revision_view_page.php?rev_id=18504#r18504
2019-03-20 13:31inaki_garciaFile Added: ReceiptAlreadyOpened.jpg
2019-03-20 13:32inaki_garciaFile Added: ReceiptAlreadyOpened.png
2019-03-20 13:32inaki_garciaFile Deleted: ReceiptAlreadyOpened.jpg
2019-03-25 16:36jorge-garciaStatusnew => scheduled
2019-03-25 16:36jorge-garciaAssigned ToRetail => jorge-garcia
2019-03-26 12:14hgbotCheckin
2019-03-26 12:14hgbotNote Added: 0110653
2019-03-26 12:14hgbotStatusscheduled => resolved
2019-03-26 12:14hgbotResolutionopen => fixed
2019-03-26 12:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b13bb3c0dfbf761fc2ce7904cd411ad9abe32345 [^]
2019-03-26 19:18marvintmReview Assigned To => marvintm
2019-03-26 19:18marvintmStatusresolved => closed
2019-03-26 19:18marvintmFixed in Version => RR19Q2
2022-08-02 07:12ranjith_qualiantech_comRelationship addedrelated to 0049770

Notes
(0110653)
hgbot   
2019-03-26 12:14   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b13bb3c0dfbf761fc2ce7904cd411ad9abe32345
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Mar 26 08:58:31 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b13bb3c0dfbf761fc2ce7904cd411ad9abe32345 [^]

Fixed issue 40418: [RR19Q1] [OMNI] Incorrect error message is shown when
reopening a partially paid ticket with an attempted Cancel and Replace

Backbone has a functionality inside its collections where the added models ids
are save in an internal variable.

If a model inside a backbone collection change its id, the collection does not
remove the loaded id from its internal variable.

The solution is to remove element from collection before changing its id and add
it again after all changes.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---