Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040399Retail ModulesWeb POSpublic2019-03-15 14:082019-10-16 14:30
Reportergorka_gil 
Assigned Toalekosmp86 
PriorityimmediateSeveritymajorReproducibilityalways
StatusnewResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040399: Create an OTF hangs the pos
DescriptionWhen creating an 'on the fly', after click on apply, the web pos gets totally hang.

It don't respond to any click, nor open the developer tools, not close the window. Looks like infinite loop.

It can be reproduced in the tests and manually. Reproduced in chrome 72 and 73.


It starts happening in the night from 14 to 15 of march, but after reverting all the commits, also continues happening. These are all the commits that enter from when it works:
https://ci.openbravo.com/view/retail/job/ret-test-modules-pgsql-suite2/1207/changes [^]
(there was not changes in external modules, and this test was in stable from long time)

In ci only happens in postgres but not in oracle.
Steps To ReproduceCan be reproduced in livebuilds:

https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=CTST1#retail.pointofsale [^]

(Note: the terminal CTST1)

Following the steps of the test: CreateOTFWithCategoryTreeFromMainMenu
- menu, create new otf
- set name
- choose category lighting electronics/ lighting
- set price 20.50
Click on apply
The pos gets hang.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-15 14:08gorka_gilNew Issue
2019-03-15 14:08gorka_gilAssigned To => Retail
2019-03-15 14:08gorka_gilTriggers an Emergency Pack => No
2019-03-15 14:17gorka_gilNote Added: 0110459
2019-03-16 09:31ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-03-16 09:31ranjith_qualiantech_comStatusnew => scheduled
2019-03-19 14:53ranjith_qualiantech_comAssigned Toranjith_qualiantech_com => alekosmp86
2019-03-19 14:53ranjith_qualiantech_comNote Added: 0110491
2019-03-19 14:54ranjith_qualiantech_comNote Added: 0110492
2019-03-20 06:42hgbotCheckin
2019-03-20 06:42hgbotNote Added: 0110503
2019-03-22 17:01hgbotCheckin
2019-03-22 17:01hgbotNote Added: 0110595
2019-10-02 20:52alekosmp86Statusscheduled => resolved
2019-10-02 20:52alekosmp86Resolutionopen => fixed
2019-10-04 13:57jorge-garciaReview Assigned To => jorge-garcia
2019-10-16 14:30adrianromeroNote Added: 0115114
2019-10-16 14:30adrianromeroStatusresolved => new
2019-10-16 14:30adrianromeroResolutionfixed => open

Notes
(0110459)
gorka_gil   
2019-03-15 14:17   
In livebuilds oracle is NOT reproducible:

https://livebuilds.openbravo.com/retail_modules_oracle_pi/web/org.openbravo.retail.posterminal/?terminal=CTST1#retail.pointofsale [^]

(Note the terminal CTST1)
(0110491)
ranjith_qualiantech_com   
2019-03-19 14:53   
Repository: tools/automation/pi-mobile
Changeset: 3fb6e398e95813dbdfb7250aa0e79ad58da06071
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Mar 19 11:32:45 2019 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3fb6e398e95813dbdfb7250aa0e79ad58da06071 [^] [^]

Verifies issue 40399 : Added waitFixOf until issue is fixed

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/productonfly/CreateOTFWithCategoryTreeFromMainMenu.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/productonfly/CreateOTFWithComplementaryProduct.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/productonfly/CreateOTFWithDiscounts.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/productonfly/CreateOTFWithErrors.java
(0110492)
ranjith_qualiantech_com   
2019-03-19 14:54   
Issue reproduce due to sample data https://code.openbravo.com/erp/pmods-branches/org.openbravo.test.mobile.sampledata/rev/228345de996d [^]
(0110503)
hgbot   
2019-03-20 06:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e6ef59f3ac426a60d0b06934eb3928d25c122e99
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Mar 20 11:12:39 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e6ef59f3ac426a60d0b06934eb3928d25c122e99 [^]

Related to issue 40399 : Validate Base Tax is not properly configured in POS

* When calculating tax, error message should be shown when base tax is not properly configured
  If taxList length is one and taxList doesn't have the base tax, then errorshould be shown

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0110595)
hgbot   
2019-03-22 17:01   
Repository: tools/automation/pi-mobile
Changeset: b2071b3fde80705397c0dc753714001ea6b43947
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Thu Mar 21 13:26:49 2019 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b2071b3fde80705397c0dc753714001ea6b43947 [^]

Related to issue 40399: removed waitFixOf annotation for OTF tests

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/productonfly/CreateOTFWithCategoryTreeFromMainMenu.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/productonfly/CreateOTFWithComplementaryProduct.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/productonfly/CreateOTFWithDiscounts.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/productonfly/CreateOTFWithErrors.java
---
(0115114)
adrianromero   
2019-10-16 14:30   
It seems there is still a place in the code that must include the same check:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/e6ef59f3ac42/web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js#l831 [^]