Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040398Retail ModulesGift cards and gift voucherspublic2019-03-15 13:582019-03-22 15:16
Reporterlorenzofidalgo 
Assigned Toranjith_qualiantech_com 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelPackaging and release
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040398: [RR19Q1] Approval is required to complete payment using Gift Cards even when exact amount is paid
DescriptionApproval is required even when the exact amount has been paid if Gift Cards are involved.

In case it is useful, the installed modules in the tested context are the following:

Contact customer info for product - 1.0.100 - English (USA)
Core - 3.0.35324 - English (USA)
Digital Coupons for Retail - 1.0.400 - English (USA)
Discount rules for Retail by total - 1.0.900 - English (USA)
Gift cards and vouchers - 1.3.900 - English (USA)
Max Level of Cash - 1.0.4 - English (USA)
Openbravo 3.0 - 3.0.35324 - English (USA)
Openbravo for Retail - 1.8.4103 - English (USA)
POS Terminals Session Management - 1.0.1300 - English (USA)
Products on fly - 1.0.200 - English (USA)
Retail Delivery Modes - 1.0.100 - English (USA)
Retail Sampledata - 1.0.3700 - English (USA)
WebPOS Scan Receipt - 1.0.300 - English (USA)
Steps To Reproduce0-Having Gift Cards and Vouchers module installed and a GC created and sold, log in POS as vallblanca.
1-Add 1x "Avalanche transceiver". Click Total Amount button.
2-Click "More..." and click Gift Card payment method. It must be selected. Now, click tick button to complete the payment. A popup will be shown: Select the previously created Gift Card and click Apply button to select it. The Gift Card will be added to the receipt.
4-Realise "Total is zero. No payment needed" is shown. Click "Done" button. DEFECT: An approval will be shown even when all the receipt has been completely paid.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0040417RR19Q1 closed ranjith_qualiantech_com [RR19Q1] Approval is required to complete payment using Gift Cards even when exact amount is paid 
has duplicate defect 0040396 closed ranjith_qualiantech_com [RR19Q]In situations where no payment is required, a prepayment approval message is shown and the flow can not continue this way 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-15 13:58lorenzofidalgoNew Issue
2019-03-15 13:58lorenzofidalgoAssigned To => Retail
2019-03-15 13:58lorenzofidalgoTriggers an Emergency Pack => No
2019-03-15 14:04lorenzofidalgoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18479#r18479
2019-03-18 10:04lorenzofidalgoDescription Updatedbug_revision_view_page.php?rev_id=18481#r18481
2019-03-18 10:04lorenzofidalgoDescription Updatedbug_revision_view_page.php?rev_id=18482#r18482
2019-03-18 10:04lorenzofidalgoDescription Updatedbug_revision_view_page.php?rev_id=18483#r18483
2019-03-18 15:06ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-03-18 16:31lorenzofidalgoRegression level => Packaging and release
2019-03-18 16:31lorenzofidalgoPrioritynormal => immediate
2019-03-18 16:41lorenzofidalgoRelationship addedhas duplicate 0040396
2019-03-19 12:10ranjith_qualiantech_comStatusnew => scheduled
2019-03-20 06:33hgbotCheckin
2019-03-20 06:33hgbotNote Added: 0110502
2019-03-20 06:33hgbotStatusscheduled => resolved
2019-03-20 06:33hgbotResolutionopen => fixed
2019-03-20 06:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/089af10014ad444022d902078f5f06564a597cb7 [^]
2019-03-20 11:34ranjith_qualiantech_comNote Added: 0110509
2019-03-20 11:34ranjith_qualiantech_comStatusresolved => new
2019-03-20 11:34ranjith_qualiantech_comResolutionfixed => open
2019-03-20 12:44ranjith_qualiantech_comStatusnew => scheduled
2019-03-20 12:44ranjith_qualiantech_comStatusscheduled => resolved
2019-03-20 12:44ranjith_qualiantech_comResolutionopen => fixed
2019-03-22 10:48hgbotCheckin
2019-03-22 10:48hgbotNote Added: 0110580
2019-03-22 15:16guilleaerReview Assigned To => guilleaer
2019-03-22 15:16guilleaerStatusresolved => closed
2019-03-22 15:16guilleaerFixed in Version => RR19Q2

Notes
(0110502)
hgbot   
2019-03-20 06:33   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 089af10014ad444022d902078f5f06564a597cb7
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Mar 20 11:03:01 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/089af10014ad444022d902078f5f06564a597cb7 [^]

Fixed issue 40398 : Validate Prepayment when receipt total is greater than zero

* If receipt is paid with gift card, it will adjusted with receipt total amount.
  So, prepayment should be validated when receipt total amount is greater than zero

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0110509)
ranjith_qualiantech_com   
2019-03-20 11:34   
Reopening to create backports
(0110580)
hgbot   
2019-03-22 10:48   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 134c726307ab34cc453d5a8b188a7c8bc33af941
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Mar 22 15:18:22 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/134c726307ab34cc453d5a8b188a7c8bc33af941 [^]

Related to issue 40398 : Validate Prepayment when receipt total is greater than zero

* If receipt is paid with gift card, it will adjusted with receipt total amount.
  So, prepayment should be validated when receipt total amount is greater than zero

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---