Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040384Retail ModulesStoreServerpublic2019-03-14 14:502019-05-20 08:56
Reportermtaal 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040384: When reloading do not go offline but allow forwarding of requests to cs
DescriptionWhen reloading currently we disallow any requests from webpos to the store server [1]. However, in online mode we can allow the webpos systems to work through the ss in the cs.
So no need to block it.

However, when reloading we should not allow going offline. However, this is already covered with the delta age functionality.

So in the end there is no need at all for the reload status and the reload message.

Steps To ReproduceInstall multi-server
stop the ss
enter some data in cs
restart ss put breakpoints at the right place and see that the system enters reload status
Proposed SolutionRemove the reload concept completely
Additional Information
TagsNo tags attached.
Relationships
causes defect 0040935 closed AugustoMauch Remove serverReloadHandler.js component resource creation from StoreSynchronizationComponentProvider 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-14 14:50mtaalNew Issue
2019-03-14 14:50mtaalAssigned To => mtaal
2019-03-14 14:50mtaalTriggers an Emergency Pack => No
2019-04-25 12:47hgbotCheckin
2019-04-25 12:47hgbotNote Added: 0111308
2019-04-25 12:47hgbotCheckin
2019-04-25 12:47hgbotNote Added: 0111309
2019-04-25 12:47hgbotCheckin
2019-04-25 12:47hgbotNote Added: 0111310
2019-04-25 12:48hgbotStatusnew => resolved
2019-04-25 12:48hgbotResolutionopen => fixed
2019-04-25 12:48hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/a1cb6270dfe80b996eda31c48b991647064c0d61 [^]
2019-04-25 12:49hgbotCheckin
2019-04-25 12:49hgbotNote Added: 0111311
2019-04-25 12:49hgbotCheckin
2019-04-25 12:49hgbotNote Added: 0111312
2019-04-25 12:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/a1cb6270dfe80b996eda31c48b991647064c0d61 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/3fb3fdb36a91ab75c3640150e14b9df16aafac09 [^]
2019-04-25 13:32AugustoMauchNote Added: 0111319
2019-04-26 08:57hgbotCheckin
2019-04-26 08:57hgbotNote Added: 0111339
2019-04-26 13:22hgbotCheckin
2019-04-26 13:22hgbotNote Added: 0111360
2019-05-03 09:08mtaalReview Assigned To => AugustoMauch
2019-05-10 09:01AugustoMauchAssigned Tomtaal => AugustoMauch
2019-05-10 09:01AugustoMauchReview Assigned ToAugustoMauch => mtaal
2019-05-14 19:10mtaalNote Added: 0111676
2019-05-14 19:10mtaalStatusresolved => closed
2019-05-20 08:56mtaalNote Added: 0111780
2019-05-22 11:15guillermogilRelationship addedcauses 0040935

Notes
(0111308)
hgbot   
2019-04-25 12:47   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 96cd0e9a05e53f4f0d421d24f2d79cd64212101c
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Apr 25 12:35:34 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/96cd0e9a05e53f4f0d421d24f2d79cd64212101c [^]

Related with issue 40384: Java format changes

---
M src/org/openbravo/replication/symmetricds/SetupSymmetricListener.java
---
(0111309)
hgbot   
2019-04-25 12:47   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 4ee41c0556217e9eeafa1f9d1009cae08b41e63f
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Apr 25 12:40:35 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/4ee41c0556217e9eeafa1f9d1009cae08b41e63f [^]

Related with issue 40384: Java format changes

---
M src/org/openbravo/replication/symmetricds/util/ReplicationUtils.java
---
(0111310)
hgbot   
2019-04-25 12:47   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: a1cb6270dfe80b996eda31c48b991647064c0d61
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Apr 25 12:47:10 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/a1cb6270dfe80b996eda31c48b991647064c0d61 [^]

Fixes issue 40384: Removes code related with server reload status

This functionality is no longer needed. Now the store servers take into account the delta by not
going offline if the delta age is too big.

---
M build.xml
M src-db/database/model/modifiedTables/OBMOBC_SERVER_DEFINITION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/replication/symmetricds/SetupSymmetricListener.java
M src/org/openbravo/replication/symmetricds/util/ReplicationUtils.java
R src/org/openbravo/replication/symmetricds/task/SetMandatoryReloadFlagTask.java
---
(0111311)
hgbot   
2019-04-25 12:49   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: fd4b60b4bb41871fca0fa822767daf767d6d465b
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Apr 25 12:43:26 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/fd4b60b4bb41871fca0fa822767daf767d6d465b [^]

Related with issue 40384: Java format changes

---
M src/org/openbravo/retail/storeserver/synchronization/RetailSynchronizationRequestHandler.java
M src/org/openbravo/retail/storeserver/synchronization/RetrieveServerVersionStatus.java
---
(0111312)
hgbot   
2019-04-25 12:49   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 3fb3fdb36a91ab75c3640150e14b9df16aafac09
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Apr 25 12:49:13 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/3fb3fdb36a91ab75c3640150e14b9df16aafac09 [^]

Fixes issue 40384: Removes code related with server reload status

This functionality is no longer needed. Now the store servers take into account the delta by not
going offline if the delta age is too big.

Removes code from org.openbravo.retail.storeserver.synchronization module

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/storeserver/synchronization/RetailSynchronizationRequestHandler.java
M src/org/openbravo/retail/storeserver/synchronization/RetrieveServerVersionStatus.java
R web/org.openbravo.retail.storeserver.synchronization/js/serverReloadHandler.js
---
(0111319)
AugustoMauch   
2019-04-25 13:32   
When the issue is closed, the wiki needs to be updated: http://wiki.openbravo.com/wiki/Retail:Store_Server_Initial_Data_Reload#Mandatory_versus_Non-Mandatory_Reload_-_forcing_mandatory_reload_at_startup [^]
(0111339)
hgbot   
2019-04-26 08:57   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 488342f14ee9328117e3ecc85627bb8ed4512920
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Apr 26 08:56:54 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/488342f14ee9328117e3ecc85627bb8ed4512920 [^]

Related with issue 40384: Removes MobileServerEventHandler

The only purpose of the MobileServerEventHandler event handler is to manage the Reload status, so it must be removed

---
R src/org/openbravo/retail/storeserver/synchronization/eventhandler/MobileServerEventHandler.java
---
(0111360)
hgbot   
2019-04-26 13:22   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 2602cbef8830334bc86e8bf11576e30a5c6b1210
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Apr 26 13:22:35 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/2602cbef8830334bc86e8bf11576e30a5c6b1210 [^]

Related with issue 40384: Removes unneeded AD_ELEMENT

---
M src-db/database/sourcedata/AD_ELEMENT.xml
---
(0111676)
mtaal   
2019-05-14 19:10   
Reviewed and tested
(0111780)
mtaal   
2019-05-20 08:56   
wiki content has been removed