Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040379Retail ModulesWeb POSpublic2019-03-14 12:112019-03-21 10:04
Reporterngarcia 
Assigned Tomigueldejuana 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040379: Two cash ups in local storage if the backoffice session is closed during the cash up
DescriptionTwo cash ups in local storage if the backoffice session is closed during the cash up. It causes the following orders to go to Errors While Importing POS Data with the following error as the JSON has the two cash up identifiers:

javax.persistence.EntityNotFoundException: No row with the given identifier exists: [OBPOS_App_Cashup#...]
Steps To ReproduceLink a terminal
Log in
Open Till
Do some orders
Open backoffice in the same browser (Back Office menu entry in the POS)
Return to POS
Do the Cash up but do not complete the Step 4
Log out in the backoffice
Return to POS
Post, print and close
Check the following error message is shown:

"The connection was restored. However, in the meantime, your session timed out. You must login again now to ensure proper synchronization. Your pending tickets will be saved."

Click on Log in again
Open Till again
Do some orders

Check the go to Errors While Importing POS Data

If you check the cashup table in browser's local storage, you could observe there are two records
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0040387RR19Q1.2 closed migueldejuana Two cash ups in local storage if the backoffice session is closed during the cash up 
depends on backport 0040388RR18Q4.3 closed migueldejuana Two cash ups in local storage if the backoffice session is closed during the cash up 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-14 12:11ngarciaNew Issue
2019-03-14 12:11ngarciaAssigned To => Retail
2019-03-14 12:11ngarciaResolution time => 1554328800
2019-03-14 12:11ngarciaTriggers an Emergency Pack => No
2019-03-14 12:11ngarciaIssue Monitored: networkb
2019-03-14 22:00rafarodaIssue Monitored: rafaroda
2019-03-15 08:01hgbotCheckin
2019-03-15 08:01hgbotNote Added: 0110449
2019-03-15 08:01hgbotStatusnew => resolved
2019-03-15 08:01hgbotResolutionopen => fixed
2019-03-15 08:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f88298391cd54416523404d8fc4cd12a1d359a7b [^]
2019-03-15 08:29migueldejuanaCategorySessions => Web POS
2019-03-15 08:29migueldejuanaAssigned ToRetail => migueldejuana
2019-03-15 08:29migueldejuanaStatusresolved => new
2019-03-15 08:29migueldejuanaResolutionfixed => open
2019-03-15 08:31migueldejuanaStatusnew => scheduled
2019-03-15 08:31migueldejuanaStatusscheduled => resolved
2019-03-15 08:31migueldejuanaResolutionopen => fixed
2019-03-15 08:56migueldejuanaStatusresolved => new
2019-03-15 08:56migueldejuanaResolutionfixed => open
2019-03-15 08:57migueldejuanaStatusnew => scheduled
2019-03-15 08:57migueldejuanaStatusscheduled => resolved
2019-03-15 08:57migueldejuanaResolutionopen => fixed
2019-03-15 11:32guilleaerReview Assigned To => guilleaer
2019-03-15 11:32guilleaerStatusresolved => closed
2019-03-15 11:32guilleaerFixed in Version => RR19Q2
2019-03-20 16:59hgbotCheckin
2019-03-20 16:59hgbotNote Added: 0110517
2019-03-20 16:59hgbotStatusclosed => resolved
2019-03-20 16:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f88298391cd54416523404d8fc4cd12a1d359a7b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/47f0e1cebf4fcbf04a82a5d31a6f1b4b9db0d6e7 [^]
2019-03-21 07:18hgbotCheckin
2019-03-21 07:18hgbotNote Added: 0110520
2019-03-21 07:18hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/47f0e1cebf4fcbf04a82a5d31a6f1b4b9db0d6e7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4e2ea81efa1de46562b8be4255d130654f515c91 [^]
2019-03-21 07:18hgbotCheckin
2019-03-21 07:18hgbotNote Added: 0110521
2019-03-21 07:18hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4e2ea81efa1de46562b8be4255d130654f515c91 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ee4b1581f4ed55d8b6cf1b03166dbb4c6ed188e6 [^]
2019-03-21 10:04guilleaerStatusresolved => closed

Notes
(0110449)
hgbot   
2019-03-15 08:01   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f88298391cd54416523404d8fc4cd12a1d359a7b
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Mar 14 19:00:34 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f88298391cd54416523404d8fc4cd12a1d359a7b [^]

Fixed issue 0040379: Two cash ups in local storage if the backoffice session is closed during the cash up

- If we do not synchronize the cashup during cashup process (because we lost the session and we need to login again), the cashup is processed when we login again. If we have to synchronize a Cashup during the login we will create 2 new cashups. One because the login process creates one if there is not a Cashup not processed and another one created by the postProcessFunction which creates a new cashup after synchronizing a cashup.
Just avoid to create a new Cashup in postProcessFunction if we already habe created a new one.

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0110517)
hgbot   
2019-03-20 16:59   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 47f0e1cebf4fcbf04a82a5d31a6f1b4b9db0d6e7
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Mar 20 16:59:10 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/47f0e1cebf4fcbf04a82a5d31a6f1b4b9db0d6e7 [^]

Fixed issue 0040379: Two cash ups in local storage if the backoffice session is closed during the cash up

- Add a hook to be able to close till when synchronizing the cashup in the login process

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---
(0110520)
hgbot   
2019-03-21 07:18   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4e2ea81efa1de46562b8be4255d130654f515c91
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Mar 20 16:58:43 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4e2ea81efa1de46562b8be4255d130654f515c91 [^]

Fixed issue 0040379: Two cash ups in local storage if the backoffice session is closed during the cash up

- Add a hook to be able to close till when synchronizing the cashup in the login process

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0110521)
hgbot   
2019-03-21 07:18   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ee4b1581f4ed55d8b6cf1b03166dbb4c6ed188e6
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Mar 21 07:18:20 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ee4b1581f4ed55d8b6cf1b03166dbb4c6ed188e6 [^]

Fixed issue 0040379: Two cash ups in local storage if the backoffice session is closed during the cash up

- JSBeautifier

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---