Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040378Localization Pack: SpainAEAT 303public2019-03-14 11:092019-03-20 10:25
ReporterOpentix-Test 
Assigned ToOpentix-Test 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket
OBNetwork customer
Regression introduced in release
Summary0040378: Tax Report 303 2019 - Delete line feed
DescriptionTax Report 303 2019 - Delete line feed
Steps To Reproduce1. Go to tax report launcher
2. Generate file. Period: february or 1T
3. Open file
4. Verify line feed
Proposed SolutionThe expected file format is a plain text file but there is a line feed (there must not be a line break)
Additional Information
TagsNo tags attached.
Relationships
Attached Filesxlsx DR303e19v10_10.xlsx (298,226) 2019-03-18 09:15
https://issues.openbravo.com/file_download.php?file_id=12756&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-03-14 11:09Opentix-TestNew Issue
2019-03-14 11:09Opentix-TestAssigned To => Opentix-Test
2019-03-14 11:21Opentix-TestSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18465#r18465
2019-03-14 11:21Opentix-TestProposed Solution updated
2019-03-14 11:25Opentix-TestProposed Solution updated
2019-03-14 16:19ivancaceIssue Monitored: ivancace
2019-03-15 12:26psanjuanSeveritycritical => major
2019-03-15 12:26psanjuanProposed Solution updated
2019-03-15 12:26psanjuanStatusnew => scheduled
2019-03-15 12:27psanjuanNote Added: 0110456
2019-03-15 12:40psanjuanTypefeature request => defect
2019-03-18 09:15Opentix-TestFile Added: DR303e19v10_10.xlsx
2019-03-20 10:23hgbotCheckin
2019-03-20 10:23hgbotNote Added: 0110506
2019-03-20 10:23hgbotStatusscheduled => resolved
2019-03-20 10:23hgbotResolutionopen => fixed
2019-03-20 10:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat303.es/rev/4a503f8d6cc3a8e65767e0c40e3e383c22bd020c [^]
2019-03-20 10:24hgbotCheckin
2019-03-20 10:24hgbotNote Added: 0110507
2019-03-20 10:25vmromanosReview Assigned To => vmromanos
2019-03-20 10:25vmromanosNote Added: 0110508
2019-03-20 10:25vmromanosStatusresolved => closed

Notes
(0110456)
psanjuan   
2019-03-15 12:27   
As workaround delete last line.
(0110506)
hgbot   
2019-03-20 10:23   
Repository: erp/pmods/org.openbravo.module.aeat303.es
Changeset: 4a503f8d6cc3a8e65767e0c40e3e383c22bd020c
Author: Iñaki Monferrer Altava <imonferrer <at> opentix.es>
Date: Mon Mar 18 16:04:29 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat303.es/rev/4a503f8d6cc3a8e65767e0c40e3e383c22bd020c [^]

Fixed bug 40378: Tax Report 303 2019 - Delete line feed.
Deleted line feed at the end of the file.

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/module/aeat303/es/report/v2019/AEAT303Report2019.java
---
(0110507)
hgbot   
2019-03-20 10:24   
Repository: erp/pmods/org.openbravo.module.aeat303.es
Changeset: eeea1f7901a07339ea35b8a0b113cc632ad5642f
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Mar 20 10:22:23 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat303.es/rev/eeea1f7901a07339ea35b8a0b113cc632ad5642f [^]

Related to issue 40378: code review improvements

Extracted logic to a private method.
Set CLFR length in a static variable to make sure the length is always properly calculated.
Use setLength() to avoid conversions from/to String

---
M src/org/openbravo/module/aeat303/es/report/v2019/AEAT303Report2019.java
---
(0110508)
vmromanos   
2019-03-20 10:25   
Code review + testing OK.

Fixed in Tax Report: Modelo 303 (Spain) 1.8.400 or above