Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040375Retail ModulesWeb POSpublic2019-03-13 17:502019-03-21 10:28
ReporterLeyre 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040375: Incorrectly defined 'selectMultiOrders' function
DescriptionIncorrectly defined 'selectMultiOrders' function
Steps To Reproduce1. Open pointofSale.js

2. selectMultiOrders: function (inSender, inEvent) {

     ....

     if (inEvent.callback()) {
        inEvent.callback();
      }

3. Correct?:

     if (inEvent.callback) {
        inEvent.callback();
      }
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-13 17:50LeyreNew Issue
2019-03-13 17:50LeyreAssigned To => Retail
2019-03-13 17:50LeyreResolution time => 1554242400
2019-03-13 17:50LeyreTriggers an Emergency Pack => No
2019-03-13 21:01jfrancesIssue Monitored: jfrances
2019-03-14 07:48ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-03-14 07:48ranjith_qualiantech_comStatusnew => scheduled
2019-03-14 12:00hgbotCheckin
2019-03-14 12:00hgbotNote Added: 0110435
2019-03-14 12:00hgbotStatusscheduled => resolved
2019-03-14 12:00hgbotResolutionopen => fixed
2019-03-14 12:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4500731e8876c5f55c54c8bfbab0c54e1ce73e63 [^]
2019-03-21 10:28jorge-garciaReview Assigned To => jorge-garcia
2019-03-21 10:28jorge-garciaNote Added: 0110534
2019-03-21 10:28jorge-garciaStatusresolved => closed
2019-03-21 10:28jorge-garciaFixed in Version => RR19Q2

Notes
(0110435)
hgbot   
2019-03-14 12:00   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4500731e8876c5f55c54c8bfbab0c54e1ce73e63
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Mar 14 16:29:49 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4500731e8876c5f55c54c8bfbab0c54e1ce73e63 [^]

Fixed issue 40375 : Validate callback in PostMultiOrder hook

* Removed wrong code in PostMultiOrder hook.
  Instead of validating the callback in if condition, it was calling the callback

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0110534)
jorge-garcia   
2019-03-21 10:28   
Code reviewed and tested