Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040372ModulesSAP Connectorpublic2019-03-13 15:002019-03-27 13:02
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tocaristu
Support ticket
OBNetwork customer
Regression introduced in release
Summary0040372: It should be possible to place idoc segment extensions at the end of the segment
DescriptionCurrently idocs extensions are placed right at the beginning of the segment. Some SAP Client has requested that they need the idoc extensions to be placed at the end of the segment.

It should be possible to define extension in both places, at the top and at the botton of the segment.
Steps To ReproduceIn an environment with the sap.ecc and sap.ecc.mapping installed:
- Configure the SAP module: http://wiki.openbravo.com/wiki/Module:SAP_ECC_Integration/UserGuide [^]
- Apply the attached patch
- Export a business partner
- Check that both extensions have been added to the E1WPP01 segment
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-13 15:00AugustoMauchNew Issue
2019-03-13 15:00AugustoMauchAssigned To => platform
2019-03-13 16:46hgbotCheckin
2019-03-13 16:46hgbotNote Added: 0110420
2019-03-13 16:46hgbotStatusnew => resolved
2019-03-13 16:46hgbotResolutionopen => fixed
2019-03-13 16:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sapecc/rev/bb0bd8d3cb5c1059d017e2a36d9f8ef5687aaee9 [^]
2019-03-13 17:09AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18457#r18457
2019-03-14 15:42AugustoMauchReview Assigned To => caristu
2019-03-27 09:17caristuAssigned Toplatform => AugustoMauch
2019-03-27 13:00hgbotCheckin
2019-03-27 13:00hgbotNote Added: 0110681
2019-03-27 13:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sapecc/rev/bb0bd8d3cb5c1059d017e2a36d9f8ef5687aaee9 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sapecc/rev/216b14177423cf5ceac3314bf5950358779d829d [^]
2019-03-27 13:02caristuNote Added: 0110682
2019-03-27 13:02caristuStatusresolved => closed

Notes
(0110420)
hgbot   
2019-03-13 16:46   
Repository: erp/pmods/org.openbravo.service.integration.sapecc
Changeset: bb0bd8d3cb5c1059d017e2a36d9f8ef5687aaee9
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Mar 13 16:45:55 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sapecc/rev/bb0bd8d3cb5c1059d017e2a36d9f8ef5687aaee9 [^]

Fixes issue 40372: It is possible to place idoc extension at the end of segment

Before this changeset it was only possible to place an idoc extension at the beginning of a segment.

Now it is possible to place both right at the beginning of the segment, or just before the segment ends.

The way to specify whether an extension goes at the beginning or at the end is by giving a different value
to the @IdocType annotation in the idoc component.

Example, to define an extension for the E1WPP01 segment of the WP_PER idoc, the following annotation should be used:

@IdocType("E1WPP01_EXTENSION")

And to place the extension right before the segment ends:

@IdocType("E1WPP01_BOTTOM_EXTENSION")

---
M src-test/data/idocExampleWithHooks.xml
M src/org/openbravo/service/integration/sapecc/mapping/templates/IdocHookGenerator.java
---
(0110681)
hgbot   
2019-03-27 13:00   
Repository: erp/pmods/org.openbravo.service.integration.sapecc
Changeset: 216b14177423cf5ceac3314bf5950358779d829d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Mar 27 12:59:51 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sapecc/rev/216b14177423cf5ceac3314bf5950358779d829d [^]

Fixes issue 40372: Applies code review comments

The following changes have been done:
- Copyright year has been updated
- Class Javadoc has been updated to include new idoc hook
- Duplicated trim() of string has been removed

---
M src/org/openbravo/service/integration/sapecc/mapping/templates/IdocHookGenerator.java
---
(0110682)
caristu   
2019-03-27 13:02   
Reviewed