Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0040362 | Retail Modules | Web POS | public | 2019-03-12 16:10 | 2019-03-29 10:16 |
|
| Reporter | psanjuan | |
| Assigned To | ranjith_qualiantech_com | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 30 | OS Version | Openbravo Appliance 14.04 |
| Product Version | | |
| Target Version | | Fixed in Version | RR19Q2 | |
| Merge Request Status | |
| Review Assigned To | jorge-garcia |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0040362: Payment plan do not properly created for an invoice related to a prepaid POS order, invoiced by the cash up |
| Description | Payment plan do not properly created for an invoice related to a prepaid POS order, invoiced by the cash up |
| Steps To Reproduce | Set up Channel Touchpoint type as shown below:
- Group Orders in one invoice = NO
- Generate Invoice for Orders = NO
- Allow prepayments and partial payments = YES.
In Openbravo Web POS do a cash up so no pending order is left.
Create a new order for Arturo Montoro. Make sure Invoice is not check.
Select 2 units of Avalanche Transceiver product.
Prepay 150.00
Enter approval credentials and approve.
Run Cash up process.
Go to Openbravo backoffice, sales order window.
Verify that sales order payment plan tab show a received amount = 150.00, therefore outstanding amount = 151.00
Go to the corresponding sales invoice and verify that it is shown as Payment Complete = YES.
Navigate to the payment and check that received amount = 301.00, and outstanding amount = 0.00. This is not correct.
See image attached.
|
| Proposed Solution | Payment Plan info needs to take into account sales invoice payment details. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  Issue_40362.jpg (69,044) 2019-03-12 16:11
https://issues.openbravo.com/file_download.php?file_id=12738&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2019-03-12 16:10 | psanjuan | New Issue | |
| 2019-03-12 16:10 | psanjuan | Assigned To | => Retail |
| 2019-03-12 16:10 | psanjuan | Triggers an Emergency Pack | => No |
| 2019-03-12 16:11 | psanjuan | File Added: Issue_40362.jpg | |
| 2019-03-12 16:17 | psanjuan | Summary | Payment paln do not properly created in case of an invoice related to a prepaid POS order, invoiced by the cash up => Payment plan do not properly created for an invoice related to a prepaid POS order, invoiced by the cash up |
| 2019-03-12 16:17 | psanjuan | Description Updated | bug_revision_view_page.php?rev_id=18432#r18432 |
| 2019-03-20 10:58 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2019-03-20 10:58 | ranjith_qualiantech_com | Status | new => scheduled |
| 2019-03-21 09:08 | hgbot | Checkin | |
| 2019-03-21 09:08 | hgbot | Note Added: 0110526 | |
| 2019-03-21 09:08 | hgbot | Status | scheduled => resolved |
| 2019-03-21 09:08 | hgbot | Resolution | open => fixed |
| 2019-03-21 09:08 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b685ea9e97ceefd74a0c74f64dd15b4669fb9ed9 [^] |
| 2019-03-21 09:08 | hgbot | Checkin | |
| 2019-03-21 09:08 | hgbot | Note Added: 0110527 | |
| 2019-03-21 11:19 | asiermartirena | Note Added: 0110536 | |
| 2019-03-21 11:19 | asiermartirena | Status | resolved => new |
| 2019-03-21 11:19 | asiermartirena | Resolution | fixed => open |
| 2019-03-22 09:56 | ranjith_qualiantech_com | Status | new => scheduled |
| 2019-03-22 10:16 | hgbot | Checkin | |
| 2019-03-22 10:16 | hgbot | Note Added: 0110575 | |
| 2019-03-22 12:05 | ranjith_qualiantech_com | Status | scheduled => resolved |
| 2019-03-22 12:05 | ranjith_qualiantech_com | Resolution | open => fixed |
| 2019-03-29 09:19 | jorge-garcia | Review Assigned To | => jorge-garcia |
| 2019-03-29 10:16 | jorge-garcia | Note Added: 0110919 | |
| 2019-03-29 10:16 | jorge-garcia | Status | resolved => closed |
| 2019-03-29 10:16 | jorge-garcia | Fixed in Version | => RR19Q2 |
|
Notes |
|
|
(0110526)
|
|
hgbot
|
|
2019-03-21 09:08
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b685ea9e97ceefd74a0c74f64dd15b4669fb9ed9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Mar 21 13:37:26 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b685ea9e97ceefd74a0c74f64dd15b4669fb9ed9 [^]
Fixed issue 40362 : Update Invoice Payment Schedule amounts after cashup
* Update Invoice Due Amount and Days till due based on Payment schedule
* If invoice amount is zero, payment schedule should be deleted
---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
---
|
|
|
|
(0110527)
|
|
hgbot
|
|
2019-03-21 09:08
|
|
Repository: tools/automation/pi-mobile
Changeset: b872a59e6a5d29e8dd397795a36b6cf29718efa3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Mar 21 13:25:34 2019 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b872a59e6a5d29e8dd397795a36b6cf29718efa3 [^]
Verifies issue 40362 : Added Test 'I40362_VerifyPaymentScheduleOnCashup'
---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/prepaymentsAndInvoiceTerms/I40362_VerifyPaymentScheduleOnCashup.java
---
|
|
|
|
|
|
Just one little comment when calculating the paid amount for the invoice. Now, it is calculated summing the psd that doesn't have payment details, which is correct, but is necessary to take into account if the payment has already been deposited. Check the InvoiceUtils.java class. It has a 'isPaidStatus' method that checks this. Do exactly the same, in addition to compare if there are payment details call also to this function. You can move the function to the POSUtils.java class. |
|
|
|
(0110575)
|
|
hgbot
|
|
2019-03-22 10:16
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 173b650a548a729f2c41b67a63024dc2fc9eaaf1
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Mar 22 14:45:54 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/173b650a548a729f2c41b67a63024dc2fc9eaaf1 [^]
Related to issue 40362 : Receipt Payment should be validated with Payment Status before adding to Invoice payment schedule
* When doing cashup, to update invoice payment schedule amounts, payments should be validated with Payment status
---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/utility/InvoiceUtils.java
---
|
|
|
|
(0110919)
|
|
jorge-garcia
|
|
2019-03-29 10:16
|
|
|