Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040358Openbravo ERPA. Platformpublic2019-03-12 11:452019-03-28 14:56
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040358: use bind-parameters in ImportEntryManager
DescriptionUse bind-parameter for data type in ImportEntryManager.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-12 11:45alostaleNew Issue
2019-03-12 11:45alostaleAssigned To => alostale
2019-03-12 11:45alostaleModules => Core
2019-03-12 11:45alostaleTriggers an Emergency Pack => No
2019-03-12 11:45alostaleRelationship addedblocks 0038136
2019-03-12 11:46alostaleReview Assigned To => caristu
2019-03-12 12:04hgbotCheckin
2019-03-12 12:04hgbotNote Added: 0110378
2019-03-12 12:04hgbotStatusnew => resolved
2019-03-12 12:04hgbotResolutionopen => fixed
2019-03-12 12:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/71917938577881c46f262ae5ed5953b580daf423 [^]
2019-03-12 12:04hgbotCheckin
2019-03-12 12:04hgbotNote Added: 0110379
2019-03-22 10:01caristuNote Added: 0110574
2019-03-22 10:01caristuStatusresolved => closed
2019-03-22 10:01caristuFixed in Version => 3.0PR19Q2
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110864
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110865

Notes
(0110378)
hgbot   
2019-03-12 12:04   
Repository: erp/devel/pi
Changeset: 71917938577881c46f262ae5ed5953b580daf423
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Mar 12 11:46:37 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/71917938577881c46f262ae5ed5953b580daf423 [^]

fixed issue 40358: use bind-parameters in ImportEntryManager for type of data

---
M src/org/openbravo/service/importprocess/ImportEntryManager.java
---
(0110379)
hgbot   
2019-03-12 12:04   
Repository: erp/devel/pi
Changeset: 92a2f9f50e21287328142c245879c207805d886b
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Mar 12 11:59:39 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/92a2f9f50e21287328142c245879c207805d886b [^]

related to issue 40358: code clean up

  * Query String is now constant
  * Write the full query without concatenating properties makes it more readable
  * Using scrollable as AutoCloseable

---
M src/org/openbravo/service/importprocess/ImportEntryManager.java
---
(0110574)
caristu   
2019-03-22 10:01   
Reviewed
(0110864)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110865)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test