Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040351Retail ModulesStoreServerpublic2019-03-11 17:182019-03-14 15:44
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040351: Allow syncing of batches from cs to ss also during TOF phase
DescriptionCurrently when there is data to be synced from central to then this is only allowed in either of the two cases:
- the store is in ON status, or
- for all other states, there is no data pending to sync from ss-->cs

This is to strict as also during TOF phase we should allow syncing from cs to ss. Otherwise a sync error can be created during TOF as we prevent syncing by throwing an exception.
Steps To ReproduceIt can be difficult to reproduce. The case which should be allowed is:
- store in TOF
- data pending to sync from ss-->cs
- data pending to sync from cs-->ss

The last should be allowed.
Proposed SolutionThe change is in this line [1], also allow replication from cs-->ss in all cases if state is TOF.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/tip/src/org/openbravo/replication/symmetricds/extensions/OfflineIncomingSynchronizationPreventer.java#l71 [^]
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-11 17:18mtaalNew Issue
2019-03-11 17:18mtaalAssigned To => mtaal
2019-03-11 17:18mtaalOBNetwork customer => No
2019-03-11 17:18mtaalTriggers an Emergency Pack => No
2019-03-11 20:58hgbotCheckin
2019-03-11 20:58hgbotNote Added: 0110360
2019-03-12 08:54hgbotCheckin
2019-03-12 08:54hgbotNote Added: 0110370
2019-03-12 08:54hgbotStatusnew => resolved
2019-03-12 08:54hgbotResolutionopen => fixed
2019-03-12 08:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/248c2740632451d21322954920698423526272c1 [^]
2019-03-12 09:08mtaalReview Assigned To => AugustoMauch
2019-03-14 15:44AugustoMauchNote Added: 0110443
2019-03-14 15:44AugustoMauchStatusresolved => closed

Notes
(0110360)
hgbot   
2019-03-11 20:58   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: d1000b5536d1b4fb01da26f4d8bce3f6120baa2b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Mar 11 20:58:09 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/d1000b5536d1b4fb01da26f4d8bce3f6120baa2b [^]

Related to issue 40351: Allow syncing of batches from cs to ss also during TOF phase
Also allow syncing in TOF phase

---
M src/org/openbravo/replication/symmetricds/extensions/OfflineIncomingSynchronizationPreventer.java
---
(0110370)
hgbot   
2019-03-12 08:54   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 248c2740632451d21322954920698423526272c1
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Mar 12 08:53:32 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/248c2740632451d21322954920698423526272c1 [^]

Fixes issue 40351: Allow syncing of batches from cs to ss also during TOF phase
Repeat the allow-offline check also within the TOF phase

---
M src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java
---
(0110443)
AugustoMauch   
2019-03-14 15:44   
Code reviewed and verified