Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040332Retail ModulesSessionspublic2019-03-06 16:462019-05-06 13:05
Reporteraaroncalero 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040332: [Sessions] Under specific circumstances OpenSessionPOS is called without the cashUpReportInformation parameter
DescriptionThere is a hook[1] in the sessions module that, under specific circumstances, is calling the OpenSessionsPOS process without the cashupReportInformation parameter, which is a mandatory parameter for the execution of the process.

When this happens, the Open till process fails and the till is not opened, and a record is created in the Errors While Importing POS Data window.

[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/file/tip/web/org.openbravo.retail.sessions/js/components/loginhook.js#l407 [^]
Steps To ReproduceThis specific execution of the process only happens when the object OB.UTIL.localStorage.getItem('pendingSessions') has data, which seems to happen if the OpenSessionsPOS has failed first (i.e. the system was offline or with heavy load).

1. In an environment with Sessions installed, login in WebPOS and do the Cash Up process. The system will automatically logout in the end of the process.
2. Login in backend and configure the Web POS Synchronized mode preference.
3. Login in WebPOS again. The Open till window will be shown.
4. Complete the Open Till process. The server call needs to end with error, so the errorCallback is executed and the pendingSessions object is created.
5. The login process will continue normally, but when the next runSyncProcess is executed (which happens automatically at the end of the login process), the pending sessions hook will execute and the process will fail in the server
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 0041830 closed ranjith_qualiantech_com Javascript error when opening till in pos 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-06 16:46aaroncaleroNew Issue
2019-03-06 16:46aaroncaleroAssigned To => Retail
2019-03-06 16:46aaroncaleroOBNetwork customer => Gold
2019-03-06 16:46aaroncaleroResolution time => 1553036400
2019-03-06 16:46aaroncaleroTriggers an Emergency Pack => No
2019-03-06 17:45rqueraltaAssigned ToRetail => rqueralta
2019-03-06 18:29aaroncaleroSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18396#r18396
2019-04-29 15:23ranjith_qualiantech_comAssigned Torqueralta => ranjith_qualiantech_com
2019-04-30 10:00ranjith_qualiantech_comStatusnew => scheduled
2019-04-30 11:39hgbotCheckin
2019-04-30 11:39hgbotNote Added: 0111379
2019-04-30 14:39ranjith_qualiantech_comStatusscheduled => resolved
2019-04-30 14:39ranjith_qualiantech_comResolutionopen => fixed
2019-05-06 13:04migueldejuanaReview Assigned To => migueldejuana
2019-05-06 13:04migueldejuanaNote Added: 0111498
2019-05-06 13:04migueldejuanaStatusresolved => closed
2019-09-18 08:50ranjith_qualiantech_comRelationship addedcauses 0041830

Notes
(0111379)
hgbot   
2019-04-30 11:39   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 21eb02dd01b306d9a986224e1a6a2c7f6659fd36
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Apr 30 15:09:17 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/21eb02dd01b306d9a986224e1a6a2c7f6659fd36 [^]

Related to issue 40332 : CashUp Report Information should be processed when OpenSessionPOS is called

* When OpenSessionPOS process is failed, pendingSessions should be updated with cashUpReportInformation.
  So it will resync, cashUpReportInformation will be processed in OpenSessionPOS process

---
M src/org/openbravo/retail/sessions/OpenSessionPOS.java
M web/org.openbravo.retail.sessions/js/components/loginhook.js
M web/org.openbravo.retail.sessions/js/countcash/countcash-model.js
---
(0111498)
migueldejuana   
2019-05-06 13:04   
Reviewed