Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040326Retail ModulesWeb POSpublic2019-03-06 09:292019-06-03 23:58
Reportersamuel_nicuesa 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerGold
Support ticket8480
Regression level
Regression date2019-03-27
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040326: Doing cash up Delete all button is not working properly.
DescriptionIf you bring all tickets and you click delete button the receipts are deleted in the original user but not in the current user.
Steps To Reproduce[POS] Vallblanca

-Do login user vallblanca

-Do a ticket and pay it

-Do another ticket, add one product

-Press lock screen

[POS] Demouser

-Do login with another user (demouser)

-Create one ticket and pay it

-Do cash up

-Click bring all button

-Click Delete all button

-Finish cash up

[POS] Vallblanca

-Do login user Vallblanca

-The ticket has been removed for this user (It is correct)

[POS] Demouser

-Do login user demouser

-The receipt has not been removed for this user (It is not correct)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040477 closed rqueralta Cancel Button removes tickets doing the cash up from the previous day. 
Attached Filespatch issue 40326 source posterminal.patch (1,876) 2019-03-07 14:39
https://issues.openbravo.com/file_download.php?file_id=12719&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-03-06 09:29samuel_nicuesaNew Issue
2019-03-06 09:29samuel_nicuesaAssigned To => Retail
2019-03-06 09:29samuel_nicuesaOBNetwork customer => Gold
2019-03-06 09:29samuel_nicuesaSupport ticket => 8480
2019-03-06 09:29samuel_nicuesaRegression date => 2019-03-27
2019-03-06 09:29samuel_nicuesaTriggers an Emergency Pack => No
2019-03-06 10:06rafarodaIssue Monitored: rafaroda
2019-03-06 11:00ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-03-06 11:00ranjith_qualiantech_comStatusnew => scheduled
2019-03-07 14:39ranjith_qualiantech_comFile Added: issue 40326 source posterminal.patch
2019-03-12 06:17hgbotCheckin
2019-03-12 06:17hgbotNote Added: 0110364
2019-03-12 06:17hgbotStatusscheduled => resolved
2019-03-12 06:17hgbotResolutionopen => fixed
2019-03-12 06:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/52953a86d9e19abc3277cfe4ac7ae50d4008eaf8 [^]
2019-03-14 10:31jorge-garciaNote Added: 0110432
2019-03-14 10:31jorge-garciaStatusresolved => new
2019-03-14 10:31jorge-garciaResolutionfixed => open
2019-03-14 10:42hgbotCheckin
2019-03-14 10:42hgbotNote Added: 0110433
2019-03-14 10:49ranjith_qualiantech_comStatusnew => scheduled
2019-03-18 06:43hgbotCheckin
2019-03-18 06:43hgbotNote Added: 0110468
2019-03-18 06:43hgbotStatusscheduled => resolved
2019-03-18 06:43hgbotResolutionopen => fixed
2019-03-18 06:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/52953a86d9e19abc3277cfe4ac7ae50d4008eaf8 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9241e07c6d1250c5c0b59b130072b43c033d964c [^]
2019-03-26 16:43samuel_nicuesaNote Added: 0110666
2019-03-28 14:21rafarodaRelationship addedrelated to 0040477
2019-03-29 09:09jorge-garciaReview Assigned To => jorge-garcia
2019-03-29 09:09jorge-garciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18561#r18561
2019-03-29 09:14jorge-garciaReview Assigned Tojorge-garcia => guilleaer
2019-03-29 14:02guilleaerStatusresolved => closed
2019-03-29 14:02guilleaerFixed in Version => RR19Q2
2019-06-03 23:58hgbotCheckin
2019-06-03 23:58hgbotNote Added: 0112353

Notes
(0110364)
hgbot   
2019-03-12 06:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 52953a86d9e19abc3277cfe4ac7ae50d4008eaf8
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Mar 12 10:47:00 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/52953a86d9e19abc3277cfe4ac7ae50d4008eaf8 [^]

Fixed issue 40326 : Receipts from other sessions should be deleted while doing cashup

* While doing cashup, Other Session receipts will not be added to OB.MobileApp.model.orderList.
  So receipt createdBy and session user is same, receipt should be removed from orderList and local db
  else receipt should be only removed from local db

---
M src/org/openbravo/retail/posterminal/PaidReceiptProperties.java
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0110432)
jorge-garcia   
2019-03-14 10:31   
This change causes cross store test to fail. Test failing are:
CrossStorePaymentInvoice
CrossStorePaymentLayaway
CrossStorePaymentMultiple
CrossStorePaymentPartial
CrossStorePaymentReceipt
CrossStoreUIOpenReceipt
SingleStoreUIOpenReceipt
CrossStorePaymentInvoice
CrossStorePaymentLayaway
CrossStorePaymentMultiple
CrossStorePaymentPartial
CrossStorePaymentReceipt
CrossStoreUIOpenReceipt
SingleStoreUIOpenReceipt

Check it out following this link:
http://ci.openbravo.com/view/retail-qa/job/ret-qa-test-pgsql-suite8/2261/testReport/ [^]
(0110433)
hgbot   
2019-03-14 10:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fa5f8ec7bf5e7c29d684e0fa1e7cd5372ebe671c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Mar 14 15:11:31 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fa5f8ec7bf5e7c29d684e0fa1e7cd5372ebe671c [^]

Related to issue 40326 : Backed out changeset: 52953a86d9e1

---
M src/org/openbravo/retail/posterminal/PaidReceiptProperties.java
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0110468)
hgbot   
2019-03-18 06:43   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9241e07c6d1250c5c0b59b130072b43c033d964c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Mar 18 11:12:44 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9241e07c6d1250c5c0b59b130072b43c033d964c [^]

Fixed issue 40326 : Receipts from other sessions should be deleted while doing cashup

* While doing cashup, Other Session receipts will not be added to OB.MobileApp.model.orderList.
  So receipt session and pos session is same, receipt should be removed from orderList and local db
  else receipt should be only removed from local db

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0110666)
samuel_nicuesa   
2019-03-26 16:43   
If the line modified[1] is false then the receipt is not deleted. That happens on the else if. The delete for the receipt is done instead doing for the model.
Is that correct?


[1] if (orderList && receipt && receipt.get('session') === OB.MobileApp.model.get('session')) {
(0112353)
hgbot   
2019-06-03 23:58   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: cfc0af458f9587e0ad5705297cc791555846ccf5
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Mar 14 15:11:31 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cfc0af458f9587e0ad5705297cc791555846ccf5 [^]

Related to issue 40326 : Backed out changeset: 52953a86d9e1

---
M src/org/openbravo/retail/posterminal/PaidReceiptProperties.java
M web/org.openbravo.retail.posterminal/js/model/order.js
---