Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040308Openbravo ERPA. Platformpublic2019-03-04 12:282019-04-05 09:53
Reportercaristu 
Assigned Tocaristu 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040308: Improvements for the Openbravo Eclipse project
DescriptionThe Openbravo Eclipse project requires some improvements:

- Instead of importing the servlet api using the Tomcat 7 server, the servlet-api library can be directly included in the classpath. This applies both for the openbravo and OpenbravoTest projects. (See attached tomcat-servlet-api.png).

- The "Deployment Assembly" (See attached deployment-assembly.png) of the openbravo project contains a wrong reference to OpenbravoCore. It also references the classes of the OpenbravoTest project that causes the src-test folder to be unnecessarily deployed as a "classes folder" in the "Web App Libraries" section. (See attached src-test-web-app-lib.png).

- openbravo project depends on OpenbravoTrl and OpenbravoWad. It should depend just in OpenbravoCore project. (See attached required-projects.png)

Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040531 closed alostale remove js.jar from eclipse project classpath 
blocks design defect 0032688 acknowledged Triage Platform Base remove unused resources 
Attached Filespng src-test-web-app-lib.png (179,001) 2019-03-04 12:31
https://issues.openbravo.com/file_download.php?file_id=12698&type=bug
png

png required-projects.png (80,695) 2019-03-04 12:34
https://issues.openbravo.com/file_download.php?file_id=12699&type=bug
png

png tomcat-servlet-api.png (146,593) 2019-03-04 12:36
https://issues.openbravo.com/file_download.php?file_id=12700&type=bug
png

png deployment-assembly.png (102,954) 2019-03-04 12:44
https://issues.openbravo.com/file_download.php?file_id=12701&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2019-03-04 12:28caristuNew Issue
2019-03-04 12:28caristuAssigned To => caristu
2019-03-04 12:28caristuModules => Core
2019-03-04 12:28caristuTriggers an Emergency Pack => No
2019-03-04 12:28caristuSummaryImprovements for Openbravo Eclipse project => Improvements for the Openbravo Eclipse project
2019-03-04 12:31caristuFile Added: src-test-web-app-lib.png
2019-03-04 12:32caristuDescription Updatedbug_revision_view_page.php?rev_id=18374#r18374
2019-03-04 12:34caristuFile Added: required-projects.png
2019-03-04 12:34caristuDescription Updatedbug_revision_view_page.php?rev_id=18375#r18375
2019-03-04 12:36caristuFile Added: tomcat-servlet-api.png
2019-03-04 12:36caristuDescription Updatedbug_revision_view_page.php?rev_id=18376#r18376
2019-03-04 12:44caristuDescription Updatedbug_revision_view_page.php?rev_id=18377#r18377
2019-03-04 12:44caristuFile Added: deployment-assembly.png
2019-03-04 16:18caristuDescription Updatedbug_revision_view_page.php?rev_id=18382#r18382
2019-03-04 16:58hgbotCheckin
2019-03-04 16:58hgbotNote Added: 0110204
2019-03-04 16:58hgbotStatusnew => resolved
2019-03-04 16:58hgbotResolutionopen => fixed
2019-03-04 16:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c5133206f8cebd856954f9b36f0079c0e4739743 [^]
2019-03-04 17:08caristuReview Assigned To => alostale
2019-03-08 10:09hgbotCheckin
2019-03-08 10:09hgbotNote Added: 0110305
2019-03-08 10:15alostaleNote Added: 0110306
2019-03-08 10:15alostaleStatusresolved => closed
2019-03-08 10:15alostaleFixed in Version => 3.0PR19Q2
2019-03-14 16:19hgbotCheckin
2019-03-14 16:19hgbotNote Added: 0110444
2019-03-15 08:32hgbotCheckin
2019-03-15 08:32hgbotNote Added: 0110450
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110844
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110855
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110869
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110870
2019-04-05 09:24alostaleRelationship addedrelated to 0040531
2019-04-05 09:53alostaleRelationship addedblocks 0032688

Notes
(0110204)
hgbot   
2019-03-04 16:58   
Repository: erp/devel/pi
Changeset: c5133206f8cebd856954f9b36f0079c0e4739743
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Mar 04 16:41:53 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c5133206f8cebd856954f9b36f0079c0e4739743 [^]

fixes issue 40308: Improvements for the Openbravo Eclipse project

  - Include servlet-api in the classpath of the main and src-test projects instead of adding it through Tomcat 7 libraries
  - Set OpenbravoCore as required project
  - Remove OpenbravoTrl and OpenbravoWad as required projects
  - Remove src-test and broken OpenbravoCore entry from the Web Deployment Assembly

---
M .classpath.template
M .settings/org.eclipse.wst.common.component.template
M src-test/.classpath.template
---
(0110305)
hgbot   
2019-03-08 10:09   
Repository: erp/devel/pi
Changeset: e77b49e6d86d258be33ca91180ade95af4d58535
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Mar 08 10:08:46 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e77b49e6d86d258be33ca91180ade95af4d58535 [^]

related to issue 40308: rearranged openbravo core position

  Having OpenbravoCore project on top of WebContent libraries, which includes
  openbravo-core.jar, allows to debug it and changed code to prevail over the
  one already compiled in the jar.

---
M .classpath.template
---
(0110306)
alostale   
2019-03-08 10:15   
reviewed + tested
(0110444)
hgbot   
2019-03-14 16:19   
Repository: erp/devel/pi
Changeset: 9a9b31642c6fbac8ac8c77de2801efcb40afb854
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Mar 14 16:18:07 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9a9b31642c6fbac8ac8c77de2801efcb40afb854 [^]

related to issue 40308: OpenbravoWAD is not required by OpenbravoTest project

---
M src-test/.classpath.template
---
(0110450)
hgbot   
2019-03-15 08:32   
Repository: erp/devel/pi
Changeset: 04228a5d2a51b7b8e0ad3da5526cb8dbb5f75c8f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Mar 15 08:32:02 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/04228a5d2a51b7b8e0ad3da5526cb8dbb5f75c8f [^]

related to issue 40308: removed Openbravo project web app libs from test

  As they don't need to be directly defined because they are indirectly through
  openbravo project dependency.

---
M src-test/.classpath.template
---
(0110844)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110855)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110869)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110870)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test