Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040299Retail ModulesWeb POSpublic2019-02-28 18:342019-03-18 15:38
Reporteraaroncalero 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040299: ExternalOrderLoader marks order lines as delivered during the Create step
DescriptionWhen the ExternalOrderLoader is invoked, it is possible to specify which step of the Order creating needs to be executed (creation, payment, delivery or all of them).
When the step is set to Create, the generated order lines are marked as delivered (delivered quantity = ordered quantity) although shipments are not created.
Steps To ReproduceUsing the standard Retail sample data and the pi-mobile testing environment:
In the pi-mobile repository, find the file message-order-create-1.json, edit it, and change the step from "all" to "create".
From the RetailOrderLoaderTest.java test file, execute the testMinimalOrder() test.
Verify that the created order has it's two lines with delivered quantity = ordered quantity.


[1] src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-order-create-1.json
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files? issue_40299.export (5,206) 2019-03-04 09:25
https://issues.openbravo.com/file_download.php?file_id=12697&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-02-28 18:34aaroncaleroNew Issue
2019-02-28 18:34aaroncaleroAssigned To => Retail
2019-02-28 18:34aaroncaleroResolution time => 1552604400
2019-02-28 18:34aaroncaleroTriggers an Emergency Pack => No
2019-02-28 19:01asiermartirenaFile Added: issue_40299.export
2019-03-04 08:50ranjith_qualiantech_comStatusnew => scheduled
2019-03-04 08:50ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-03-04 09:25asiermartirenaFile Deleted: issue_40299.export
2019-03-04 09:25asiermartirenaFile Added: issue_40299.export
2019-03-07 14:44hgbotCheckin
2019-03-07 14:44hgbotNote Added: 0110283
2019-03-07 14:44hgbotStatusscheduled => resolved
2019-03-07 14:44hgbotResolutionopen => fixed
2019-03-07 14:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8503e74b8484d420c0b8acce557ad11a475245c2 [^]
2019-03-08 10:15guillermogilReview Assigned To => guilleaer
2019-03-18 15:38guilleaerStatusresolved => closed
2019-03-18 15:38guilleaerFixed in Version => RR19Q2

Notes
(0110283)
hgbot   
2019-03-07 14:44   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8503e74b8484d420c0b8acce557ad11a475245c2
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Thu Mar 07 19:13:50 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8503e74b8484d420c0b8acce557ad11a475245c2 [^]

Fixed issue 40299 : ExternalOrderLoader marks order lines as delivered during the Create step

The property obposQtytodeliver must be set in the external order loader in order to set correctly the delivered quantities.
In case that the order is being created or paid, the quantity is taken from the delivered quantity or zero if there's not delivered quantity.
In case that the order is being delivered, the quantity set is the ordered quantity.
If the object was already sending the property, the value is maintained, allowing to have partial deliveries.
Added also the correct properties to be able to invoice and deliver when the order is synchronized due to the step ALL.

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---