Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040296Openbravo ERPA. Platformpublic2019-02-21 13:292019-03-08 10:47
Reportercaristu 
Assigned Tojarmendariz 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR18Q4.2Fixed in Version3.0PR18Q4.2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2018-02-18
Regression introduced in release3.0PR18Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/0b908a2c7f992827a230b06193ad7f8f9bd2ce9b [^]
Triggers an Emergency PackNo
Summary0040296: Responses from OB.RemoteCallManager calls are not handled if the Smartclient timeout is fired
DescriptionResponses from OB.RemoteCallManager calls are not handled if the Smartclient timeout is fired . This is a change in the behavior introduced with the following changeset[1].

Before that change the timeout error was not being properly handled causing the thrown of JS errors in the console. Despite this errors, the response was being handled by Smatclient.

Now the timeout error is being handled, showing the message in the UI. But seems that this causes the request response to be ignored when it finishes.

[1] https://code.openbravo.com/erp/devel/pi/rev/0b908a2c7f992827a230b06193ad7f8f9bd2ce9b#l1.37 [^]
Steps To ReproduceArtificial test:

1) Open the [Sales Order] window
2) Create a new sales order with at least one line and book it
3) Open the Add Payment window
4) Using the dev tools console reduce the timeout to be able to simulate the timeout expiration: isc.RPCManager.defaultTimeout = 1000
5) Put a breakpoint in the AddPaymentActionHandler class
6) In the client the message information about the timeout expiration appears
7) Step over the breakpoint and finish the execution of the handler --> note that the response message from the action handler does not apper

Before the mentioned changeset, the behavior was different:

1) The timeout message was not appearing (the error was thrown in the console instead)
2) The process pop-up was closed
3) The message from the action handler was shown properly in the header
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0040253 closed jarmendariz Responses from OB.RemoteCallManager calls are not handled if the Smartclient timeout is fired 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-02-28 17:10jarmendarizTypedefect => backport
2019-02-28 17:10jarmendarizTarget Version => 3.0PR18Q4.2
2019-03-01 09:43hgbotCheckin
2019-03-01 09:43hgbotNote Added: 0110145
2019-03-01 09:43hgbotStatusscheduled => resolved
2019-03-01 09:43hgbotResolutionopen => fixed
2019-03-01 09:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q4.3/rev/a343fa7f1564004e16f2b92b3ec9a8a3de8db61f [^]
2019-03-08 10:47caristuReview Assigned To => caristu
2019-03-08 10:47caristuNote Added: 0110309
2019-03-08 10:47caristuStatusresolved => closed
2019-03-08 10:47caristuFixed in Version => 3.0PR18Q4.2

Notes
(0110145)
hgbot   
2019-03-01 09:43   
Repository: erp/backports/3.0PR18Q4.3
Changeset: a343fa7f1564004e16f2b92b3ec9a8a3de8db61f
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Thu Feb 28 10:53:54 2019 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q4.3/rev/a343fa7f1564004e16f2b92b3ec9a8a3de8db61f [^]

Fixed issue 40296: RemoteCallManager response not handled when timemout is fired.

Removed result sanitizing in RPCManager. This makes timeout message appears but
also marks the request as complete and the actual response is not processed when
it arrives.

---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0110309)
caristu   
2019-03-08 10:47   
Code reviewed + tested OK.