Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040287Retail ModulesStoreServerpublic2019-02-28 09:062019-03-27 20:17
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040287: API Change due to removal of internal/technical column in mobile server definition
DescriptionThe mobile server definition has a column 'offline_incoming_errors' which is used to keep track if there were (past-tense) incoming sync errors for a store when it went offline.

It shows that we don't need to keep this flag as we prevent the store to go offline in all cases when there are incoming errors. So the store won't go offline and there is no need to keep this flag.

So the idea is to remove this column.

This column/flag is very internal and not shown in the user interface. The risk of this api-change is very small.
Steps To ReproduceSee Description
Proposed SolutionSee Description
Additional Information
TagsApproved
Relationships
depends on design defect 0040219 closed mtaal Simplify check on offline with sync errors or delta age, show delta age in mobile server 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-02-28 09:06mtaalNew Issue
2019-02-28 09:06mtaalAssigned To => dmitry_mezentsev
2019-02-28 09:06mtaalOBNetwork customer => No
2019-02-28 09:06mtaalTriggers an Emergency Pack => No
2019-02-28 09:07mtaalDescription Updatedbug_revision_view_page.php?rev_id=18367#r18367
2019-02-28 13:39dmitry_mezentsevTag Attached: Approved
2019-02-28 13:39dmitry_mezentsevAssigned Todmitry_mezentsev => mtaal
2019-03-04 15:21hgbotCheckin
2019-03-04 15:21hgbotNote Added: 0110195
2019-03-04 15:21hgbotStatusnew => resolved
2019-03-04 15:21hgbotResolutionopen => fixed
2019-03-04 15:21hgbotFixed in SCM revision => http://code.openbravo.com/retail/api-checks-retail/rev/0a4f9bfa2cc2372abee337f96a1525fc06068fc5 [^]
2019-03-04 15:25mtaalRelationship addeddepends on 0040219
2019-03-04 16:56mtaalNote Added: 0110202
2019-03-04 16:56mtaalStatusresolved => new
2019-03-04 16:56mtaalResolutionfixed => open
2019-03-04 16:56hgbotCheckin
2019-03-04 16:56hgbotNote Added: 0110203
2019-03-04 17:37hgbotCheckin
2019-03-04 17:37hgbotNote Added: 0110206
2019-03-04 17:37hgbotStatusnew => resolved
2019-03-04 17:37hgbotResolutionopen => fixed
2019-03-04 17:37hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/api-checks-retail/rev/0a4f9bfa2cc2372abee337f96a1525fc06068fc5 [^] => http://code.openbravo.com/retail/api-checks-retail/rev/b72cc121a7a1ad75a72cc28d5390290cf74487ad [^]
2019-03-04 23:07hgbotCheckin
2019-03-04 23:07hgbotNote Added: 0110214
2019-03-04 23:07hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/api-checks-retail/rev/b72cc121a7a1ad75a72cc28d5390290cf74487ad [^] => http://code.openbravo.com/retail/api-checks-retail/rev/8ac5c3d8adf271abebefcbbd138f9dd60a7c60eb [^]
2019-03-05 10:35hgbotCheckin
2019-03-05 10:35hgbotNote Added: 0110220
2019-03-11 21:01mtaalReview Assigned To => jorge-garcia
2019-03-26 09:35mtaalReview Assigned Tojorge-garcia => mtaal
2019-03-26 09:35mtaalNote Added: 0110646
2019-03-26 09:35mtaalStatusresolved => closed
2019-03-27 20:17hgbotCheckin
2019-03-27 20:17hgbotNote Added: 0110709

Notes
(0110195)
hgbot   
2019-03-04 15:21   
Repository: retail/api-checks-retail
Changeset: 0a4f9bfa2cc2372abee337f96a1525fc06068fc5
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Mar 04 15:21:32 2019 +0100
URL: http://code.openbravo.com/retail/api-checks-retail/rev/0a4f9bfa2cc2372abee337f96a1525fc06068fc5 [^]

Fixes issue 40287: API Change due to removal of internal/technical column in mobile server definition
Api change, removed a technical field which is not needed anymore

---
M java/reference/java.japi.gz
---
(0110202)
mtaal   
2019-03-04 16:56   
api check fails, will resolve when pushed
(0110203)
hgbot   
2019-03-04 16:56   
Repository: retail/api-checks-retail
Changeset: 02cf813a0b25063d1dc4e1e1bfc0e91f4d46e8e9
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Mar 04 16:56:31 2019 +0100
URL: http://code.openbravo.com/retail/api-checks-retail/rev/02cf813a0b25063d1dc4e1e1bfc0e91f4d46e8e9 [^]

Related to issue 40287: API Change due to removal of internal/technical column in mobile server definition
Backed out changeset 0a4f9bfa2cc2

---
M java/reference/java.japi.gz
---
(0110206)
hgbot   
2019-03-04 17:37   
Repository: retail/api-checks-retail
Changeset: b72cc121a7a1ad75a72cc28d5390290cf74487ad
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Mar 04 17:37:42 2019 +0100
URL: http://code.openbravo.com/retail/api-checks-retail/rev/b72cc121a7a1ad75a72cc28d5390290cf74487ad [^]

Fixes issue 40287: API Change due to removal of internal/technical column in mobile server definition

---
M java/reference/java.japi.gz
---
(0110214)
hgbot   
2019-03-04 23:07   
Repository: retail/api-checks-retail
Changeset: 8ac5c3d8adf271abebefcbbd138f9dd60a7c60eb
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Mar 04 23:07:18 2019 +0100
URL: http://code.openbravo.com/retail/api-checks-retail/rev/8ac5c3d8adf271abebefcbbd138f9dd60a7c60eb [^]

Fixes issue 40287: API Change due to removal of internal/technical column in mobile server definition

---
M java/reference/java.japi.gz
---
(0110220)
hgbot   
2019-03-05 10:35   
Repository: retail/api-checks-retail
Changeset: 3cc2a6a2b4085d9c5fc2f7a8f67d80b3c8d90b94
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Mar 05 10:35:19 2019 +0100
URL: http://code.openbravo.com/retail/api-checks-retail/rev/3cc2a6a2b4085d9c5fc2f7a8f67d80b3c8d90b94 [^]

Related to issue 40287: API Change due to removal of internal/technical column in mobile server definition
Also update the src-db changes

---
M model/modules/org.openbravo.mobile.core/src-db/database/model/tables/OBMOBC_SERVER_DEFINITION.xml
M model/modules/org.openbravo.mobile.core/src-db/database/sourcedata/AD_COLUMN.xml
M model/modules/org.openbravo.mobile.core/src-db/database/sourcedata/AD_ELEMENT.xml
---
(0110646)
mtaal   
2019-03-26 09:35   
reviewed
(0110709)
hgbot   
2019-03-27 20:17   
Repository: retail/api-checks-retail
Changeset: 73c94bb7ab211ebd232759044ce9b3891547bec7
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Mar 27 20:16:56 2019 +0100
URL: http://code.openbravo.com/retail/api-checks-retail/rev/73c94bb7ab211ebd232759044ce9b3891547bec7 [^]

Related to issue 40287: API Change due to removal of internal/technical column in mobile server definition
Removal of not needed columns

---
M model/modules/org.openbravo.mobile.core/src-db/database/model/tables/OBMOBC_SERVER_DEFINITION.xml
M model/modules/org.openbravo.mobile.core/src-db/database/sourcedata/AD_COLUMN.xml
M model/modules/org.openbravo.mobile.core/src-db/database/sourcedata/AD_ELEMENT.xml
---