Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040284Openbravo ERP04. Warehouse managementpublic2019-02-27 12:512019-12-31 10:51
Reporterfrancisco 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-03-22
Regression introduced in release3.0PR17Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/f840f08b67ec [^]
Triggers an Emergency PackNo
Summary0040284: Manage pre-reservation not possible
DescriptionWhen its done a pre-reservation, once it's done is not possible to manage.
It's not possible modify or eliminate.
Steps To Reproduce* In preference activate Enable Stock Reservation
* Create a purchase order Ex: Cerveza Ale 0.5L Qty:10
* Create a Sales order Ex: Cerveza Ale 0.5L QTY:5
* Go to the sales Order and click on manage reservation and modify some of the orders we have, the sale or the purchase
* Go again to manage reservation and it does not appear the purchase order
* Same is happening if you go to the Stock reservation window and click on the line, the purchase is not there so it is not possible modify or to eliminate the order
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00403223.0PR19Q1 closed AtulOpenbravo Manage pre-reservation not possible 
depends on backport 00403233.0PR18Q4.3 closed AtulOpenbravo Manage pre-reservation not possible 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-02-27 12:51franciscoNew Issue
2019-02-27 12:51franciscoAssigned To => Triage Finance
2019-02-27 12:51franciscoModules => Core
2019-02-27 12:51franciscoResolution time => 1553036400
2019-02-27 12:51franciscoTriggers an Emergency Pack => No
2019-02-27 12:58PracticsIssue Monitored: Practics
2019-02-27 15:11SandrahuguetAssigned ToTriage Finance => AtulOpenbravo
2019-03-04 19:34AtulOpenbravoStatusnew => scheduled
2019-03-05 14:42AtulOpenbravoRegression level => Production - Confirmed Stable
2019-03-05 14:42AtulOpenbravoRegression date => 2017-03-22
2019-03-05 14:42AtulOpenbravoRegression introduced in release => 3.0PR17Q2
2019-03-05 14:42AtulOpenbravoRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/f840f08b67ec [^]
2019-03-05 16:10AtulOpenbravoStatusscheduled => acknowledged
2019-03-05 16:11AtulOpenbravoStatusacknowledged => scheduled
2019-03-06 07:04AtulOpenbravoNote Added: 0110244
2019-03-06 16:01hgbotCheckin
2019-03-06 16:01hgbotNote Added: 0110259
2019-03-06 16:01hgbotStatusscheduled => resolved
2019-03-06 16:01hgbotResolutionopen => fixed
2019-03-06 16:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4eae47894e328b486388fe3de4a3ad18af203e7d [^]
2019-03-06 16:34SandrahuguetReview Assigned To => Sandrahuguet
2019-03-06 16:34SandrahuguetNote Added: 0110264
2019-03-06 16:34SandrahuguetStatusresolved => closed
2019-03-06 16:34SandrahuguetFixed in Version => 3.0PR19Q2
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110849
2019-12-31 10:51hgbotCheckin
2019-12-31 10:51hgbotNote Added: 0116585

Notes
(0110244)
AtulOpenbravo   
2019-03-06 07:04   
Test Plan
- In preference add Enable Stock Reservation = Yes for F&B International Group client and * organization.
- Create a purchase order Ex: Cerveza Ale 0.5L Qty:10
- Create a Sales order Ex: Cerveza Ale 0.5L QTY:5
- Go to the sales Order and click on manage reservation and add previous purchase order line prereservation
- Go again to manage reservation and check stock reservation related to previous the purchase order line appears.
- Navigate to the Stock reservation window and click on the record with above sales order line, the purchase order line is shown in Stock tab.
(0110259)
hgbot   
2019-03-06 16:01   
Repository: erp/devel/pi
Changeset: 4eae47894e328b486388fe3de4a3ad18af203e7d
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Mar 05 19:04:20 2019 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/4eae47894e328b486388fe3de4a3ad18af203e7d [^]

Fixes Issue 0040284: Manage pre-reservation not possible

** Do not use strict join on storage bin in query used to
get selected lines to avoid skipping of reservation stock
(pre-reservation) as they do not have storage bins, hence
used left join in place.

---
M src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java
---
(0110264)
Sandrahuguet   
2019-03-06 16:34   
code review + testing ok
(0110849)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0116585)
hgbot   
2019-12-31 10:51   
Repository: tools/automation/int
Changeset: e2da23e1f87c7d1d4f83ab906bad5ac22b41df24
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Sat Nov 23 01:02:56 2019 -0500
URL: http://code.openbravo.com/tools/automation/int/rev/e2da23e1f87c7d1d4f83ab906bad5ac22b41df24 [^]

Related to issue 40284: Added some automated tests

---
M src-test/com/openbravo/test/integration/erp/data/sales/transactions/salesorder/ManageReservationData.java
M src-test/com/openbravo/test/integration/erp/gui/sales/transactions/salesorder/LinesTab.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/gui/pickandexecute/PickAndExecuteWindow.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/reservation/testsuites/RES_Regressions/RES_Regressions3/RES_RegressionSuite3.java
M src-test/com/openbravo/test/integration/erp/modules/userinterface/smartclient/gui/Grid.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/reservation/testsuites/RES_Regressions/RES_Regressions3/RESRegression40284.java
---