Openbravo Issue Tracking System - Retail Modules
View Issue Details
0040280Retail ModulesWeb POSpublic2019-01-18 12:042019-03-27 13:47
nicolasuriz 
gorka_gil 
highmajoralways
closedfixed 
5
 
RR19Q1RR19Q1 
guilleaer
No
0040280: Wrong behaviour of the destination in the overpayment of an order with pay open tickets and two different payment methods.
A pay open tickets with two layaways, and paying them with two different payment methods differents to cash, for example "Voucher" and "Credit Card". Voucher is defined as "0" in overpayment limit and the other is permitted. An overpayment of 0.01 is done, and in backend is registered as an other payment and with two lines of 1 cent each.

Reproduced in livebuilds, retail with modules.

Check this video in case o dubts about the backend register:
https://drive.google.com/file/d/1-GJuC6wHItgR38tfEV2Xq57dCv8__WZC/view [^]
1) Go to backend, Channel touchpoint of "VBS-1" and then navigate to the Touchpoint type.
2) Go to "payment method" tab and define Voucher as not possible to do overpayments with value "0" and credit card allowing overpayments with value "".
3) Login to POS Create two layaways with the same Bussiness partner, one of them with 129.99$ and the other with 49.99$.
4) Open the previous layaways.
5) Do a pay open tickets with both of them.
6) Pay 149.99$ with Voucher as payment method and other with 30$ with credit card.
7) Login to backend, and check the "payment in" window.
8) There is one payment created for the overpayment, and at line level of this payment, there are two lines with 0.01 cents each when the overpayment is only 0.01 in total.
The overpayment should be displayed in the same “payment in” window line with the suppose payment method of the order, in this case should be displayed in the "wire transfer" payment method line, as one line more, and not as another payment. Anyway, it is not correct to have two lines of the same overpayment, it is a mistake.
No tags attached.
blocks defect 0039974 closed gorka_gil Wrong behaviour of the destination in the overpayment of an order with pay open tickets and two different payment methods. 
Issue History
2019-02-27 10:42gorka_gilTypedefect => backport
2019-02-27 10:42gorka_gilTarget Version => RR19Q1
2019-02-27 11:20hgbotCheckin
2019-02-27 11:20hgbotNote Added: 0110101
2019-02-27 11:20hgbotStatusscheduled => resolved
2019-02-27 11:20hgbotResolutionopen => fixed
2019-02-27 11:20hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7e3dcc1726ae8b26bae49be36b3b04185ef255ce [^] => http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/f1154d07d527f51537d9cdae41d8da79d9b11639 [^]
2019-02-27 11:20hgbotCheckin
2019-02-27 11:20hgbotNote Added: 0110102
2019-02-27 11:20hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/f1154d07d527f51537d9cdae41d8da79d9b11639 [^] => http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/0b16f5e307f5aa041685ebc073ac59e79fd7f369 [^]
2019-02-27 11:23hgbotCheckin
2019-02-27 11:23hgbotNote Added: 0110103
2019-02-27 11:23hgbotCheckin
2019-02-27 11:23hgbotNote Added: 0110104
2019-03-06 17:43guilleaerReview Assigned To => guilleaer
2019-03-06 17:43guilleaerStatusresolved => closed
2019-03-06 17:43guilleaerFixed in Version => RR19Q2
2019-03-06 17:43guilleaerFixed in VersionRR19Q2 => RR19Q1
2019-03-27 13:46hgbotCheckin
2019-03-27 13:46hgbotNote Added: 0110691
2019-03-27 13:47hgbotCheckin
2019-03-27 13:47hgbotNote Added: 0110692

Notes
(0110101)
hgbot   
2019-02-27 11:20   
Repository: retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal
Changeset: f1154d07d527f51537d9cdae41d8da79d9b11639
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Feb 06 11:48:26 2019 -0500
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/f1154d07d527f51537d9cdae41d8da79d9b11639 [^]

Fixed issue 40280: Wrong behaviour of the destination in the overpayment of an
order with pay open tickets and two different payment methods.

- Avoided duplicate Payment In record for positive overpayment

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0110102)
hgbot   
2019-02-27 11:20   
Repository: retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal
Changeset: 0b16f5e307f5aa041685ebc073ac59e79fd7f369
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Fri Feb 22 22:52:32 2019 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/0b16f5e307f5aa041685ebc073ac59e79fd7f369 [^]

Fixed issue 40280: The overpayment was not setting correctly

When overpayment was being generated from the Web POS, instead of the overpayment an empty payment detail was being created caused by a credit generation, which shouldn't happen.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0110103)
hgbot   
2019-02-27 11:23   
Repository: retail/backports/3.0RR19Q1/pi-mobile
Changeset: 2a6a1b97b3eca7d8ecdc41df12c95addfcaec492
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Jan 23 14:20:51 2019 -0500
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1/pi-mobile/rev/2a6a1b97b3eca7d8ecdc41df12c95addfcaec492 [^]

Related to issue 40280: added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/payment/I39974_VerifyOverpaymentWith2DifferentPaymentMethods.java
---
(0110104)
hgbot   
2019-02-27 11:23   
Repository: retail/backports/3.0RR19Q1/pi-mobile
Changeset: e072b18c94a797d82a5849bcb4955213c6fd466e
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Feb 06 11:51:04 2019 -0500
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1/pi-mobile/rev/e072b18c94a797d82a5849bcb4955213c6fd466e [^]

Related to issue 40280: Avoided duplicate Payment In record for overpayment

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/payment/I39726_VerifyNoErrorWithAndWithoutOverpayments.java
---
(0110691)
hgbot   
2019-03-27 13:46   
Repository: tools/automation/pi-mobile
Changeset: 2a6a1b97b3eca7d8ecdc41df12c95addfcaec492
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Jan 23 14:20:51 2019 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2a6a1b97b3eca7d8ecdc41df12c95addfcaec492 [^]

Related to issue 40280: added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/payment/I39974_VerifyOverpaymentWith2DifferentPaymentMethods.java
---
(0110692)
hgbot   
2019-03-27 13:47   
Repository: tools/automation/pi-mobile
Changeset: e072b18c94a797d82a5849bcb4955213c6fd466e
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Feb 06 11:51:04 2019 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e072b18c94a797d82a5849bcb4955213c6fd466e [^]

Related to issue 40280: Avoided duplicate Payment In record for overpayment

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/payment/I39726_VerifyNoErrorWithAndWithoutOverpayments.java
---