Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040278Openbravo ERP07. Sales managementpublic2019-02-26 17:472019-03-28 14:56
Reporterngarcia 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040278: Create Shipments From Orders is linking invoice lines with shipment lines that have different products if the order is invoiced
DescriptionCreate Shipments From Orders is linking invoice lines with shipment lines that have different products if the order is invoiced
Steps To ReproduceAs group admin role:
   Create 4 products and add a sales price to them
   Create a Goods Receipt:
      Add 2.5 units of the A product in a storage bin
      Add 5 units of the A product in a different storage bin
      Add 2.5 units of the A product in a different storage bin
      Add 5 units of the B product in a different storage bin

   Create a Sales Order
      Add 10 units of the A product to it
      Add 5 units of the B product to it
      Add 10 units of the C product to it
      Add 10 units of the D product to it

    Set it's invoice terms as Immediate and book it

    Go to Create Invoices From Orders and select previously created order
    Go to Create Shipments From Orders and select previously created order

    Go to the Sales Invoice created and check that the 3rd (product C) and 4th
 (product D) lines are related with the 2nd line of the shipment (product B)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0033042 new Triage Omni OMS Partially shipped Goods Shipment Line is linked to completely invoiced Sales Invoice Line 
depends on backport 00403143.0PR19Q1 closed AtulOpenbravo Create Shipments From Orders is linking invoice lines with shipment lines that have different products if the order is invoiced 
depends on backport 00403153.0PR18Q4.3 closed AtulOpenbravo Create Shipments From Orders is linking invoice lines with shipment lines that have different products if the order is invoiced 
Attached Files? QueryToUpdateWrongData_40278.sql (286) 2019-03-11 13:51
https://issues.openbravo.com/file_download.php?file_id=12733&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-02-26 17:47ngarciaNew Issue
2019-02-26 17:47ngarciaAssigned To => Triage Finance
2019-02-26 17:47ngarciaModules => Core
2019-02-26 17:47ngarciaResolution time => 1552950000
2019-02-26 17:47ngarciaTriggers an Emergency Pack => No
2019-02-26 17:49ngarciaIssue Monitored: networkb
2019-02-27 10:25SandrahuguetAssigned ToTriage Finance => AtulOpenbravo
2019-02-27 19:21AtulOpenbravoStatusnew => scheduled
2019-02-28 07:41AtulOpenbravoNote Added: 0110113
2019-02-28 07:42AtulOpenbravoRelationship addedrelated to 0033042
2019-03-05 11:28AtulOpenbravoStatusscheduled => acknowledged
2019-03-05 11:29AtulOpenbravoStatusacknowledged => scheduled
2019-03-06 13:34hgbotCheckin
2019-03-06 13:34hgbotNote Added: 0110253
2019-03-06 13:34hgbotStatusscheduled => resolved
2019-03-06 13:34hgbotResolutionopen => fixed
2019-03-06 13:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/461aa8d25eb6d87bb91a02bfabd8e9c3f0854c1a [^]
2019-03-06 15:29SandrahuguetReview Assigned To => Sandrahuguet
2019-03-06 15:29SandrahuguetNote Added: 0110258
2019-03-06 15:29SandrahuguetStatusresolved => closed
2019-03-06 15:29SandrahuguetFixed in Version => 3.0PR19Q2
2019-03-11 13:51AtulOpenbravoFile Added: QueryToUpdateWrongData_40278.sql
2019-03-11 13:53AtulOpenbravoNote Added: 0110349
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110848

Notes
(0110113)
AtulOpenbravo   
2019-02-28 07:41   
Test Plan

- Login as F&B International Group admin role:
- Create 4 products in F&B Espana Org. and add a sales price to them
- Create a Goods Receipt in F&B Espana Org.
      Add 2.5 units of the product A in a storage bin RN-0-0-0
      Add 5 units of the product A in a different storage bin RN-1-0-0
      Add 2.5 units of the product A in a different storage bin RN-2-0-0
      Add 5 units of the B product A in a different storage bin RN-Dev

- Create a Sales Order in F&B Espana Org.
      Add 10 units of the A product to it
      Add 5 units of the B product to it
      Add 10 units of the C product to it
      Add 10 units of the D product to it

- Set it's invoice terms as Immediate and book it

- Go to Create Invoices From Orders and select previously created order
- Go to Create Shipments From Orders and select previously created order

- Go to the Sales Invoice created and check that the 3rd (product C) and 4th
 (product D) lines have Goods Shipment Line reference as blank.
(0110253)
hgbot   
2019-03-06 13:34   
Repository: erp/devel/pi
Changeset: 461aa8d25eb6d87bb91a02bfabd8e9c3f0854c1a
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Feb 28 11:24:05 2019 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/461aa8d25eb6d87bb91a02bfabd8e9c3f0854c1a [^]

Fixes Issue 40278:Create Shipments From Orders is linking invoice
lines with shipment lines that have different products if the order
is invoiced

Reset the m_inoutline_id stored in v_NextNo when a new orderline
is being used to create m_inoutline record

---
M src-db/database/model/functions/M_INOUT_CREATE.xml
---
(0110258)
Sandrahuguet   
2019-03-06 15:29   
Code review + testing ok
(0110349)
AtulOpenbravo   
2019-03-11 13:53   
Attached query to fix wrong data. If required to establish 1 to 1 relationship between goods shipment line and sales invoice line, query attached in 32938 could be used.

https://issues.openbravo.com/view.php?id=32938 [^]
(0110848)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test